Fix Memory leaks (#1678)

* Refactor to fix #1671

* Add GUI/NonGUI mode to info page

* Do not show lock config, if in non-UI mode

* Updae Changelog

* Correct includes

* Ensure key member initialization - RGB Channels

* Ensure key member initialization - WebServer

* Update RGBChannels

* Fix initialization order

* Fix key when inserting new logger in LoggerMap,
Prepare logBuffer-JSON snapshot view in LoggerManager,
Increase buffered loglines to 500

* Fix Memory leak in GrabberWrapper

* Fix Memory leak in BlackBorderProcessor

* Fix Memory leak in BlackBorderProcessor

* use ninja generator under macos

* Fix BGEffectHandler destruction

* Fix Mdns code

* Clear list after applying qDeleteAll

* Fix deletion of CecHandler

* Fix memory leak caused by wrong buffer allocation

* Remove extra pixel consistently

* Change mDNS to Qt SmartPointers

* Correct removal

* Fix usage of _width/_height (they are the output resolution, not the screen resolution)
That avoids unnecessary resizing of the output image with every transferFrame call

* Move main non Thread Objects to Smart Pointers

* Revert "Move main non Thread Objects to Smart Pointers"

This reverts commit 26102ca963.

* Add missing deletes

* Revert MdnsBrowser chnage

* Revert MdnsBrowser change

* Fix memory leaks related standalone grabber

* Address CodeQL finding

* delete pointer OsxFrameGrabber

---------

Co-authored-by: Paulchen-Panther <16664240+Paulchen-Panther@users.noreply.github.com>

include/utils/Image.h

@@ -15,9 +15,8 @@ public:
 	{
 	}
 
-	Image(unsigned width, unsigned height) :
+	Image(int width, int height) :
 		Image(width, height, Pixel_T())
-
 	{
 	}
 
@@ -28,7 +27,7 @@ public:
 	/// @param height The height of the image
 	/// @param background The color of the image
 	///
-	Image(unsigned width, unsigned height, const Pixel_T background) :
+	Image(int width, int height, const Pixel_T background) :
 		_d_ptr(new ImageData<Pixel_T>(width, height, background))
 	{
 	}
@@ -78,7 +77,7 @@ public:
 	///
 	/// @return The width of the image
 	///
-	inline unsigned width() const
+	inline int width() const
 	{
 		return _d_ptr->width();
 	}
@@ -88,7 +87,7 @@ public:
 	///
 	/// @return The height of the image
 	///
-	inline unsigned height() const
+	inline int height() const
 	{
 		return _d_ptr->height();
 	}
@@ -111,7 +110,7 @@ public:
 	///
 	/// @return const reference to specified pixel
 	///
-	uint8_t blue(unsigned pixel) const
+	uint8_t blue(int pixel) const
 	{
 		return _d_ptr->blue(pixel);
 	}
@@ -121,7 +120,7 @@ public:
 	///
 	/// @param x The x index
 	/// @param y The y index
-	const Pixel_T& operator()(unsigned x, unsigned y) const
+	const Pixel_T& operator()(int x, int y) const
 	{
 		return _d_ptr->operator()(x, y);
 	}
@@ -129,7 +128,7 @@ public:
 	///
 	/// @return reference to specified pixel
 	///
-	Pixel_T& operator()(unsigned x, unsigned y)
+	Pixel_T& operator()(int x, int y)
 	{
 		return _d_ptr->operator()(x, y);
 	}
@@ -137,7 +136,7 @@ public:
 	/// Resize the image
 	/// @param width The width of the image
 	/// @param height The height of the image
-	void resize(unsigned width, unsigned height)
+	void resize(int width, int height)
 	{
 		_d_ptr->resize(width, height);
 	}
@@ -198,12 +197,11 @@ private:
 	///
 	/// @return The index into the underlying data-vector
 	///
-	inline unsigned toIndex(unsigned x, unsigned y) const
+	inline int toIndex(int x, int y) const
 	{
 		return _d_ptr->toIndex(x, y);
 	}
 
-private:
 	QSharedDataPointer<ImageData<Pixel_T>>  _d_ptr;
 };
 

include/utils/ImageData.h

@@ -1,12 +1,9 @@
 #pragma once
 
 // STL includes
-#include <vector>
 #include <cstdint>
 #include <cstring>
 #include <algorithm>
-#include <cassert>
-#include <type_traits>
 #include <utils/ColorRgb.h>
 
 // QT includes
@@ -24,10 +21,10 @@ class ImageData : public QSharedData
 public:
 	typedef Pixel_T pixel_type;
 
-	ImageData(unsigned width, unsigned height, const Pixel_T background) :
+	ImageData(int width, int height, const Pixel_T background) :
 		_width(width),
 		_height(height),
-		_pixels(new Pixel_T[width * height + 1])
+		_pixels(new Pixel_T[static_cast<size_t>(width) * static_cast<size_t>(height)])
 	{
 		std::fill(_pixels, _pixels + width * height, background);
 	}
@@ -36,9 +33,9 @@ public:
 		QSharedData(other),
 		_width(other._width),
 		_height(other._height),
-		_pixels(new Pixel_T[other._width * other._height + 1])
+		_pixels(new Pixel_T[static_cast<size_t>(other._width) * static_cast<size_t>(other._height)])
 	{
-		memcpy(_pixels, other._pixels, static_cast<ulong>(other._width) * static_cast<ulong>(other._height) * sizeof(Pixel_T));
+		memcpy(_pixels, other._pixels, static_cast<size_t>(other._width) * static_cast<size_t>(other._height) * sizeof(Pixel_T));
 	}
 
 	ImageData& operator=(ImageData rhs)
@@ -74,52 +71,57 @@ public:
 		delete[] _pixels;
 	}
 
-	inline unsigned width() const
+	inline int width() const
 	{
 		return _width;
 	}
 
-	inline unsigned height() const
+	inline int height() const
 	{
 		return _height;
 	}
 
-	uint8_t red(unsigned pixel) const
+	uint8_t red(int pixel) const
 	{
 		return (_pixels + pixel)->red;
 	}
 
-	uint8_t green(unsigned pixel) const
+	uint8_t green(int pixel) const
 	{
 		return (_pixels + pixel)->green;
 	}
 
-	uint8_t blue(unsigned pixel) const
+	uint8_t blue(int pixel) const
 	{
 		return (_pixels + pixel)->blue;
 	}
 
-	const Pixel_T& operator()(unsigned x, unsigned y) const
+	const Pixel_T& operator()(int x, int y) const
 	{
 		return _pixels[toIndex(x,y)];
 	}
 
-	Pixel_T& operator()(unsigned x, unsigned y)
+	Pixel_T& operator()(int x, int y)
 	{
 		return _pixels[toIndex(x,y)];
 	}
 
-	void resize(unsigned width, unsigned height)
+	void resize(int width, int height)
 	{
 		if (width == _width && height == _height)
-			return;
-
-		if ((width * height) > unsigned((_width * _height)))
 		{
-			delete[] _pixels;
-			_pixels = new Pixel_T[width*height + 1];
+			return;
 		}
 
+		// Allocate a new buffer without initializing the content
+		Pixel_T* newPixels = new Pixel_T[static_cast<size_t>(width) * static_cast<size_t>(height)];
+
+		// Release the old buffer without copying data
+		delete[] _pixels;
+
+		// Update the pointer to the new buffer
+		_pixels = newPixels;
+
 		_width = width;
 		_height = height;
 	}
@@ -137,11 +139,13 @@ public:
 	void toRgb(ImageData<ColorRgb>& image) const
 	{
 		if (image.width() != _width || image.height() != _height)
+		{
 			image.resize(_width, _height);
+		}
 
-		const unsigned imageSize = _width * _height;
+		const int imageSize = _width * _height;
 
-		for (unsigned idx = 0; idx < imageSize; idx++)
+		for (int idx = 0; idx < imageSize; idx++)
 		{
 			const Pixel_T & color = _pixels[idx];
 			image.memptr()[idx] = ColorRgb{color.red, color.green, color.blue};
@@ -157,26 +161,22 @@ public:
 	{
 		if (_width != 1 || _height != 1)
 		{
-			_width = 1;
-			_height = 1;
-			delete[] _pixels;
-			_pixels = new Pixel_T[2];
+			resize(1,1);
 		}
-
-		memset(_pixels, 0, static_cast<unsigned long>(_width) * static_cast<unsigned long>(_height) * sizeof(Pixel_T));
+		// Set the single pixel to the default background
+		_pixels[0] = Pixel_T();
 	}
 
 private:
-	inline unsigned toIndex(unsigned x, unsigned y) const
+	inline int toIndex(int x, int y) const
 	{
 		return y * _width + x;
 	}
 
-private:
 	/// The width of the image
-	unsigned _width;
+	int _width;
 	/// The height of the image
-	unsigned _height;
+	int _height;
 	/// The pixels of the image
 	Pixel_T* _pixels;
 };

include/utils/Logger.h

@@ -6,6 +6,7 @@
 #include <QMap>
 #include <QAtomicInteger>
 #include <QList>
+#include <QJsonArray>
 
 #if (QT_VERSION >= QT_VERSION_CHECK(5, 14, 0))
 	#include <QRecursiveMutex>
@@ -14,8 +15,6 @@
 #endif
 
 // stl includes
-#include <stdio.h>
-#include <stdarg.h>
 #ifdef _WIN32
 #include <stdexcept>
 #endif
@@ -59,7 +58,7 @@ public:
 		QString      function;
 		unsigned int line;
 		QString      fileName;
-		uint64_t     utime;
+		qint64       utime;
 		QString      message;
 		LogLevel     level;
 		QString      levelString;
@@ -74,7 +73,7 @@ public:
 	void     setMinLevel(LogLevel level) { _minLevel = static_cast<int>(level); }
 	LogLevel getMinLevel() const { return static_cast<LogLevel>(int(_minLevel)); }
 	QString  getName() const { return _name; }
-	QString  getSubName() const { return _subname; }
+	QString  getSubName() const { return _subName; }
 
 signals:
 	void newLogMessage(Logger::T_LOG_MESSAGE);
@@ -95,7 +94,7 @@ private:
 	static QAtomicInteger<int>   GLOBAL_MIN_LOG_LEVEL;
 
 	const QString                _name;
-	const QString                _subname;
+	const QString                _subName;
 	const bool                   _syslogEnabled;
 	const unsigned               _loggerId;
 
@@ -109,15 +108,15 @@ class LoggerManager : public QObject
 
 public:
 	static LoggerManager* getInstance();
-	const QList<Logger::T_LOG_MESSAGE>* getLogMessageBuffer() const { return &_logMessageBuffer; }
 
 public slots:
 	void handleNewLogMessage(const Logger::T_LOG_MESSAGE&);
+	QJsonArray getLogMessageBuffer(Logger::LogLevel filter=Logger::UNSET) const;
 
 signals:
 	void newLogMessage(const Logger::T_LOG_MESSAGE&);
 
-protected:
+private:
 	LoggerManager();
 
 	QList<Logger::T_LOG_MESSAGE>   _logMessageBuffer;

include/utils/hyperion.h

@@ -96,7 +96,7 @@ namespace hyperion {
 			static_cast<uint8_t>(channelConfig[0].toInt(defaultR)),
 			static_cast<uint8_t>(channelConfig[1].toInt(defaultG)),
 			static_cast<uint8_t>(channelConfig[2].toInt(defaultB)),
-			"ChannelAdjust_" + channelName.toUpper()
+			channelName
 		);
 	}