AtmoOrb Fix (#988)

* AtmoOrb UdpSocket-Bind Fix

* Cleanup and update defaults (to work via PowerLan)

* Cleanup and update defaults (to work via PowerLan)

* AtmoOrb identification support, small updates

* AtmoOrb discovery & identification support, fixes and stability updates

* Small clean-ups

* Type fix

* Add missing include

* Adalight - Update default config and levels

* Update Atmoorb sketch

* Yeelight - Update default value

assets/firmware/esp8266/AtmoOrb/AtmoOrb.ino

@@ -0,0 +1,354 @@
+// AtmoOrb by Lightning303 & Rick164, Additions by Lord-Grey
+//
+// ESP8266 Standalone Version
+//
+//
+// You may change the settings that are commented
+
+#define FASTLED_ALLOW_INTERRUPTS 0
+// To make sure that all leds get changed 100% of the time, we need to allow FastLED to disabled interrupts for a short while.
+// If you experience problems, please set this value to 1.
+// This is only needed for 3 wire (1 data line + Vcc and GND) chips (e.g. WS2812B). If you are using WS2801, APA102 or similar chipsets, you can set the value back to 1.
+
+#include <ESP8266WiFi.h>
+#include <WiFiUdp.h>
+#include <FastLED.h>
+
+#define NUM_LEDS 24 // Number of leds
+#define DATA_PIN 7 // Data pin for leds (the default pin 7 might correspond to pin 13 on some boards)
+#define SERIAL_DEBUG 0 // Serial debugging (0=Off, 1=On)
+
+#define ID 1 // Id of this lamp
+
+// Smoothing
+#define SMOOTH_STEPS 20 // Steps to take for smoothing colors
+#define SMOOTH_DELAY 10 // Delay between smoothing steps
+#define SMOOTH_BLOCK 0 // Block incoming colors while smoothing
+
+// Startup color
+#define STARTUP_RED 255 // Color shown directly after power on
+#define STARTUP_GREEN 175 // Color shown directly after power on
+#define STARTUP_BLUE 100 // Color shown directly after power on
+
+// White adjustment
+#define RED_CORRECTION 220 // Color Correction
+#define GREEN_CORRECTION 255 // Color Correction
+#define BLUE_CORRECTION 180 // Color Correction
+
+// RC Switch
+#define RC_SWITCH 0 // RF transmitter to swtich remote controlled power sockets (0=Off, 1=On)
+#if RC_SWITCH == 1
+  #include <RCSwitch.h>
+  #define RC_PIN 2 // Data pin for RF transmitter
+  #define RC_SLEEP_DELAY 900000 // Delay until RF transmitter send signals
+  char* rcCode0 = "10001"; // First part of the transmission code
+  char* rcCode1 = "00010"; // Second part of the transmission code
+  RCSwitch mySwitch = RCSwitch();
+  boolean remoteControlled = false;
+#endif
+
+// Network settings
+const char* ssid = "***"; // WiFi SSID
+const char* password = "***"; // WiFi password
+
+const IPAddress multicastIP(239,255,255,250); // Multicast IP address
+const int multicastPort = 49692; // Multicast port number
+IPAddress    ip_null(0,0,0,0);
+IPAddress    local_IP(0,0,0,0);
+WiFiUDP Udp;
+
+int          timeout    = 20000;      // wait 20 sec for successfull login
+boolean      is_connect = false;      // ... not yet connected
+
+CRGB leds[NUM_LEDS];
+
+byte nextColor[3];
+byte prevColor[3];
+byte currentColor[3];
+byte smoothStep = SMOOTH_STEPS;
+unsigned long smoothMillis;
+
+void setColor(byte red, byte green, byte blue);
+void setSmoothColor(byte red, byte green, byte blue);
+void smoothColor();
+void clearSmoothColors();
+
+void setup()
+{
+  FastLED.addLeds<WS2812B, DATA_PIN, GRB>(leds, NUM_LEDS);
+  //FastLED.setCorrection(TypicalSMD5050);
+  FastLED.setCorrection(CRGB(RED_CORRECTION, GREEN_CORRECTION, BLUE_CORRECTION));
+  FastLED.showColor(CRGB(STARTUP_RED, STARTUP_GREEN, STARTUP_BLUE));
+
+  #if RC_SWITCH == 1
+    mySwitch.enableTransmit(RC_PIN);
+  #endif
+
+  #if SERIAL_DEBUG == 1
+    Serial.begin(115200);
+  #endif
+
+  #if SERIAL_DEBUG == 1
+    Serial.printf("Connecting to %s ", ssid);
+  #endif
+
+  // .... wait for WiFi gets valid !!!
+  unsigned long tick = millis();      // get start-time for login
+  WiFi.begin(ssid, password);
+  while ( (!is_connect) &&  ((millis() - tick) < timeout) )
+  {
+    yield();                          // ... for safety
+    is_connect = WiFi.status();       // connected ?
+    if (!is_connect)                  // only if not yet connected !
+    {
+      #if SERIAL_DEBUG == 1
+        Serial.print(".");              // print a dot while waiting
+      #endif
+      delay(50);
+    }
+  }
+  
+  if (is_connect)
+  {
+    #if SERIAL_DEBUG == 1
+      Serial.print("after ");
+      Serial.print(millis() - tick);
+      Serial.println(" ms");
+    #endif
+    // .... wait for local_IP becomes valid !!!
+    is_connect = false;
+    tick = millis();      // get start-time for login
+    while ( (!is_connect) &&  ((millis() - tick) < timeout) )
+    {
+      yield();                          // ... for safety
+      local_IP = WiFi.localIP(); 
+      is_connect = local_IP != ip_null;       // connected ?
+      if (!is_connect)                  // only if not yet connected !
+      {
+        #if SERIAL_DEBUG == 1
+          Serial.print(".");              // print a dot while waiting
+        #endif
+        delay(50);
+      }
+    }
+    if (is_connect)
+    {
+      #if SERIAL_DEBUG == 1
+        Serial.print("local_IP valid after ");
+        Serial.print(millis() - tick);
+        Serial.println(" ms");
+        Serial.println("");
+        Serial.print(F("Connected to "));
+        Serial.println(ssid);
+      #endif
+
+       // ... now start UDP and check the result:
+      is_connect = Udp.beginMulticast(local_IP, multicastIP, multicastPort);
+      if (is_connect)
+      {
+        #if SERIAL_DEBUG == 1      
+          Serial.print("Listening to Multicast at ");
+          Serial.print(multicastIP);
+          Serial.println(":" + String(multicastPort));
+        #endif
+      }
+      else
+      {
+        #if SERIAL_DEBUG == 1      
+          Serial.println(" - ERROR beginMulticast !");
+        #endif
+      }
+    }
+    else
+    {
+      #if SERIAL_DEBUG == 1     
+        Serial.println("local_IP invalid after timeout !");
+      #endif
+    }
+  }
+  else
+  {
+    #if SERIAL_DEBUG == 1     
+      Serial.println("- invalid after timeout !");      
+    #endif
+  }
+}
+
+void loop()
+{
+  #if SERIAL_DEBUG == 1
+    if (WiFi.status() != WL_CONNECTED)
+    {
+      Serial.print(F("Lost connection to "));
+      Serial.print(ssid);
+      Serial.println(F("."));
+      Serial.println(F("Trying to reconnect."));
+      while (WiFi.status() != WL_CONNECTED)
+      {
+        delay(500);
+        Serial.print(F("."));
+      }
+      Serial.println("");
+      Serial.println(F("Reconnected."));
+    }
+  #endif
+  if (Udp.parsePacket())
+  {
+    byte len = Udp.available();
+    byte rcvd[len];
+    Udp.read(rcvd, len);
+
+    #if SERIAL_DEBUG == 1
+      Serial.print(F("UDP Packet from "));
+      Serial.print(Udp.remoteIP());
+      Serial.print(F(":"));
+      Serial.print(Udp.remotePort());
+      Serial.print(F(" to "));
+      Serial.println(Udp.destinationIP());
+      for (byte i = 0; i < len; i++)
+      {
+        Serial.print(rcvd[i]);
+        Serial.print(F(" "));
+      }
+      Serial.println("");
+    #endif
+    if (len >= 8 && rcvd[0] == 0xC0 && rcvd[1] == 0xFF && rcvd[2] == 0xEE && (rcvd[4] == ID || rcvd[4] == 0))
+    {
+      switch (rcvd[3])
+      {
+        case 1:
+          smoothStep = SMOOTH_STEPS;
+          forceLedsOFF();
+          break;
+        case 2:
+        default:
+          setSmoothColor(rcvd[5], rcvd[6], rcvd[7]);
+          break;
+        case 4:
+          setColor(rcvd[5], rcvd[6], rcvd[7]);
+          smoothStep = SMOOTH_STEPS;
+          break;
+        case 8:
+          #if SERIAL_DEBUG == 1
+            Serial.print(F("Announce myself. OrbID: "));
+            Serial.println(ID);
+          #endif
+          Udp.beginPacket(Udp.remoteIP(), Udp.remotePort());
+          Udp.write(ID);
+          Udp.endPacket();
+          break;
+        case 9:
+          #if SERIAL_DEBUG == 1
+            Serial.print(F("Identify myself. OrbID: "));
+            Serial.println(ID);
+          #endif
+          identify();
+          break;
+      }
+    }
+  }
+  if (smoothStep < SMOOTH_STEPS && millis() >= (smoothMillis + (SMOOTH_DELAY * (smoothStep + 1))))
+  {
+    smoothColor();
+  }
+  #if RC_SWITCH == 1
+    if (remoteControlled && currentColor[0] == 0 && currentColor[1] == 0 && currentColor[2] == 0 && millis() >= smoothMillis + RC_SLEEP_DELAY)
+    {
+      // Send this signal only once every seconds
+      smoothMillis += 1000;
+      mySwitch.switchOff(rcCode0, rcCode1);
+    }
+  #endif
+}
+
+// Display color on leds
+void setColor(byte red, byte green, byte blue)
+{
+  // Is the new color already active?
+  if (currentColor[0] == red && currentColor[1] == green && currentColor[2] == blue)
+  {
+    return;
+  }
+  currentColor[0] = red;
+  currentColor[1] = green;
+  currentColor[2] = blue;
+
+  FastLED.showColor(CRGB(red, green, blue));
+}
+
+// Set a new color to smooth to
+void setSmoothColor(byte red, byte green, byte blue)
+{
+  if (smoothStep == SMOOTH_STEPS || SMOOTH_BLOCK == 0)
+  {
+    // Is the new color the same as the one we already are smoothing towards?
+    // If so dont do anything.
+    if (nextColor[0] == red && nextColor[1] == green && nextColor[2] == blue)
+    {
+      return;
+    }
+    // Is the new color the same as we have right now?
+    // If so stop smoothing and keep the current color.
+    else if (currentColor[0] == red && currentColor[1] == green && currentColor[2] == blue)
+    {
+      smoothStep = SMOOTH_STEPS;
+      return;
+    }
+
+    prevColor[0] = currentColor[0];
+    prevColor[1] = currentColor[1];
+    prevColor[2] = currentColor[2];
+
+    nextColor[0] = red;
+    nextColor[1] = green;
+    nextColor[2] = blue;
+
+    smoothMillis = millis();
+    smoothStep = 0;
+
+    #if RC_SWITCH == 1
+      if (!remoteControlled)
+      {
+        remoteControlled = true;
+      }
+    #endif
+  }
+}
+
+// Display one step to the next color
+void smoothColor()
+{
+  smoothStep++;
+
+  byte red = prevColor[0] + (((nextColor[0] - prevColor[0]) * smoothStep) / SMOOTH_STEPS);
+  byte green = prevColor[1] + (((nextColor[1] - prevColor[1]) * smoothStep) / SMOOTH_STEPS);
+  byte blue = prevColor[2] + (((nextColor[2] - prevColor[2]) * smoothStep) / SMOOTH_STEPS);   
+
+  setColor(red, green, blue);
+}
+
+// Force all leds OFF
+void forceLedsOFF()
+{
+    setColor(0,0,0);
+    clearSmoothColors();
+}
+ 
+// Clear smooth color byte arrays
+void clearSmoothColors()
+{
+    memset(prevColor, 0, sizeof(prevColor));
+    memset(currentColor, 0, sizeof(nextColor));
+    memset(nextColor, 0, sizeof(nextColor));
+}
+
+void identify()
+{
+  for (byte i = 0; i < 3; i++)
+  {
+    FastLED.showColor(CRGB::LemonChiffon);
+    delay(500);
+    FastLED.showColor(CRGB::Black);   
+    delay(500);
+  }
+}

assets/webconfig/i18n/en.json

@@ -397,6 +397,10 @@
 	"wiz_yeelight_desc2" : "Now choose which lamps should be added. The position assigns the lamp to a specific position on your \"picture\". Disabled lamps won't be added. To identify single lamps press the button on the right.",
 	"wiz_yeelight_noLights": "No Yeelights found! Please get the lights connected to the network or configure them mannually.",
 	"wiz_yeelight_unsupported" : "Unsupported",
+	"wiz_atmoorb_title" : "AtmoOrb Wizard",
+	"wiz_atmoorb_intro1" : "This wizards configures Hyperion for AtmoOrbs. Features are the AtmoOrb auto detection, setting each light to a specific position on your picture or disable it and tune the Hyperion settings automatically! So in short: All you need are some clicks and you are done!",
+	"wiz_atmoorb_desc2" : "Now choose which Orbs should be added. The position assigns the lamp to a specific position on your \"picture\". Disabled lamps won't be added. To identify single lamps press the button on the right.",
+	"wiz_atmoorb_noLights": "No AtmoOrbs found! Please get the lights connected to the network or configure them mannually.",
 	"wiz_pos": "Position/State",
 	"wiz_ids_disabled" : "Deactivated",
 	"wiz_ids_entire" : "Whole picture",	

assets/webconfig/js/content_leds.js

@@ -543,6 +543,12 @@ $(document).ready(function() {
     	    changeWizard(data, wled_title, startWizardWLED);
 	}
 */
+    else if(ledType == "atmoorb") {
+    	    var ledWizardType = (this.checked) ? "atmoorb" : ledType;
+    	    var data = { type: ledWizardType };
+    	    var atmoorb_title = 'wiz_atmoorb_title';
+    	    changeWizard(data, atmoorb_title, startWizardAtmoOrb);
+	}
 	else if(ledType == "yeelight") {
 		var ledWizardType = (this.checked) ? "yeelight" : ledType;
 		var data = { type: ledWizardType };

assets/webconfig/js/wizard.js

@@ -1259,16 +1259,16 @@ function startWizardWLED(e)
 
 // For testing only
   discover_wled();
-    
+
   var hostAddress = conf_editor.getEditor("root.specificOptions.host").getValue();
   if(hostAddress != "")
   {
     getProperties_wled(hostAddress,"info");
     identify_wled(hostAddress)  
   }
-  
+
 // For testing only
-    
+
   });
 }
 
@@ -1552,13 +1552,14 @@ function assign_yeelight_lights(){
 				options+= '>'+$.i18n(txt+val)+'</option>';
 			}
 
+			var enabled = 'enabled'
 			if (! models.includes (lights[lightid].model) )
 			{
 				var enabled = 'disabled';
 				options = '<option value=disabled>'+$.i18n('wiz_yeelight_unsupported')+'</option>';
 			}
 
-			$('.lidsb').append(createTableRow([(parseInt(lightid, 10) + 1)+'. '+lightName+' ('+lightHostname+')', '<select id="yee_'+lightid+'" '+enabled+' class="yee_sel_watch form-control">'
+			$('.lidsb').append(createTableRow([(parseInt(lightid, 10) + 1)+'. '+lightName+'<br>('+lightHostname+')', '<select id="yee_'+lightid+'" '+enabled+' class="yee_sel_watch form-control">'
 											   + options
 											   + '</select>','<button class="btn btn-sm btn-primary" onClick=identify_yeelight_device("'+lightHostname+'",'+lightPort+')>'
 											   + $.i18n('wiz_identify_light',lightName)+'</button>']));
@@ -1615,6 +1616,276 @@ function identify_yeelight_device(hostname, port){
 	}
 }
 
+//****************************
+// Wizard AtmoOrb
+//****************************
+var lights = null;
+function startWizardAtmoOrb(e)
+{
+	//create html
+
+	var atmoorb_title = 'wiz_atmoorb_title';
+	var atmoorb_intro1 = 'wiz_atmoorb_intro1';
+
+	$('#wiz_header').html('<i class="fa fa-magic fa-fw"></i>'+$.i18n(atmoorb_title));
+	$('#wizp1_body').html('<h4 style="font-weight:bold;text-transform:uppercase;">'+$.i18n(atmoorb_title)+'</h4><p>'+$.i18n(atmoorb_intro1)+'</p>');
+
+	$('#wizp1_footer').html('<button type="button" class="btn btn-primary" id="btn_wiz_cont"><i class="fa fa-fw fa-check"></i>'
+	+$.i18n('general_btn_continue')+'</button><button type="button" class="btn btn-danger" data-dismiss="modal"><i class="fa fa-fw fa-close"></i>'
+	+$.i18n('general_btn_cancel')+'</button>');
+
+	$('#wizp2_body').html('<div id="wh_topcontainer"></div>');
+
+	$('#wh_topcontainer').append('<div class="form-group" id="usrcont" style="display:none"></div>');
+
+	$('#wizp2_body').append('<div id="orb_ids_t" style="display:none"><p style="font-weight:bold" id="orb_id_headline">'+$.i18n('wiz_atmoorb_desc2')+'</p></div>');
+
+	createTable("lidsh", "lidsb", "orb_ids_t");
+	$('.lidsh').append(createTableRow([$.i18n('edt_dev_spec_lights_title'),$.i18n('wiz_pos'),$.i18n('wiz_identify')], true));
+	$('#wizp2_footer').html('<button type="button" class="btn btn-primary" id="btn_wiz_save" style="display:none"><i class="fa fa-fw fa-save"></i>'
+	+$.i18n('general_btn_save')+'</button><buttowindow.serverConfig.device = d;n type="button" class="btn btn-danger" id="btn_wiz_abort"><i class="fa fa-fw fa-close"></i>'
+	+$.i18n('general_btn_cancel')+'</button>');
+
+	//open modal
+	$("#wizard_modal").modal({backdrop : "static", keyboard: false, show: true });
+
+	//listen for continue
+	$('#btn_wiz_cont').off().on('click',function() {
+		beginWizardAtmoOrb();
+		$('#wizp1').toggle(false);
+		$('#wizp2').toggle(true);
+	});
+}
+
+function beginWizardAtmoOrb()
+{
+	lights = [];
+	configuredLights = [];
+
+	configruedOrbIds =  conf_editor.getEditor("root.specificOptions.orbIds").getValue().trim();
+	if ( configruedOrbIds.length !== 0 )
+	{
+	    configuredLights =  configruedOrbIds.split(",").map( Number );
+	}
+
+    var multiCastGroup = conf_editor.getEditor("root.specificOptions.output").getValue();
+    var multiCastPort = parseInt(conf_editor.getEditor("root.specificOptions.port").getValue());
+
+	discover_atmoorb_lights(multiCastGroup, multiCastPort);
+
+	$('#btn_wiz_save').off().on("click", function(){
+		var atmoorbLedConfig = [];
+		var finalLights = [];
+
+		//create atmoorb led config
+		for(var key in lights)
+		{
+			if($('#orb_'+key).val() !== "disabled")
+			{
+				// Set Name to layout-position, if empty
+				if ( lights[key].name === "" )
+				{
+					lights[key].name = $.i18n( 'conf_leds_layout_cl_'+$('#orb_'+key).val() );
+				}
+
+				finalLights.push( lights[key].id);
+
+				var name = lights[key].id;
+				if ( lights[key].host !== "")
+					name += ':' + lights[key].host;
+
+				var idx_content = assignLightPos(key, $('#orb_'+key).val(), name);
+				atmoorbLedConfig.push(JSON.parse(JSON.stringify(idx_content)));
+			}
+		}
+
+		//LED layout
+		window.serverConfig.leds = atmoorbLedConfig;
+
+		//LED device config
+		//Start with a clean configuration
+		var d = {};
+
+		d.type = 'atmoorb';
+		d.hardwareLedCount = finalLights.length;
+		d.colorOrder = conf_editor.getEditor("root.generalOptions.colorOrder").getValue();
+
+		d.orbIds = finalLights.toString();
+		d.useOrbSmoothing  = (eV("useOrbSmoothing") == true);
+
+		d.output = conf_editor.getEditor("root.specificOptions.output").getValue();
+		d.port = parseInt(conf_editor.getEditor("root.specificOptions.port").getValue());
+		d.latchTime = parseInt(conf_editor.getEditor("root.specificOptions.latchTime").getValue());;
+
+		window.serverConfig.device = d;
+
+		requestWriteConfig(window.serverConfig, true);
+		resetWizard();
+	});
+
+	$('#btn_wiz_abort').off().on('click', resetWizard);
+}
+
+function getIdInLights(id) {
+	return lights.filter(
+				function(lights) {
+					return lights.id === id
+				}
+				);
+}
+
+async function discover_atmoorb_lights(multiCastGroup, multiCastPort){
+
+  var light = {};
+
+  if ( multiCastGroup === "" )
+  	multiCastGroup = "239.255.255.250";
+
+  if ( multiCastPort === "")
+    multiCastPort = 49692;
+
+  let params = { multiCastGroup : multiCastGroup, multiCastPort : multiCastPort};
+
+  // Get discovered lights
+  const res = await requestLedDeviceDiscovery ('atmoorb', params);
+
+  // TODO: error case unhandled
+  // res can be: false (timeout) or res.error (not found)
+  if(res && !res.error){
+    const r = res.info
+
+	// Process devices returned by discovery
+	for(const device of r.devices)
+	{
+	    if( device.id !== "")
+	    {
+		    if ( getIdInLights ( device.id ).length === 0 )
+		    {
+		      light = {};
+		      light.id = device.id;
+		      light.ip = device.ip;
+		      light.host = device.hostname;
+		      lights.push(light);
+		    }
+	    }
+	}
+
+    // Add additional items from configuration
+    for(const keyConfig in configuredLights)
+    {
+      if ( configuredLights[keyConfig] !== "" && !isNaN(configuredLights[keyConfig]) ) 
+      {
+		  if ( getIdInLights ( configuredLights[keyConfig] ).length === 0 )
+		  {
+		  	light = {};
+			light.id = configuredLights[keyConfig];
+		    light.ip = "";
+		    light.host = "";	    
+		    lights.push(light);
+		  }
+	  }
+    }
+
+	lights.sort((a, b) => (a.id > b.id) ? 1 : -1);
+
+    assign_atmoorb_lights();
+  }
+}
+
+function assign_atmoorb_lights(){
+
+	// If records are left for configuration
+	if(Object.keys(lights).length > 0)
+	{
+		$('#wh_topcontainer').toggle(false);
+		$('#orb_ids_t, #btn_wiz_save').toggle(true);
+
+		var lightOptions = [
+					"top", "topleft", "topright",
+					"bottom", "bottomleft", "bottomright",
+					"left", "lefttop", "leftmiddle", "leftbottom",
+					"right", "righttop", "rightmiddle", "rightbottom",
+					"entire"
+				];
+
+		lightOptions.unshift("disabled");
+
+		$('.lidsb').html("");
+		var pos = "";
+
+		for(var lightid in lights)
+		{
+			var orbId = lights[lightid].id;
+			var orbIp = lights[lightid].ip;
+			var orbHostname = lights[lightid].host;
+
+			if ( orbHostname === "" )
+				orbHostname = $.i18n('edt_dev_spec_lights_itemtitle');
+
+			var options = "";
+			for(var opt in lightOptions)
+			{
+				var val = lightOptions[opt];
+				var txt = (val !== 'entire' && val !== 'disabled') ? 'conf_leds_layout_cl_' : 'wiz_ids_';
+				options+= '<option value="'+val+'"';
+				if(pos === val) options+=' selected="selected"';
+				options+= '>'+$.i18n(txt+val)+'</option>';
+			}
+
+			var enabled = 'enabled'
+			if ( orbId < 1 || orbId > 255 )
+			{
+				enabled = 'disabled'
+				options = '<option value=disabled>'+$.i18n('wiz_atmoorb_unsupported')+'</option>';
+			}
+
+			var lightAnnotation ="";
+			if ( orbIp !== "" )
+			{
+		      lightAnnotation = ': '+orbIp+'<br>('+orbHostname+')';
+			}
+
+			$('.lidsb').append(createTableRow([orbId + lightAnnotation, '<select id="orb_'+lightid+'" '+enabled+' class="orb_sel_watch form-control">'
+											   + options
+											   + '</select>','<button class="btn btn-sm btn-primary" ' +enabled+ ' onClick=identify_atmoorb_device('+orbId+')>'
+											   + $.i18n('wiz_identify_light',orbId)+'</button>']));
+		}
+
+		$('.orb_sel_watch').bind("change", function(){
+			var cC = 0;
+			for(var key in lights)
+			{
+				if($('#orb_'+key).val() !== "disabled")
+				{
+					cC++;
+				}
+			}
+			if ( cC === 0)
+				$('#btn_wiz_save').attr("disabled",true);
+			else
+				$('#btn_wiz_save').attr("disabled",false);
+		});
+		$('.orb_sel_watch').trigger('change');
+	}
+	else
+	{
+		var noLightsTxt = '<p style="font-weight:bold;color:red;">'+$.i18n('wiz_atmoorb_noLights')+'</p>';
+		$('#wizp2_body').append(noLightsTxt);
+	}
+}
+
+function identify_atmoorb_device(orbId){
+
+	let params = { id : orbId };
+
+	const res = requestLedDeviceIdentification ("atmoorb", params);
+	// TODO: error case unhandled
+  	// res can be: false (timeout) or res.error (not found)
+	if(res && !res.error){
+		const r = res.info
+	}
+}
+
 //****************************
 // Wizard/Routines Nanoleaf
 //****************************