Media Foundation/V4L2 grabber ... (#1119)

* - New Media Foundation grabber
- JsonAPI available grabber fix
- commented json config removed

* Added libjpeg-turbo to dependencies

* Fix OSX build
Removed Azure Pipelines from build scripts

* Remove Platform from Dashboard

* Correct Grabber Namings

* Grabber UI improvements, generic JSONEditor Selection Update

* Active grabber fix

* Stop Framebuffer grabber on failure

* - Image format NV12 and I420 added
- Flip mode
- Scaling factor for MJPEG
- VSCode (compile before run)
- CI (push) dependency libjpeg-turbo added

* Refactor MediaFoundation (Part 1)

* Remove QDebug output

* Added image flipping ability to MF Grabber

* fix issue 1160

* -Reload MF Grabber only once per WebUI update
- Cleanup

* Improvements

* - Set 'Software Frame Decimation' begin to 0
- Removed grabber specific device name from Log
- Keep pixel format when switching resolution
- Display 'Flip mode' correct in Log
- BGR24 images always flipped

* Refactor MediaFoundation (Part 2)

* Refactor V4L2 grabber (part 1) (#62)

* Media Foundation grabber adapted to V4L2 change

* Enable Media Foundation grabber on windows

* Have fps as int, fix height typo

* Added video standards to JsonAPI output

* Error handling in source reader improved

* Fix "Frame to small" error

* Discovery VideoSources and Dynamically Update Editor

* Hide all element when no video grabber discovered, upate naming

* Do not show unsupported grabbers

* Copy Log to Clipboard

* Update Grabber schema and Defaults

* Update access levels and validate crop ranges

* Height and width in Qt grabber corrected

* Correct formatting

* Untabify

* Global component states across instances

* Components divided on the dashboard

* refactor

* Fix Merge-issues

* Database migration aligning with updated grabber model

* Align Grabber.js with new utility functions

* Allow editor-validation for enum-lists

* Handle "Show Explainations scenario" correctly

* Grabber - Ensure save is only possible on valid content

* Dashboard update + fix GlobalSignal connection

* Ensure default database is populated with current release

* Correct grabber4L2 access level

* Display Signal detection area in preview

* Write Hyperion version into default config on compiling.

* Create defaultconfig.json dynamically

* WebUI changes

* Correct grabber config look-ups

* Refactor i18n language loading

* Fix en.json

* Split global capture from instance capture config

* Update grabber default values

* Standalone grabber: Add --debug switch

* Enhance showInputOptionsForKey for multiple keys

* Add grabber instance link to system grabber config

* Only show signal detection area, if grabber is enabled

* Always show Active element on grabber page

* Remote control - Only display gabber status, if global grabber is enabled

* WebUI optimization (thx to @mkcologne)
Start Grabber only when global settings are enabled
Fixed an issue in the WebUI preview

* V4L2/MF changes

* Jsoneditor, Correct translation for default values

* Refactor LED-Device handling in UI and make element naming consistent

* MF Discovery extended

* Fix LGTM finding

* Support Grabber Bri, Hue, Sat and Con in UI, plus their defaults

* Concider Access level for item filtering

* Concider Access level for item filtering

* Revert "Concider Access level for item filtering"

This reverts commit 5b0ce3c0f2.

* Disable fpsSoftwareDecimation for framegrabber, as not supported yet

* JSON-Editor- Add updated schema for validation on dynamic elements

* added V4L2 color IDs

* LGTM findings fix

* destroy SR callback only on exit

* Grabber.js - Hide elements not supported by platform

* Fixed freezing start effect

* Grabber UI - Hardware controls - Show current values and allow to reset to defaults

* Grabber - Discovery - Add current values to properties

* Small things

* Clean-up Effects and have ENDLESS consistently defined

* Fix on/off/on priority during startup, by initializing _prevVisComp in line with background priority

* Add missing translation mappings

* DirectX Grabber reactivated/ QT Grabber size decimation fixed

* typo in push-master workflow

* Use PreciseTimer for Grabber to ensure stable FPS timing

* Set default Screencapture rate consistently

* Fix libjpeg-turbo download

* Remove Zero character from file

* docker-compile Add PLATFORM parameter, only copy output file after successful compile

* Framebuffer, Dispmanx, OSX, AML Grabber discovery, various clean-up and consistencies across grabbers

* Fix merge problem - on docker-compile Add PLATFORM parameter, only copy output file after successful compile

* Fix definition

* OSXFRameGrabber - Revert cast

* Clean-ups nach Feedback

* Disable certain libraries when building armlogic via standard stretch image as developer

* Add CEC availability to ServerInfo to have it platform independent

* Grabber UI - Fix problem that crop values are not populated when refining editor rage

* Preserve value when updating json-editor range

* LEDVisualisation - Clear image when source changes

* Fix - Preserve value when updating json-editor range

* LEDVisualisation - Clear image when no component is active

* Allow to have password handled by Password-Manager (#1263)

* Update default signal detection area to green assuming rainbow grabber

* LED Visualisation - Handle empty priority update

* Fix yuv420 in v4l2 grabber

* V4L2-Grabber discovery - Only report grabbers with valid video input information

* Grabber - Update static variables to have them working in release build

* LED Visualisation - ClearImage when no priorities

* LED Visualisation - Fix Logo resizing issue

* LED Visualisation - Have nearly black background and negative logo

Co-authored-by: LordGrey <lordgrey.emmel@gmail.com>
Co-authored-by: LordGrey <48840279+Lord-Grey@users.noreply.github.com>

libsrc/grabber/xcb/XcbCommandExecutor.h

@@ -22,7 +22,7 @@ void check_error(xcb_generic_error_t * error)
 // Requests with void response type
 template<class Request, class ...Args>
 	typename std::enable_if<std::is_same<typename Request::ResponseType, xcb_void_cookie_t>::value, void>::type
-		query(xcb_connection_t * connection, Args&& ...args)
+		static query(xcb_connection_t * connection, Args&& ...args)
 {
 	auto cookie = Request::RequestFunction(connection, std::forward<Args>(args)...);
 
@@ -33,9 +33,8 @@ template<class Request, class ...Args>
 
 // Requests with non-void response type
 template<class Request, class ...Args>
-	typename std::enable_if<!std::is_same<typename Request::ResponseType, xcb_void_cookie_t>::value,
-		std::unique_ptr<typename Request::ResponseType, decltype(&free)>>::type
-			query(xcb_connection_t * connection, Args&& ...args)
+	typename std::enable_if<!std::is_same<typename Request::ResponseType, xcb_void_cookie_t>::value, std::unique_ptr<typename Request::ResponseType, decltype(&free)>>::type
+		static query(xcb_connection_t * connection, Args&& ...args)
 {
 	auto cookie = Request::RequestFunction(connection, std::forward<Args>(args)...);
 

libsrc/grabber/xcb/XcbCommands.h

@@ -21,6 +21,14 @@ struct GetGeometry
 	static constexpr auto ReplyFunction = xcb_get_geometry_reply;
 };
 
+struct GetProperty
+{
+	typedef xcb_get_property_reply_t  ResponseType;
+
+	static constexpr auto RequestFunction = xcb_get_property;
+	static constexpr auto ReplyFunction = xcb_get_property_reply;
+};
+
 struct ShmQueryVersion
 {
 	typedef xcb_shm_query_version_reply_t ResponseType;

libsrc/grabber/xcb/XcbGrabber.cpp

@@ -14,10 +14,15 @@
 
 #include <memory>
 
+// Constants
+namespace {
+	const bool verbose = false;
+} //End of constants
+
 #define DOUBLE_TO_FIXED(d) ((xcb_render_fixed_t) ((d) * 65536))
 
-XcbGrabber::XcbGrabber(int cropLeft, int cropRight, int cropTop, int cropBottom, int pixelDecimation)
-	: Grabber("XCBGRABBER", 0, 0, cropLeft, cropRight, cropTop, cropBottom)
+XcbGrabber::XcbGrabber(int cropLeft, int cropRight, int cropTop, int cropBottom)
+	: Grabber("XCBGRABBER", cropLeft, cropRight, cropTop, cropBottom)
 	, _connection{}
 	, _screen{}
 	, _pixmap{}
@@ -27,7 +32,6 @@ XcbGrabber::XcbGrabber(int cropLeft, int cropRight, int cropTop, int cropBottom,
 	, _dstPicture{}
 	, _transform{}
 	, _shminfo{}
-	, _pixelDecimation(pixelDecimation)
 	, _screenWidth{}
 	, _screenHeight{}
 	, _src_x(cropLeft)
@@ -36,6 +40,7 @@ XcbGrabber::XcbGrabber(int cropLeft, int cropRight, int cropTop, int cropBottom,
 	, _XcbRandRAvailable{}
 	, _XcbShmAvailable{}
 	, _XcbShmPixmapAvailable{}
+	, _isWayland (false)
 	, _logger{}
 	, _shmData{}
 	, _XcbRandREventBase{-1}
@@ -181,54 +186,83 @@ void XcbGrabber::setupShm()
 	}
 }
 
-bool XcbGrabber::Setup()
+bool XcbGrabber::open()
 {
-	int screen_num;
-	_connection = xcb_connect(nullptr, &screen_num);
+	bool rc = false;
 
-	int ret = xcb_connection_has_error(_connection);
-	if (ret != 0)
+	if (getenv("WAYLAND_DISPLAY") != nullptr)
 	{
-		Error(_logger, "Cannot open display, error %d", ret);
-		return false;
+		_isWayland = true;
 	}
-
-	const xcb_setup_t * setup = xcb_get_setup(_connection);
-	_screen = getScreen(setup, screen_num);
-
-	if (!_screen)
+	else
 	{
-		Error(_log, "Unable to open display, screen %d does not exist", screen_num);
+		_connection = xcb_connect(nullptr, &_screen_num);
 
-		if (getenv("DISPLAY"))
-			Error(_log, "%s", getenv("DISPLAY"));
+		int ret = xcb_connection_has_error(_connection);
+		if (ret != 0)
+		{
+			Debug(_logger, "Cannot open display, error %d", ret);
+		}
 		else
-			Error(_log, "DISPLAY environment variable not set");
-
-		freeResources();
-		return false;
+		{
+			const xcb_setup_t * setup = xcb_get_setup(_connection);
+			_screen = getScreen(setup, _screen_num);
+			if ( _screen != nullptr)
+			{
+				rc = true;
+			}
+		}
 	}
 
-	setupRandr();
-	setupRender();
-	setupShm();
+	return rc;
+}
 
-	Info(_log, QString("XcbRandR=[%1] XcbRender=[%2] XcbShm=[%3] XcbPixmap=[%4]")
-		.arg(_XcbRandRAvailable     ? "available" : "unavailable")
-		.arg(_XcbRenderAvailable    ? "available" : "unavailable")
-		.arg(_XcbShmAvailable       ? "available" : "unavailable")
-		.arg(_XcbShmPixmapAvailable ? "available" : "unavailable")
-		.toStdString().c_str());
+bool XcbGrabber::setupDisplay()
+{
+	bool result = false;
 
-	bool result = (updateScreenDimensions(true) >= 0);
-	ErrorIf(!result, _log, "XCB Grabber start failed");
-	setEnabled(result);
+	if ( ! open() )
+	{
+		if ( _isWayland  )
+		{
+			Error(_log, "Grabber does not work under Wayland!");
+		}
+		else
+		{
+			if (getenv("DISPLAY") != nullptr)
+			{
+				Error(_log, "Unable to open display [%s], screen %d does not exist", getenv("DISPLAY"), _screen_num);
+			}
+			else
+			{
+				Error(_log, "DISPLAY environment variable not set");
+			}
+			freeResources();
+		}
+	}
+	else
+	{
+		setupRandr();
+		setupRender();
+		setupShm();
+
+		Info(_log, QString("XcbRandR=[%1] XcbRender=[%2] XcbShm=[%3] XcbPixmap=[%4]")
+			 .arg(_XcbRandRAvailable     ? "available" : "unavailable")
+			 .arg(_XcbRenderAvailable    ? "available" : "unavailable")
+			 .arg(_XcbShmAvailable       ? "available" : "unavailable")
+			 .arg(_XcbShmPixmapAvailable ? "available" : "unavailable")
+			 .toStdString().c_str());
+
+		result = (updateScreenDimensions(true) >= 0);
+		ErrorIf(!result, _log, "XCB Grabber start failed");
+		setEnabled(result);
+	}
 	return result;
 }
 
 int XcbGrabber::grabFrame(Image<ColorRgb> & image, bool forceUpdate)
 {
-	if (!_enabled)
+	if (!_isEnabled)
 		return 0;
 
 	if (forceUpdate)
@@ -316,7 +350,7 @@ int XcbGrabber::updateScreenDimensions(bool force)
 		return -1;
 	}
 
-	if (!_enabled)
+	if (!_isEnabled)
 		setEnabled(true);
 
 	if (!force && _screenWidth == unsigned(geometry->width) &&
@@ -391,19 +425,29 @@ int XcbGrabber::updateScreenDimensions(bool force)
 void XcbGrabber::setVideoMode(VideoMode mode)
 {
 	Grabber::setVideoMode(mode);
-	updateScreenDimensions(true);
-}
-
-void XcbGrabber::setPixelDecimation(int pixelDecimation)
-{
-	if(_pixelDecimation != pixelDecimation)
+	if(_connection != nullptr)
 	{
-		_pixelDecimation = pixelDecimation;
 		updateScreenDimensions(true);
 	}
 }
 
-void XcbGrabber::setCropping(unsigned cropLeft, unsigned cropRight, unsigned cropTop, unsigned cropBottom)
+bool XcbGrabber::setPixelDecimation(int pixelDecimation)
+{
+	bool rc (true);
+	if (Grabber::setPixelDecimation(pixelDecimation))
+	{
+		if(_connection != nullptr)
+		{
+			if ( updateScreenDimensions(true) < 0 )
+			{
+				rc = false;
+			}
+		}
+	}
+	return rc;
+}
+
+void XcbGrabber::setCropping(int cropLeft, int cropRight, int cropTop, int cropBottom)
 {
 	Grabber::setCropping(cropLeft, cropRight, cropTop, cropBottom);
 	if(_connection != nullptr)
@@ -459,3 +503,89 @@ xcb_render_pictformat_t XcbGrabber::findFormatForVisual(xcb_visualid_t visual) c
 	}
 	return {};
 }
+
+QJsonObject XcbGrabber::discover(const QJsonObject& params)
+{
+	DebugIf(verbose, _log, "params: [%s]", QString(QJsonDocument(params).toJson(QJsonDocument::Compact)).toUtf8().constData());
+
+	QJsonObject inputsDiscovered;
+	if ( open() )
+	{
+		inputsDiscovered["device"] = "xcb";
+		inputsDiscovered["device_name"] = "XCB";
+		inputsDiscovered["type"] = "screen";
+
+		QJsonArray video_inputs;
+
+		if (_connection != nullptr && _screen != nullptr )
+		{
+			QJsonArray fps = { 1, 5, 10, 15, 20, 25, 30, 40, 50, 60 };
+
+			const xcb_setup_t * setup = xcb_get_setup(_connection);
+
+			xcb_screen_iterator_t it = xcb_setup_roots_iterator(setup);
+			xcb_screen_t * screen  = nullptr;
+
+			int i = 0;
+			// Iterate through all X screens
+			for (; it.rem > 0; xcb_screen_next(&it))
+			{
+				screen = it.data;
+
+				auto geometry = query<GetGeometry>(_connection, screen->root);
+				if (geometry == nullptr)
+				{
+					Debug(_log, "Failed to obtain screen geometry for screen [%d]", i);
+				}
+				else
+				{
+					QJsonObject in;
+
+					QString displayName;
+					auto property = query<GetProperty>(_connection, 0, screen->root, XCB_ATOM_WM_NAME, XCB_ATOM_STRING, 0, 0);
+					if ( property != nullptr )
+					{
+						if ( xcb_get_property_value_length(property.get()) > 0 )
+						{
+							displayName = (char *) xcb_get_property_value(property.get());
+						}
+					}
+
+					if (displayName.isEmpty())
+					{
+						displayName = QString("Display:%1").arg(i);
+					}
+
+					in["name"] = displayName;
+					in["inputIdx"] = i;
+
+					QJsonArray formats;
+					QJsonArray resolutionArray;
+					QJsonObject format;
+					QJsonObject resolution;
+
+					resolution["width"] = geometry->width;
+					resolution["height"] = geometry->height;
+					resolution["fps"] = fps;
+
+					resolutionArray.append(resolution);
+
+					format["resolutions"] = resolutionArray;
+					formats.append(format);
+
+					in["formats"] = formats;
+					video_inputs.append(in);
+				}
+				++i;
+			}
+
+			if ( !video_inputs.isEmpty() )
+			{
+				inputsDiscovered["video_inputs"] = video_inputs;
+			}
+		}
+	}
+	DebugIf(verbose, _log, "device: [%s]", QString(QJsonDocument(inputsDiscovered).toJson(QJsonDocument::Compact)).toUtf8().constData());
+
+	return inputsDiscovered;
+}

libsrc/grabber/xcb/XcbWrapper.cpp

@@ -1,10 +1,14 @@
 #include <grabber/XcbWrapper.h>
 
-XcbWrapper::XcbWrapper(int cropLeft, int cropRight, int cropTop, int cropBottom, int pixelDecimation, const unsigned updateRate_Hz)
-	: GrabberWrapper("Xcb", &_grabber, 0, 0, updateRate_Hz)
-	, _grabber(cropLeft, cropRight, cropTop, cropBottom, pixelDecimation)
+XcbWrapper::XcbWrapper( int updateRate_Hz,
+						int pixelDecimation,
+						int cropLeft, int cropRight, int cropTop, int cropBottom)
+	: GrabberWrapper("Xcb", &_grabber, updateRate_Hz)
+	, _grabber(cropLeft, cropRight, cropTop, cropBottom)
 	, _init(false)
-{}
+{
+	_grabber.setPixelDecimation(pixelDecimation);
+}
 
 XcbWrapper::~XcbWrapper()
 {
@@ -19,7 +23,7 @@ void XcbWrapper::action()
 	if (! _init )
 	{
 		_init = true;
-		if ( ! _grabber.Setup() )
+		if ( ! _grabber.setupDisplay() )
 		{
 			stop();
 		}