From d05c699307359fe18518cd348f8839107c332c22 Mon Sep 17 00:00:00 2001
From: LordGrey <48840279+Lord-Grey@users.noreply.github.com>
Date: Wed, 15 Nov 2023 22:18:28 +0100
Subject: [PATCH] Fix CodeQL findings
---
include/events/EventHandler.h | 1 -
libsrc/events/EventHandler.cpp | 8 --------
libsrc/events/OsEventHandler.cpp | 4 ++--
3 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/include/events/EventHandler.h b/include/events/EventHandler.h
index 794b08a7..49b8c8ab 100644
--- a/include/events/EventHandler.h
+++ b/include/events/EventHandler.h
@@ -19,7 +19,6 @@ public:
static EventHandler* getInstance();
public slots:
- virtual void handleSettingsUpdate(settings::type type, const QJsonDocument& config);
void suspend(bool sleep);
diff --git a/libsrc/events/EventHandler.cpp b/libsrc/events/EventHandler.cpp
index 5b4bf7ec..266ec26b 100644
--- a/libsrc/events/EventHandler.cpp
+++ b/libsrc/events/EventHandler.cpp
@@ -28,14 +28,6 @@ EventHandler* EventHandler::getInstance()
return &instance;
}
-void EventHandler::handleSettingsUpdate(settings::type type, const QJsonDocument& config)
-{
- if(type == settings::OSEVENTS)
- {
- const QJsonObject& obj = config.object();
- }
-}
-
void EventHandler::suspend()
{
suspend(true);
diff --git a/libsrc/events/OsEventHandler.cpp b/libsrc/events/OsEventHandler.cpp
index c7ea0564..f339ac40 100644
--- a/libsrc/events/OsEventHandler.cpp
+++ b/libsrc/events/OsEventHandler.cpp
@@ -35,8 +35,8 @@ OsEventHandlerBase::~OsEventHandlerBase()
{
QObject::disconnect(this, &OsEventHandlerBase::signalEvent, EventHandler::getInstance(), &EventHandler::handleEvent);
- unregisterLockHandler();
- unregisterOsEventHandler();
+ OsEventHandlerBase::unregisterLockHandler();
+ OsEventHandlerBase::unregisterOsEventHandler();
}
void OsEventHandlerBase::handleSettingsUpdate(settings::type type, const QJsonDocument& config)