frodovdr/hyperion.ng
1
0
Fork 0
mirror of https://github.com/hyperion-project/hyperion.ng.git synced 2025-03-01 10:33:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Resolve some clang warnings (#915)

Browse Source
This commit is contained in:
Murat Seker
2020-08-02 22:35:09 +02:00
committed by GitHub
parent 031b9a6b7c
commit d183c630c8
18 changed files with 36 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libsrc/commandline/ColorsOption.cpp
View File

@@ -22,7 +22,7 @@ bool ColorsOption::validate(Parser & parser, QString & value)
QRegularExpressionMatch match = hexRe.match(value);
if(match.hasMatch())
{
for(const QString m : match.capturedTexts())
for(const QString & m : match.capturedTexts())
{
_colors.push_back(QColor(QString("#%1").arg(m)));
}

2
libsrc/hyperion/HyperionIManager.cpp
View File

@@ -41,7 +41,7 @@ const QVector<QVariantMap> HyperionIManager::getInstanceData()
void HyperionIManager::startAll()
{
for(const auto entry : _instanceTable->getAllInstances(true))
for(const auto & entry : _instanceTable->getAllInstances(true))
{
startInstance(entry["instance"].toInt());
}

10
libsrc/hyperion/SettingsManager.cpp
View File

@@ -41,7 +41,7 @@ SettingsManager::SettingsManager(const quint8& instance, QObject* parent)
// transform json to string lists
QStringList keyList = defaultConfig.keys();
QStringList defValueList;
for(const auto key : keyList)
for(const auto & key : keyList)
{
if(defaultConfig[key].isObject())
{
@@ -54,7 +54,7 @@ SettingsManager::SettingsManager(const quint8& instance, QObject* parent)
}
// fill database with default data if required
for(const auto key : keyList)
for(const auto & key : keyList)
{
QString val = defValueList.takeFirst();
// prevent overwrite
@@ -65,7 +65,7 @@ SettingsManager::SettingsManager(const quint8& instance, QObject* parent)
// need to validate all data in database constuct the entire data object
// TODO refactor schemaChecker to accept QJsonArray in validate(); QJsonDocument container? To validate them per entry...
QJsonObject dbConfig;
for(const auto key : keyList)
for(const auto & key : keyList)
{
QJsonDocument doc = _sTable->getSettingsRecord(key);
if(doc.isArray())
@@ -140,7 +140,7 @@ bool SettingsManager::saveSettings(QJsonObject config, const bool& correct)
// extract keys and data
QStringList keyList = config.keys();
QStringList newValueList;
for(const auto key : keyList)
for(const auto & key : keyList)
{
if(config[key].isObject())
{
@@ -153,7 +153,7 @@ bool SettingsManager::saveSettings(QJsonObject config, const bool& correct)
}
// compare database data with new data to emit/save changes accordingly
for(const auto key : keyList)
for(const auto & key : keyList)
{
QString data = newValueList.takeFirst();
if(_sTable->getSettingsRecordString(key) != data)