mirror of
https://github.com/hyperion-project/hyperion.ng.git
synced 2025-03-01 10:33:28 +00:00
Various Cleanups (#1075)
* LedDevice - Address clang findings * Fix Windows Warnings * Ensure newInput is initialised * Clean-up unused elements for Plaform Capture * Fix initialization problem and spellings * Address clang findings and spelling corrections * LedDevice clean-ups * Cleanups * Align that getLedCount is int * Have "display" as default for Grabbers * Fix config during start-up for missing elements * Framegrabber Clean-up - Remove non supported grabbers from selection, filter valid options * Typo * Framegrabber.json - Fix property numbering * Preselect active Grabbertype * Sort Grabbernames * Align options with selected element * Fix deletion of pointer to incomplete type 'BonjourBrowserWrapper' * Address macOS compile warnings * Have default layout = 1 LED only to avoid errors as in #673 * Address lgtm findings * Address finding that params passed to LedDevice discovery were not considered * Cleanups after merging with latest master * Update Changelog * Address lgtm findings * Fix comment * Test Fix * Fix Python Warning * Handle Dummy Device assignment correctly * Address delete called on non-final 'commandline::Option' that has virtual functions but non-virtual destructor * Correct that QTimer.start accepts only int * Have Release Python GIL & reset threat state chnage downward compatible * Correct format specifier * LedDevice - add assertions * Readonly DB - Fix merge issue * Smoothing - Fix wrong defaults * LedDevice - correct assertion * Show smoothing config set# in debug and related values. * Suppress error on windows, if default file is "/dev/null" * CMAKE - Allow to define QT_BASE_DIR dynamically via environment-variable * Ignore Visual Studio specific files Co-authored-by: Paulchen Panther <16664240+Paulchen-Panther@users.noreply.github.com>
This commit is contained in:
@@ -11,7 +11,7 @@ namespace hyperion
|
||||
///
|
||||
struct BlackBorder
|
||||
{
|
||||
/// Falg indicating if the border is unknown
|
||||
/// Flag indicating if the border is unknown
|
||||
bool unknown;
|
||||
|
||||
/// The size of the detected horizontal border
|
||||
@@ -48,7 +48,7 @@ namespace hyperion
|
||||
public:
|
||||
///
|
||||
/// Constructs a black-border detector
|
||||
/// @param[in] blackborderThreshold The threshold which the blackborder detector should use
|
||||
/// @param[in] threshold The threshold which the black-border detector should use
|
||||
///
|
||||
BlackBorderDetector(double threshold);
|
||||
|
||||
@@ -67,9 +67,9 @@ namespace hyperion
|
||||
template <typename Pixel_T>
|
||||
BlackBorder process(const Image<Pixel_T> & image) const
|
||||
{
|
||||
// test center and 33%, 66% of width/heigth
|
||||
// test centre and 33%, 66% of width/height
|
||||
// 33 and 66 will check left and top
|
||||
// center will check right and bottom sids
|
||||
// centre will check right and bottom sides
|
||||
int width = image.width();
|
||||
int height = image.height();
|
||||
int width33percent = width / 3;
|
||||
@@ -281,7 +281,7 @@ namespace hyperion
|
||||
private:
|
||||
|
||||
///
|
||||
/// Checks if a given color is considered black and therefor could be part of the border.
|
||||
/// Checks if a given color is considered black and therefore could be part of the border.
|
||||
///
|
||||
/// @param[in] color The color to check
|
||||
///
|
||||
@@ -295,7 +295,7 @@ namespace hyperion
|
||||
}
|
||||
|
||||
private:
|
||||
/// Threshold for the blackborder detector [0 .. 255]
|
||||
/// Threshold for the black-border detector [0 .. 255]
|
||||
const uint8_t _blackborderThreshold;
|
||||
|
||||
};
|
||||
|
Reference in New Issue
Block a user