Various Cleanups (#1075)

* LedDevice - Address clang findings

* Fix Windows Warnings

* Ensure newInput is initialised

* Clean-up unused elements for Plaform Capture

* Fix initialization problem and spellings

* Address clang findings and spelling corrections

* LedDevice clean-ups

* Cleanups

* Align that getLedCount is int

* Have "display" as default for Grabbers

* Fix config during start-up for missing elements

* Framegrabber Clean-up - Remove non supported grabbers from selection, filter valid options

* Typo

* Framegrabber.json - Fix property numbering

* Preselect active Grabbertype

* Sort Grabbernames

* Align options with selected element

* Fix deletion of pointer to incomplete type 'BonjourBrowserWrapper'

* Address macOS compile warnings

* Have default layout = 1 LED only to avoid errors as in #673

* Address lgtm findings

* Address finding that params passed to LedDevice discovery were not considered

* Cleanups after merging with latest master

* Update Changelog

* Address lgtm findings

* Fix comment

* Test Fix

* Fix Python Warning

* Handle Dummy Device assignment correctly

* Address delete called on non-final 'commandline::Option' that has virtual functions but non-virtual destructor

* Correct that QTimer.start accepts only int

* Have Release Python GIL & reset threat state chnage downward compatible

* Correct format specifier

* LedDevice - add assertions

* Readonly DB - Fix merge issue

* Smoothing - Fix wrong defaults

* LedDevice - correct assertion

* Show smoothing config set# in debug and related values.

* Suppress error on windows, if default file is "/dev/null"

* CMAKE - Allow to define QT_BASE_DIR dynamically via environment-variable

* Ignore Visual Studio specific files

Co-authored-by: Paulchen Panther <16664240+Paulchen-Panther@users.noreply.github.com>

include/leddevice/LedDevice.h

@@ -62,7 +62,7 @@ public:
 	///
 	/// @param[in] ledCount Number of device LEDs,  0 = unknown number
 	///
-	void setLedCount(unsigned int ledCount);
+	void setLedCount(int ledCount);
 
 	///
 	/// @brief Set a device's latch time.
@@ -87,9 +87,11 @@ public:
 	/// @brief Discover devices of this type available (for configuration).
 	/// @note Mainly used for network devices. Allows to find devices, e.g. via ssdp, mDNS or cloud ways.
 	///
+	/// @param[in] params Parameters used to overwrite discovery default behaviour
+	///
 	/// @return A JSON structure holding a list of devices found
 	///
-	virtual QJsonObject discover();
+	virtual QJsonObject discover(const QJsonObject& params);
 
 	///
 	/// @brief Discover first device of this type available (for configuration).
@@ -116,7 +118,7 @@ public:
 	///
 	/// @param[in] params Parameters to address device
 	///
-	virtual void identify(const QJsonObject& params) {}
+	virtual void identify(const QJsonObject& /*params*/) {}
 
 	///
 	/// @brief Check, if device is properly initialised
@@ -193,7 +195,7 @@ public slots:
 	///
 	/// @return Number of device's LEDs, 0 = unknown number
 	///
-	unsigned int getLedCount() const { return _ledCount; }
+	int getLedCount() const { return _ledCount; }
 
 	///
 	/// @brief Get the current active LED-device type.
@@ -348,7 +350,7 @@ protected:
 	/// @param size of the array
 	/// @param number Number of array items to be converted.
 	/// @return array as string of hex values
-	QString uint8_t_to_hex_string(const uint8_t * data, const qint64 size, qint64 number = -1) const;
+	QString uint8_t_to_hex_string(const uint8_t * data, const int size, int number = -1) const;
 
 	///
 	/// @brief Converts a ByteArray to hex string.