Various Cleanups (#1075)

* LedDevice - Address clang findings

* Fix Windows Warnings

* Ensure newInput is initialised

* Clean-up unused elements for Plaform Capture

* Fix initialization problem and spellings

* Address clang findings and spelling corrections

* LedDevice clean-ups

* Cleanups

* Align that getLedCount is int

* Have "display" as default for Grabbers

* Fix config during start-up for missing elements

* Framegrabber Clean-up - Remove non supported grabbers from selection, filter valid options

* Typo

* Framegrabber.json - Fix property numbering

* Preselect active Grabbertype

* Sort Grabbernames

* Align options with selected element

* Fix deletion of pointer to incomplete type 'BonjourBrowserWrapper'

* Address macOS compile warnings

* Have default layout = 1 LED only to avoid errors as in #673

* Address lgtm findings

* Address finding that params passed to LedDevice discovery were not considered

* Cleanups after merging with latest master

* Update Changelog

* Address lgtm findings

* Fix comment

* Test Fix

* Fix Python Warning

* Handle Dummy Device assignment correctly

* Address delete called on non-final 'commandline::Option' that has virtual functions but non-virtual destructor

* Correct that QTimer.start accepts only int

* Have Release Python GIL & reset threat state chnage downward compatible

* Correct format specifier

* LedDevice - add assertions

* Readonly DB - Fix merge issue

* Smoothing - Fix wrong defaults

* LedDevice - correct assertion

* Show smoothing config set# in debug and related values.

* Suppress error on windows, if default file is "/dev/null"

* CMAKE - Allow to define QT_BASE_DIR dynamically via environment-variable

* Ignore Visual Studio specific files

Co-authored-by: Paulchen Panther <16664240+Paulchen-Panther@users.noreply.github.com>

libsrc/leddevice/dev_net/LedDeviceCololight.h

@@ -29,6 +29,68 @@ enum effect : uint32_t {
 	CHRISTMAS = 0x068b0900
 };
 
+enum verbs {
+	GET = 0x03,
+	SET = 0x04,
+	SETEEPROM = 0x07,
+	SETVAR = 0x0b
+};
+
+enum commandTypes {
+	STATE_OFF = 0x80,
+	STATE_ON = 0x81,
+	BRIGTHNESS = 0xCF,
+	SETCOLOR = 0xFF
+};
+
+enum idxTypes {
+	BRIGTHNESS_CONTROL = 0x01,
+	COLOR_CONTROL = 0x02,
+	COLOR_DIRECT_CONTROL = 0x81,
+	READ_INFO_FROM_STORAGE = 0x86
+};
+
+	enum bufferMode {
+		MONOCROME = 0x01,
+		LIGHTBEAD = 0x02,
+		};
+
+enum ledLayout {
+	STRIP_LAYOUT,
+	MODLUE_LAYOUT
+};
+
+enum modelType {
+	STRIP,
+	PLUS
+};
+
+const uint8_t PACKET_HEADER[] =
+	{
+		'S', 'Z',   // Tag "SZ"
+		0x30, 0x30, // Version "00"
+		0x00, 0x00, // AppID, 0x0000 = TL1 command mode
+		0x00, 0x00, 0x00, 0x00 // Size
+};
+
+const uint8_t PACKET_SECU[] =
+	{
+		0x00, 0x00, 0x00, 0x00, // Dict
+		0x00, 0x00, 0x00, 0x00, // Sum
+		0x00, 0x00, 0x00, 0x00, // Salt
+		0x00, 0x00, 0x00, 0x00 // SN
+};
+
+const uint8_t TL1_CMD_FIXED_PART[] =
+	{
+		0x00, 0x00, 0x00, 0x00, // DISTID
+		0x00, 0x00, 0x00, 0x00, // SRCID
+		0x00, // SECU
+		0x00, // VERB
+		0x00, // CTAG
+		0x00 // LENGTH
+};
+
 ///
 /// Implementation of a Cololight LedDevice
 ///
@@ -54,9 +116,11 @@ public:
 	///
 	/// @brief Discover Cololight devices available (for configuration).
 	///
+	/// @param[in] params Parameters used to overwrite discovery default behaviour
+	///
 	/// @return A JSON structure holding a list of devices found
 	///
-	QJsonObject discover() override;
+	QJsonObject discover(const QJsonObject& params) override;
 
 	///
 	/// @brief Get a Cololight device's resource properties