From 36e66dff31d2cf37f8fb3356e68dab1b0537bdd4 Mon Sep 17 00:00:00 2001 From: Dave Conway-Jones Date: Fri, 26 Dec 2025 18:16:37 +0000 Subject: [PATCH] Fix markdown node tests --- parsers/markdown/70-markdown.js | 3 +-- parsers/markdown/package.json | 4 +-- test/parsers/markdown/70-markdown_spec.js | 30 +++++++++-------------- 3 files changed, 15 insertions(+), 22 deletions(-) diff --git a/parsers/markdown/70-markdown.js b/parsers/markdown/70-markdown.js index 6dcaf973..14414a47 100644 --- a/parsers/markdown/70-markdown.js +++ b/parsers/markdown/70-markdown.js @@ -11,12 +11,11 @@ module.exports = function(RED) { node.on("input", function(msg) { var value = RED.util.getMessageProperty(msg, node.property); - if (value !== undefined && typeof value === "string") { RED.util.setMessageProperty(msg, node.property, md.render(value)); node.send(msg); } else { - node.warn("No property value found"); + node.warn("No property value of type string found"); } }); } diff --git a/parsers/markdown/package.json b/parsers/markdown/package.json index 8feb7a9e..88774e48 100644 --- a/parsers/markdown/package.json +++ b/parsers/markdown/package.json @@ -1,6 +1,6 @@ { "name": "node-red-node-markdown", - "version": "0.6.0", + "version": "0.6.1", "description": "A Node-RED node to convert a markdown string to html.", "dependencies": { "markdown-it": "^14.1.0" @@ -23,7 +23,7 @@ }, "author": { "name": "Dave Conway-Jones", - "email": "ceejay@vnet.ibm.com", + "email": "dceejay@gmail.com", "url": "http://nodered.org" }, "engines": { diff --git a/test/parsers/markdown/70-markdown_spec.js b/test/parsers/markdown/70-markdown_spec.js index 9da82a53..ebaf4ebe 100644 --- a/test/parsers/markdown/70-markdown_spec.js +++ b/test/parsers/markdown/70-markdown_spec.js @@ -48,11 +48,9 @@ describe('markdown node', function() { {id:"n2", type:"helper"} ]; helper.load(testNode, flow, function() { var n1 = helper.getNode("n1"); - var n2 = helper.getNode("n2"); - n2.on("input", function(msg) { - msg.should.have.a.property("payload"); - msg.payload.should.be.a.Object; - msg.payload.a.should.equal("object"); + + n1.on('call:warn', call => { + call.lastArg.should.have.startWith("No property value of type string"); done(); }); n1.emit("input", {payload:{a:"object"}}); @@ -65,10 +63,9 @@ describe('markdown node', function() { helper.load(testNode, flow, function() { var n1 = helper.getNode("n1"); var n2 = helper.getNode("n2"); - n2.on("input", function(msg) { - msg.should.have.a.property("payload"); - msg.payload.should.be.a.number; - msg.payload.should.equal(1); + + n1.on('call:warn', call => { + call.lastArg.should.have.startWith("No property value of type string"); done(); }); n1.emit("input", {payload:1}); @@ -80,11 +77,9 @@ describe('markdown node', function() { {id:"n2", type:"helper"} ]; helper.load(testNode, flow, function() { var n1 = helper.getNode("n1"); - var n2 = helper.getNode("n2"); - n2.on("input", function(msg) { - msg.should.have.a.property("payload"); - msg.payload.should.be.a.boolean; - msg.payload.should.equal(true); + + n1.on('call:warn', call => { + call.lastArg.should.have.startWith("No property value of type string"); done(); }); n1.emit("input", {payload:true}); @@ -96,10 +91,9 @@ describe('markdown node', function() { {id:"n2", type:"helper"} ]; helper.load(testNode, flow, function() { var n1 = helper.getNode("n1"); - var n2 = helper.getNode("n2"); - n2.on("input", function(msg) { - msg.should.have.a.property("payload"); - msg.payload.should.be.an.object; + + n1.on('call:warn', call => { + call.lastArg.should.have.startWith("No property value of type string"); done(); }); n1.emit("input", {payload:[1,2,"a","b"]});