frodovdr/node-red-nodes
1
0
Fork 0
mirror of https://github.com/node-red/node-red-nodes.git synced 2025-03-01 10:37:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add disconnect timeout of 2s to avoid "Error stopping node"

Browse Source
This commit is contained in:
Olivier Verhaegen 2023-04-17 11:13:39 +02:00 committed by GitHub
parent 6d517ceef0
commit 4cf1216845
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
io/stomp/18-stomp.js
View File

@ -231,6 +231,20 @@ module.exports = function(RED) {
* @param {Function} callback
*/
node.disconnect = function(callback) {
const waitDisconnect = (client, timeout) => {
return new Promise((resolve, reject) => {
// Set flag to avoid race conditions for disconnect as every node tries to call it directly or indirectly using deregister
node.closing = true;
const t = setTimeout(() => {
reject();
}, timeout);
client.disconnect(() => {
clearTimeout(t);
resolve();
});
});
}
if (!node.client) {
node.warn("Can't disconnect, connection not initialized.");
callback();
@ -238,10 +252,11 @@ module.exports = function(RED) {
// Disconnection already in progress
callback();
} else {
node.closing = true;
node.client.disconnect(function() {
waitDisconnect(node.client, 2000).then(() => {
node.log("Disconnected from STOMP server", {sessionId: node.sessionId, url: `${node.options.address}:${node.options.port}`, protocolVersion: node.options.protocolVersion})
}).catch(() => {
node.log("Disconnect timeout closing node...");
}).finally(() => {
node.sessionId = null;
node.subscribtionIndex = 1;
node.subscriptionIds = {};