frodovdr/node-red-nodes
1
0
Fork 0
mirror of https://github.com/node-red/node-red-nodes.git synced 2025-03-01 10:37:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add test for Pi4/5 to some of the Pi specific nodes in the hardware group (#1074)

Browse Source 
* Add test for Pi4/5

* Fix PR template

* Actually test
This commit is contained in:
Ben Hardill 2024-06-30 15:45:47 +01:00 committed by GitHub
parent 305327faaa
commit 61ee4bda4b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -11,7 +11,7 @@ Put an `x` in the boxes that apply
--> -->
- [ ] Bugfix (non-breaking change which fixes an issue) - [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality) - [ ] New feature (non-breaking change which adds functionality)
<!-- <!--
If you want to raise a pull-request with a new feature, or a refactoring If you want to raise a pull-request with a new feature, or a refactoring
@ -25,13 +25,10 @@ the [forum](https://discourse.nodered.org) or
<!-- Describe the nature of this change. What problem does it address? --> <!-- Describe the nature of this change. What problem does it address? -->
Adds authentication option to the Email node (node-red-node-email) to use OAuth and XOAuth2
********** This version: IMAP ONLY **********
## Checklist ## Checklist
<!-- Put an `x` in the boxes that apply --> <!-- Put an `x` in the boxes that apply -->
- [x] I have read the [contribution guidelines](https://github.com/node-red/node-red-nodes/blob/master/CONTRIBUTING.md) - [ ] I have read the [contribution guidelines](https://github.com/node-red/node-red-nodes/blob/master/CONTRIBUTING.md)
- [x] For non-bugfix PRs, I have discussed this change on the forum/slack team. - [ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
- [x] I have run `grunt` to verify the unit tests pass - [ ] I have run `grunt` to verify the unit tests pass
- [x] I have added suitable unit tests to cover the new/changed functionality - [ ] I have added suitable unit tests to cover the new/changed functionality

2
hardware/LEDborg/78-ledborg.js
View File

@ -12,7 +12,7 @@ module.exports = function(RED) {
try { try {
var cpuinfo = fs.readFileSync("/proc/cpuinfo").toString(); var cpuinfo = fs.readFileSync("/proc/cpuinfo").toString();
if (cpuinfo.indexOf(": BCM") === -1) { if (cpuinfo.indexOf(": BCM") === -1 && cpuinfo.indexOf(": Raspberry Pi") === -1) {
RED.log.warn("ledborg : "+RED._("node-red:rpi-gpio.errors.ignorenode")); RED.log.warn("ledborg : "+RED._("node-red:rpi-gpio.errors.ignorenode"));
allOK = false; allOK = false;
} }

2
hardware/PiLcd/pilcd.js
View File

@ -10,7 +10,7 @@ module.exports = function(RED) {
try { try {
var cpuinfo = fs.readFileSync("/proc/cpuinfo").toString(); var cpuinfo = fs.readFileSync("/proc/cpuinfo").toString();
if (cpuinfo.indexOf(": BCM") === -1) { if (cpuinfo.indexOf(": BCM") === -1 && cpuinfo.indexOf(": Raspberry Pi") === -1) {
RED.log.warn("rpi-lcd : "+RED._("pilcd.errors.ignorenode")); RED.log.warn("rpi-lcd : "+RED._("pilcd.errors.ignorenode"));
allOK = false; allOK = false;
} }

2
hardware/PiSrf/pisrf.js
View File

@ -10,7 +10,7 @@ module.exports = function(RED) {
try { try {
var cpuinfo = fs.readFileSync("/proc/cpuinfo").toString(); var cpuinfo = fs.readFileSync("/proc/cpuinfo").toString();
if (cpuinfo.indexOf(": BCM") === -1) { if (cpuinfo.indexOf(": BCM") === -1 && cpuinfo.indexOf(": Raspberry Pi") === -1) {
RED.log.warn("rpi-srf : "+RED._("node-red:rpi-gpio.errors.ignorenode")); RED.log.warn("rpi-srf : "+RED._("node-red:rpi-gpio.errors.ignorenode"));
allOK = false; allOK = false;
} }

2
hardware/mcp3008/pimcp3008.js
View File

@ -7,7 +7,7 @@ module.exports = function(RED) {
// unlikely if not on a Pi // unlikely if not on a Pi
try { try {
var cpuinfo = fs.readFileSync("/proc/cpuinfo").toString(); var cpuinfo = fs.readFileSync("/proc/cpuinfo").toString();
if (cpuinfo.indexOf(": BCM") === -1) { if (cpuinfo.indexOf(": BCM") === -1 && cpuinfo.indexOf(": Raspberry Pi") === -1) {
RED.log.warn("Info : mcp3xxx : Not running on a Pi - Ignoring node"); RED.log.warn("Info : mcp3xxx : Not running on a Pi - Ignoring node");
} }
else { else {

2
hardware/unicorn/unicorn.js
View File

@ -11,7 +11,7 @@ module.exports = function(RED) {
try { try {
var cpuinfo = fs.readFileSync("/proc/cpuinfo").toString(); var cpuinfo = fs.readFileSync("/proc/cpuinfo").toString();
if (cpuinfo.indexOf(": BCM") === -1) { if (cpuinfo.indexOf(": BCM") === -1 && cpuinfo.indexOf(": Raspberry Pi") === -1) {
RED.log.warn("rpi-unicorn : "+RED._("node-red:rpi-gpio.errors.ignorenode")); RED.log.warn("rpi-unicorn : "+RED._("node-red:rpi-gpio.errors.ignorenode"));
allOK = false; allOK = false;
} }