Fixup Base64 node and add better tests

Revert correct <-> behaviour, make encoding info clearer, added type
checking - to close #401 and close #437
This commit is contained in:
Dave Conway-Jones
2018-04-29 17:35:30 +01:00
parent 5019f68c9c
commit 6a28ecfbc2
4 changed files with 148 additions and 17 deletions

View File

@@ -61,6 +61,7 @@ describe('base64 node', function() {
var n2 = helper.getNode("n2");
n2.on("input", function(msg) {
msg.should.have.a.property("payload");
msg.payload.should.be.instanceof(Buffer);
msg.payload.toString().should.equal("ABCDEFGHIJKLMNOPQRSTUVWXYZ");
done();
});
@@ -76,6 +77,7 @@ describe('base64 node', function() {
var n2 = helper.getNode("n2");
n2.on("input", function(msg) {
msg.should.have.a.property("foo");
msg.foo.should.be.instanceof(Buffer);
msg.foo.toString().should.equal("ABCDEFGHIJKLMNOPQRSTUVWXYZ");
done();
});
@@ -162,4 +164,125 @@ describe('base64 node', function() {
});
});
it('can force encode string to base64', function(done) {
var flow = [{id:"n1", type:"base64", action:"str", wires:[["n2"]] },
{id:"n2", type:"helper"} ];
helper.load(testNode, flow, function() {
var n1 = helper.getNode("n1");
var n2 = helper.getNode("n2");
n2.on("input", function(msg) {
msg.should.have.a.property("payload","YW5keQ==");
done();
});
n1.emit("input", {payload:"andy"});
});
});
it('can force encode boolean to base64', function(done) {
var flow = [{id:"n1", type:"base64", action:"str", wires:[["n2"]] },
{id:"n2", type:"helper"} ];
helper.load(testNode, flow, function() {
var n1 = helper.getNode("n1");
var n2 = helper.getNode("n2");
n2.on("input", function(msg) {
msg.should.have.a.property("payload","dHJ1ZQ==");
done();
});
n1.emit("input", {payload:true});
});
});
it('can force encode number to base64', function(done) {
var flow = [{id:"n1", type:"base64", action:"str", wires:[["n2"]] },
{id:"n2", type:"helper"} ];
helper.load(testNode, flow, function() {
var n1 = helper.getNode("n1");
var n2 = helper.getNode("n2");
n2.on("input", function(msg) {
msg.should.have.a.property("payload","MTIzNA==");
done();
});
n1.emit("input", {payload:1234});
});
});
it('can force encode object to base64', function(done) {
var flow = [{id:"n1", type:"base64", action:"str", wires:[["n2"]] },
{id:"n2", type:"helper"} ];
helper.load(testNode, flow, function() {
var n1 = helper.getNode("n1");
var n2 = helper.getNode("n2");
n2.on("input", function(msg) {
msg.should.have.a.property("payload","eyJhIjoxfQ==");
done();
});
n1.emit("input", {payload:{a:1}});
});
});
it('can force decode base64 to string', function(done) {
var flow = [{id:"n1", type:"base64", action:"b64", wires:[["n2"]] },
{id:"n2", type:"helper"} ];
helper.load(testNode, flow, function() {
var n1 = helper.getNode("n1");
var n2 = helper.getNode("n2");
n2.on("input", function(msg) {
msg.payload.should.be.instanceof(String);
msg.should.have.a.property("payload","Hello World");
done();
});
n1.emit("input", {payload:"SGVsbG8gV29ybGQ="});
});
});
it('wont decode base64 to string if not a valid string', function(done) {
var flow = [{id:"n1", type:"base64", action:"b64", wires:[["n2"]] },
{id:"n2", type:"helper"} ];
helper.load(testNode, flow, function() {
var n1 = helper.getNode("n1");
var n2 = helper.getNode("n2");
n2.on("input", function(msg) {
done("should not get here with no payload.");
});
setTimeout(function () {
try {
var logEvents = helper.log().args.filter(function (evt) {
return evt[0].type == "base64";
});
logEvents[0][0].should.have.a.property('msg');
logEvents[0][0].msg.toString().should.startWith("Invalid Base64 string");
done();
} catch (e) {
done(e);
}
}, 45);
n1.emit("input", {payload:"andy!@3"});
});
});
it('wont decode base64 to string if not a string', function(done) {
var flow = [{id:"n1", type:"base64", action:"b64", wires:[["n2"]] },
{id:"n2", type:"helper"} ];
helper.load(testNode, flow, function() {
var n1 = helper.getNode("n1");
var n2 = helper.getNode("n2");
n2.on("input", function(msg) {
done("should not get here with no payload.");
});
setTimeout(function () {
try {
var logEvents = helper.log().args.filter(function (evt) {
return evt[0].type == "base64";
});
logEvents[0][0].should.have.a.property('msg');
logEvents[0][0].msg.toString().should.startWith("Not a Base64 string");
done();
} catch (e) {
done(e);
}
}, 45);
n1.emit("input", {payload:1234});
});
});
});