frodovdr
/
node-red-nodes
mirror of https://github.com/node-red/node-red-nodes.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Better error catching in ping node for spawn errors...

This commit is contained in:
Dave Conway-Jones 2018-12-05 13:46:08 +00:00
parent 739e8cd9b6
commit 89d7853891
No known key found for this signature in database
GPG Key ID: 9E7F9C73F5168CD4
3 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
io/ping/88-ping.js
View File

@ -18,6 +18,7 @@ module.exports = function(RED) {
else { node.error("Sorry - your platform - "+plat+" - is not recognised."); }
var res = false;
var line = "";
var fail = false;
//var regex = /from.*time.(.*)ms/;
var regex = /=.*[<|=]([0-9]*).*TTL|ttl..*=([0-9\.]*)/;
ex.stdout.on('data', function (data) {
@ -26,7 +27,20 @@ module.exports = function(RED) {
//ex.stderr.on('data', function (data) {
//console.log('[ping] stderr: ' + data);
//});
ex.on('error', function (err) {
fail = true;
if (err.code === "ENOENT") {
node.error(err.code + " ping command not found");
}
else if (err.code === "EACCES") {
node.error(err.code + " can't run ping command");
}
else {
node.error(err.code);
}
});
ex.on('close', function (code) {
if (fail) { fail = false; return; }
var m = regex.exec(line)||"";
if (m !== '') {
if (m[1]) { res = Number(m[1]); }

6
io/ping/README.md
View File

@ -11,9 +11,11 @@ Run the following command in your Node-RED user directory - typically `~/.node-r
npm install node-red-node-ping
**Gotcha**
**Gotchas**
On some versions on Raspbian (Raspberry Pi) `ping` seems to be a root only command.
1 This won't run on Ubunti Snap as the strict container does not allow spawning of external commands (like ping).
2 On some versions on Raspbian (Raspberry Pi) `ping` seems to be a root only command.
The fix is to allow it as follows
sudo setcap cap_net_raw=ep /bin/ping

2
io/ping/package.json
View File

@ -1,6 +1,6 @@
{
"name" : "node-red-node-ping",
"version" : "0.0.15",
"version" : "0.0.16",
"description" : "A Node-RED node to ping a remote server, for use as a keep-alive check.",
"dependencies" : {
},