frodovdr/node-red-nodes
1
0
Fork 0
mirror of https://github.com/node-red/node-red-nodes.git synced 2025-03-01 10:37:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve Arduino Node error handling

Browse Source
This commit is contained in:
Dave Conway-Jones 2025-02-08 17:42:12 +00:00
parent 97f8e03c71
commit cc186ef14e
No known key found for this signature in database
GPG Key ID: 1DDB0E91A28C2643
2 changed files with 126 additions and 97 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
hardware/Arduino/35-arduino.js
View File

@ -12,18 +12,25 @@ module.exports = function(RED) {
this.running = false;
this.reported = false;
var node = this;
var loop;
var startup = function() {
if (node.device === null) {
node.error(RED._("arduino.errors.portnotconf"));
}
else {
node.board = new Board(node.device, function(e) {
if ((e !== undefined) && (e.toString().indexOf("cannot open") !== -1) ) {
if (node.reported === false) {
node.error(RED._("arduino.errors.portnotfound",{device:node.device}));
node.reported = true;
node.board.port = null;
}
}
else if (e === undefined) {
node.running = true;
node.reported = false;
node.board.port = node.device;
node.board.once('ready', function() {
node.log(RED._("arduino.status.connected",{device:node.board.sp.path}));
if (RED.settings.verbose) {
@ -38,12 +45,14 @@ module.exports = function(RED) {
});
}
});
setTimeout(function() { if (node.running === false) { startup(); } }, 5000);
}
loop = setTimeout(function() { if (node.running === false) { startup(); } }, 5000);
};
startup();
node.on('close', function(done) {
node.running = false;
clearTimeout(loop);
if (node.board) {
try {
node.board.transport.close(function() {
@ -69,13 +78,18 @@ module.exports = function(RED) {
this.serverConfig = RED.nodes.getNode(this.arduino);
this.running = false;
var node = this;
var loop
if (typeof this.serverConfig === "object") {
var startup = function() {
node.board = node.serverConfig.board;
node.board.setMaxListeners(0);
node.oldval = "";
node.status({fill:"grey",shape:"ring",text:"node-red:common.status.connecting"});
if (!node.board.port) {
node.status({fill:"red",shape:"ring",text:"Port Not Found"});
}
var doit = function() {
if (node.pin && !isNaN(node.pin) && node.pin >=0 && node.pin <= 20) {
node.running = true;
if (node.state === "ANALOG") { node.board.pinMode(node.pin, 0x02); }
if (node.state === "INPUT") { node.board.pinMode(node.pin, 0x00); }
@ -113,14 +127,18 @@ module.exports = function(RED) {
}
});
}
}
else {
node.status({fill:"red",shape:"ring",text:"Invalid pin: "+node.pin});
}
node.board.once('disconnect', function() {
node.status({fill:"red",shape:"ring",text:"node-red:common.status.not-connected"});
if (node.running) { setTimeout(function() { node.running = false; startup(); }, 5500); }
if (node.running) { loop = setTimeout(function() { node.running = false; startup(); }, 5500); }
});
}
if (node.board.isReady) { doit(); }
else { node.board.once("ready", function() { doit(); }); }
setTimeout(function() { if (node.running === false) { startup(); } }, 4500);
loop = setTimeout(function() { if (node.running === false) { startup(); } }, 4500);
}
startup();
}
@ -129,6 +147,7 @@ module.exports = function(RED) {
}
node.on('close', function() {
node.running = false;
clearTimeout(loop)
});
}
RED.nodes.registerType("arduino in",DuinoNodeIn);
@ -144,12 +163,17 @@ module.exports = function(RED) {
this.serverConfig = RED.nodes.getNode(this.arduino);
this.running = false;
var node = this;
var loop;
if (typeof node.serverConfig === "object") {
var startup = function() {
node.board = node.serverConfig.board;
node.board.setMaxListeners(0);
node.status({fill:"grey",shape:"ring",text:"node-red:common.status.connecting"});
if (!node.board.port) {
node.status({fill:"red",shape:"ring",text:"Port Not Found"});
}
var doit = function() {
if (node.pin && !isNaN(node.pin) && node.pin >=0 && node.pin <= 20) {
node.running = true;
if (node.state === "OUTPUT") { node.board.pinMode(node.pin, 0x01); }
if (node.state === "PWM") { node.board.pinMode(node.pin, 0x03); }
@ -185,14 +209,18 @@ module.exports = function(RED) {
}
}
});
}
else {
node.status({fill:"red",shape:"ring",text:"Invalid pin: "+node.pin});
}
node.board.once('disconnect', function() {
node.status({fill:"red",shape:"ring",text:"node-red:common.status.not-connected"});
if (node.running === true) { setTimeout(function() { node.running = false; startup(); }, 5500); }
if (node.running === true) { loop = setTimeout(function() { node.running = false; startup(); }, 5500); }
});
}
if (node.board.isReady) { doit(); }
else { node.board.once("ready", function() { doit(); }); }
setTimeout(function() { if (node.running === false) { startup(); } }, 4500);
loop = setTimeout(function() { if (node.running === false) { startup(); } }, 4500);
}
startup();
}
@ -201,6 +229,7 @@ module.exports = function(RED) {
}
node.on('close', function() {
node.running = false;
clearTimeout(loop)
});
}
RED.nodes.registerType("arduino out",DuinoNodeOut);

4
hardware/Arduino/package.json
View File

@ -1,6 +1,6 @@
{
"name": "node-red-node-arduino",
"version": "1.0.0",
"version": "1.1.0",
"description": "A Node-RED node to talk to an Arduino running firmata",
"dependencies": {
"serialport": "^12.0.0"
@ -23,7 +23,7 @@
}
},
"engines": {
"node": ">=16.0.0"
"node": ">=18.0.0"
},
"author": {
"name": "Dave Conway-Jones",