frodovdr/node-red-nodes
1
0
Fork 0
mirror of https://github.com/node-red/node-red-nodes.git synced 2025-03-01 10:37:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Updates to match API changes (#392)

Browse Source 
* Updates to match API changes

Update to the node to match the server API changes. An attempt has been made to leave a legacy path for existing installations that may have not updated the server side.

* Updated following comments.

Update following comments.

Output removed and node.warn or error used.

oneeditprepare added.

Name moved to last item.

In addition, a check added to ensure nodegroup has valid value.

Question: I have added a 'return' as I do not want data posted if there is not a valid nodegroup.  Is this the best way to exit the function?  Always taught that multiple exits was a bad idea.  I wondered about raising an error / exception and then catching it but not sure how to do that.

* Update documentation for revised node
This commit is contained in:
borpin
2018-01-07 15:37:28 +00:00
committed by Dave Conway-Jones
parent 29694dd2cb
commit dbea8a484a
3 changed files with 126 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

91
io/emoncms/88-emoncms.js
View File

@@ -22,41 +22,102 @@ module.exports = function(RED) {
this.apikey = sc.credentials.apikey;
this.nodegroup = n.nodegroup || "";
this.datatype = n.datatype || "";
var node = this;
var http;
if (this.baseurl.substring(0,5) === "https") { http = require("https"); }
else { http = require("http"); }
this.on("input", function(msg) {
this.url = this.baseurl + '/input/post.json?';
if (typeof(msg.payload) !== "string") {
this.url += 'json=' + JSON.stringify(msg.payload);
}
else {
if (msg.payload.indexOf(':') > -1) {
this.url += 'json={' + msg.payload + '}';
// setup the data for the URI
if (this.datatype == "legacy"){
this.url = this.baseurl + '/input/post.json?';
if (typeof(msg.payload) !== "string") {
this.url += 'json=' + JSON.stringify(msg.payload);
}
else {
this.url += 'csv=' + msg.payload;
if (msg.payload.indexOf(':') > -1) {
this.url += 'json={' + msg.payload + '}';
}
else {
this.url += 'csv=' + msg.payload;
}
}
}
this.url += '&apikey='+this.apikey;
else if (this.datatype == "fulljson"){
this.url = this.baseurl + '/input/post?';
this.url += 'fulljson=' + encodeURIComponent(JSON.stringify(msg.payload));
}
else if (this.datatype == "json"){
this.url = this.baseurl + '/input/post?';
this.url += 'json={' + encodeURIComponent(msg.payload) + '}';
}
else if (this.datatype == "CSV"){
this.url = this.baseurl + '/input/post?';
this.url += 'csv=' + msg.payload;
}
else {
node.error("ERROR : No valid data type set - " + this.datatype);
return;
}
// setup the node group for URI. Must have a node group or exit
var nodegroup = this.nodegroup || msg.nodegroup;
if (nodegroup !== "") {
if (typeof nodegroup === "undefined") {
node.error("ERROR: A Node group must be specified - " + nodegroup);
node.status({fill:"red",shape:"ring",text:"No Nodegroup"});
return;
} else {
this.url += '&node=' + nodegroup;
}
if (typeof msg.time !== 'undefined') {
if (!isNaN(parseInt(msg.time))) { this.url += '&time=' + msg.time; }
// setup the API key for URI.
this.url += '&apikey=' + this.apikey;
// check for a time object and setup URI if valid
if (typeof msg.time === "undefined") {
node.warn("WARN: Time object undefined, no time set");
}
else {
if (!isNaN(msg.time)) {
this.url += '&time=' + msg.time;
}
else {
if (isNaN(Date.parse(msg.time))) {
// error condition
node.warn("WARN: Time object not valid, no time set - " + msg.time);
} else {
this.url += '&time=' + Date.parse(msg.time)/1000; //seconds
}
}
delete msg.time; // clean it up for the error msg
}
var URIsent = this.url;
http.get(this.url, function(res) {
msg.topic = "http response";
msg.rc = res.statusCode;
msg.payload = "";
res.setEncoding('utf8');
res.on('data', function(chunk) {
msg.payload += chunk;
});
res.on('end', function() {
if (msg.rc === 200) {
node.send(msg);
res.on('end', function() { //A 200 StatusCode does not mean data input sucess
try {
msg.payload = JSON.parse(msg.payload);
if (msg.payload.success) {
node.status({fill:"green",shape:"dot",text:"Success"});
} else {
msg.warning = "ERROR: API Call Failed";
msg.payload.urlsent = decodeURIComponent(URIsent);
node.error(msg);
node.status({fill:"red",shape:"ring",text:"Failed"});
}
}
catch(err) {
msg.warning = "ERROR: Http response"
node.warn(msg);
node.status({fill:"red",shape:"ring",text:"http issue"});
}
});
}).on('error', function(e) {