1
0
mirror of https://github.com/node-red/node-red-nodes.git synced 2023-10-10 13:36:58 +02:00
Commit Graph

14 Commits

Author SHA1 Message Date
bimalyn-IBM
2204d5835f Fix: SNMP fails to close/destroy sessions when it errors (#318)
* I've modified the snmp libraries so that the server and the community can be defined by the msg.
Error will be thrown if you try to override what was defined in the node.
Verified that the contents of msg is no longer clobbered.

Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>

* Replaced tabs with 4 spaces.
Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>

* fix extra spacing

Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>

* Standardise node.error to include msg so that errors can caught

Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>

* Update documentation for snmp nodes

fixed documentation as noted, removed conflict and iff from documention
remove node.warns if host or community are set in both the node config and msg

Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>

* FIX: Close net-snmp sessions
Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>

* Fix 2: The previous push did not cleanly address the problem.

This commit uses a singleton aproach to create socket.
It still needs to be tested to see if there is any issue to the never-close,
but reuse socket model. My only concern is if a socket dies, do we need to do something to reestablish it?

Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
2017-05-30 17:15:36 +01:00
bimalyn-IBM
a3211a5e80 Update documentation for snmp nodes (#301)
* I've modified the snmp libraries so that the server and the community can be defined by the msg.
Error will be thrown if you try to override what was defined in the node.
Verified that the contents of msg is no longer clobbered.

Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>

* Replaced tabs with 4 spaces.
Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>

* fix extra spacing

Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>

* Standardise node.error to include msg so that errors can caught

Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>

* Update documentation for snmp nodes

fixed documentation as noted, removed conflict and iff from documention
remove node.warns if host or community are set in both the node config and msg

Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
2017-04-22 15:53:04 +01:00
Dave Conway-Jones
4168fe7845
bump snap package to release PR 2017-04-15 12:14:34 +01:00
bimalyn-IBM
0f7e8385b8 Allow msg to set parameters for snmp nodes. (#299)
* I've modified the snmp libraries so that the server and the community can be defined by the msg.
Error will be thrown if you try to override what was defined in the node.
Verified that the contents of msg is no longer clobbered.

Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>

* Replaced tabs with 4 spaces.
Signed-off-by: Bryan Malyn <bimalyn@us.ibm.com>
2017-04-15 12:04:47 +01:00
Dave Conway-Jones
316a2fd272 Re-lint a load of nodes 2017-01-29 17:45:44 +00:00
Dave Conway-Jones
b2634ab4f2 fix error logging in snap node
to close #267
2017-01-18 18:55:10 +00:00
Dave Conway-Jones
a7247e898a Update licenses and packages for all nodes 2016-11-06 20:26:19 +00:00
Dave Conway-Jones
f70cd1d640 snap node - remove extraneous console logging 2016-09-01 11:17:18 +01:00
Dave Conway-Jones
d087281a11 slight edits to snmp to pass jslint-ing 2016-04-12 19:18:48 +01:00
Mika Karaila
163345cf5c Added subtree and walker nodes. (#200)
Thanks @mikakaraila  - very useful.
2016-04-12 18:39:19 +01:00
Dave Conway-Jones
48bcd3c7df load of tiny listing fixes, undef, unused, etc 2016-04-09 18:00:20 +01:00
Dave Conway-Jones
5a95e9c404 update snap node docs to make outputs more obvious 2016-02-11 22:50:30 +00:00
dceejay
d511ee69fb lots of little node edits to clean up jsHint "errors" 2015-03-26 18:55:03 +00:00
dceejay
8df7189058 Add discovery (mdns) and SNMP nodes 2015-03-04 19:55:53 +00:00