Commit Graph

316 Commits

Author SHA1 Message Date
Dave Conway-Jones 3b7fb0aa95
tidy up xmpp node 2020-10-24 15:02:45 +01:00
Dave Conway-Jones 6f351943cb
email node - remove promises for node8
and fixup tests
2020-10-19 21:33:32 +01:00
Dave Conway-Jones ef1ebe7b44
Fix email tests and add one for MTA node 2020-10-19 14:32:09 +01:00
Dave Conway-Jones 14087a9f77
Add MTA node to email 2020-10-19 12:24:18 +01:00
Nick O'Leary 8f2c631410
Bump pushbullet node version 2020-10-13 22:38:18 +01:00
guzba ff9d21827d
Attempt to mitigate stream server connect feedback loop
Pushbullet dev here. Around 36 hours ago we started receiving around 750 additional requests per second to connect to our stream server. I blocked around 50 - 100 IP addresses to mitigate the spam. This spam traffic has continued unchanged since then.

I don't know for sure what caused this, but one user came forward reporting issues with their Node-Red setup after I banned the IPs (status code is my banned IP status code which is pretty compelling evidence). I can't be sure what is causing the issue since no User-Agent is included in the requests, but it for sure is at least partly Node-Red API users. I'd like to work on mitigating this since mitigating the spam traffic costs money.

My first theory here is in this PR. I am not aware of any guarantees that you'll never get multiple 'error' events, so it makes sense to clear the timeout before setting a new one to reconnect. Even if it is just defensive, it may not have much cost? If you do get multiple error events without this change, it is possible to trigger many connect() requests which can error out and then trigger many more connect() requests with lots of timeouts, which is not good.

Another thing to consider is that this library's dependency for PB (https://github.com/alexwhitman/node-pushbullet-api) already has code to reconnect if a websocket connection is lost without having been properly closed. I think an even better solution is verifying this works and then deleting the reconnect logic from here.

I'm not an expert on Node-Red though so I am only trying to offer suggestions to ensure everyone is a good citizen when using our API :) Thanks!
2020-10-13 16:27:30 -05:00
Dave Conway-Jones aa45796a98
bump pushbullet package for PR 2020-09-27 12:59:02 +01:00
Frakke0 e980c8c04d
Fix not shown error (#692)
Fixed response to shown as string and not object
2020-09-27 12:57:09 +01:00
Dave Conway-Jones d3a3bc158c
email - show valid folders in error if fetch fails 2020-09-23 23:54:09 +01:00
Dave Conway-Jones 973fd8c6ec
bump email package version 2020-09-23 10:20:58 +01:00
Vincent Hou 606f9c71e7
Update 61-email.js (#689)
Fixed disposition issue caused by `this`.
2020-09-23 08:35:08 +01:00
Dave Conway-Jones 46f3dfc382
email don't retry connection while still busy. 2020-08-28 09:36:06 +01:00
Dave Conway-Jones ea729546d4
add sms_changed to pushbullet handler 2020-08-24 12:12:32 +01:00
Dave Conway-Jones 4cabe5ea30
bump xmpp node package version 2020-07-16 10:15:49 +01:00
Andreas Martens e334040dd7
replace xmpp-simple with @xmpp/client (#664)
* replace xmpp-simple with @xmpp/client

* indent at 4

* remove trailing commas
2020-07-16 10:00:27 +01:00
Andreas Martens bf94d320a9
correctly join a chat room (#663) 2020-07-10 12:30:44 +01:00
Dave Conway-Jones 01d675b372
Merge branch 'master' of https://github.com/node-red/node-red-nodes 2020-05-24 16:42:42 +01:00
Dave Conway-Jones e2c9a6521e
pushover node - hide user id and well as api key 2020-05-24 16:42:28 +01:00
juggledad 3afc2622f3
Updated README to expand the way `msg.from` works (#654) 2020-05-23 07:57:31 +01:00
Dave Conway-Jones 18afc438da
bup version for npm to pick up error handling PR. 2020-05-20 14:07:26 +01:00
JsBergbau d4d2404578
On error sending pushover message throw a catchable exception (#653)
* On error throw a catchable 

Throws an catchable exception if there is any error in sending the message. So you can react to it with a catch node

* Updated errorhandling

Updated the error handling process to be in compliance with the Node-RED Api
2020-05-20 14:04:42 +01:00
Dave Conway-Jones 43bdfb9fe3
bump lib 2020-05-05 19:36:48 +01:00
Dave Conway-Jones 92adb10fb3
pushover: ensure handles missing payload. 2020-04-17 09:43:45 +01:00
Dave Conway-Jones 0b590236a0
bump some node-red-node deps and packages
some due to  long outstanding doc PRs
2020-04-03 22:29:43 +01:00
dxdc a498bd16b5
Use latest release of node-prowl (#624) 2020-02-17 22:12:23 +00:00
Dave Conway-Jones 55f6609a4f
Fix email node timeout when triggered manually 2020-02-09 14:11:54 +00:00
Dave Conway-Jones 5780b2a5c3
slight adjust email retry timeout 2020-01-31 21:46:42 +00:00
Dave Conway-Jones 90a00279c0
add note re criteria to email in node
and change x-red to html
2020-01-28 18:15:28 +00:00
Dave Conway-Jones f1ff7fe707
bump to catch PR re attachments and update libs 2020-01-08 09:26:46 +00:00
Kazuhito Yokoi 12be92e06f Unify file name for binary attachment in e-mail node (#619) 2020-01-08 09:13:05 +00:00
Dave Conway-Jones c5fed3fc4e
restore smpp node server field to config.
to close #613
2019-12-26 16:25:11 +00:00
Dave Conway-Jones 3d60aa4c00
bump sentiment, rbe, email, feedparser, twitter, tail nodes
Locale files moved out
2019-12-05 21:36:59 +00:00
Kazuhito Yokoi 870a2146c0 Move English help to en-US directory (#592)
* Move English help about e-mail node to en-US directory

* Move English help about rbe node to en-US directory

* Move English help about tail node to en-US directory

* Move English help about twitter node to en-US directory

* Move English help about feedparse node to en-US directory

* Move English help about sentiment node to en-US directory
2019-12-05 21:18:59 +00:00
Dave Conway-Jones e814c676d2
bump pushover lib to pick up fix
to close #590
2019-11-13 21:53:58 +00:00
Dave Conway-Jones 9f27cda34f
bump email version 2019-11-09 12:00:58 +00:00
Hiroyuki Okada d53bd47f44 update mailparser & nodemailer (#599) 2019-11-09 11:58:53 +00:00
Dave Conway-Jones a318dc56ff
better escape for node-red without done. 2019-09-26 13:39:25 +01:00
Dave Conway-Jones 1f0ab0937d
Add done/complete to email node
and fix .from field
2019-09-24 21:44:56 +01:00
Dave Conway-Jones 876c9a014e
add try catch to pushover node response 2019-09-08 15:30:49 +01:00
Dave Conway-Jones 6682320c97
Add gmail access info to readme and info 2019-08-29 15:49:38 +01:00
Dave Conway-Jones e20cf97fce
A whole bunch of whitespace linting - no functional changes 2019-08-11 13:37:15 +01:00
Nick O'Leary cd21a5f3c8
Add twitter icon to twitter node to remove dependency on core icon 2019-06-21 14:09:50 +01:00
Dave Conway-Jones 587ff6b8e6
don't let through pusher error
to close #548
2019-06-18 08:52:55 +01:00
Dave Conway-Jones 88ee43186c
update email info to match actual implementation. 2019-06-14 16:37:31 -04:00
Luis Mario Domenzain 16130362fc email optionally uses criteria from message (#547)
* email optionally uses criteria from message

Allows for generation of detailed queries through flows when triggering an email
fetch in IMAP.

* use the same default as a new email node

When the criteria is set from a message, if there is no criteria use the same default as a new node.
2019-05-29 12:45:54 +01:00
Luis Mario Domenzain 877763aae9 use latest mailparser API (#546)
The API diverged between the original and mailparser-mit
2019-05-28 16:55:07 +01:00
Dave Conway-Jones 2dfa1385c3
bump version for pr to get to npm 2019-05-26 14:24:45 +01:00
Hiroyuki Okada a226e6a308 add device filter (#545)
* add device filter

* fix jslint error of pushbullet

* fix pushbullet.js
2019-05-26 14:23:25 +01:00
Dave Conway-Jones f20d00a972
fix mailparser require 2019-05-23 12:35:13 +01:00
Dave Conway-Jones 3619971c57
bump email package for latest libs plus PR 2019-05-22 08:40:07 +01:00