1
0
mirror of https://github.com/node-red/node-red-nodes.git synced 2023-10-10 13:36:58 +02:00
Commit Graph

26 Commits

Author SHA1 Message Date
Dave Conway-Jones
4884550215
Tidy up pushbullet (no fixes)
remove old migration code)
2020-11-16 21:26:32 +00:00
guzba
ff9d21827d
Attempt to mitigate stream server connect feedback loop
Pushbullet dev here. Around 36 hours ago we started receiving around 750 additional requests per second to connect to our stream server. I blocked around 50 - 100 IP addresses to mitigate the spam. This spam traffic has continued unchanged since then.

I don't know for sure what caused this, but one user came forward reporting issues with their Node-Red setup after I banned the IPs (status code is my banned IP status code which is pretty compelling evidence). I can't be sure what is causing the issue since no User-Agent is included in the requests, but it for sure is at least partly Node-Red API users. I'd like to work on mitigating this since mitigating the spam traffic costs money.

My first theory here is in this PR. I am not aware of any guarantees that you'll never get multiple 'error' events, so it makes sense to clear the timeout before setting a new one to reconnect. Even if it is just defensive, it may not have much cost? If you do get multiple error events without this change, it is possible to trigger many connect() requests which can error out and then trigger many more connect() requests with lots of timeouts, which is not good.

Another thing to consider is that this library's dependency for PB (https://github.com/alexwhitman/node-pushbullet-api) already has code to reconnect if a websocket connection is lost without having been properly closed. I think an even better solution is verifying this works and then deleting the reconnect logic from here.

I'm not an expert on Node-Red though so I am only trying to offer suggestions to ensure everyone is a good citizen when using our API :) Thanks!
2020-10-13 16:27:30 -05:00
Dave Conway-Jones
ea729546d4
add sms_changed to pushbullet handler 2020-08-24 12:12:32 +01:00
Dave Conway-Jones
e20cf97fce
A whole bunch of whitespace linting - no functional changes 2019-08-11 13:37:15 +01:00
Hiroyuki Okada
a226e6a308 add device filter (#545)
* add device filter

* fix jslint error of pushbullet

* fix pushbullet.js
2019-05-26 14:23:25 +01:00
Dave Conway-Jones
ee852bf060
Bump event listener limit up to 100
to close #327
2017-08-27 18:21:14 +01:00
Dave Conway-Jones
38d16b8a4d
Tidy up listing for some nodes. No functional changes
to make listing task pass
2017-04-12 13:32:08 +01:00
Dave Conway-Jones
316a2fd272 Re-lint a load of nodes 2017-01-29 17:45:44 +00:00
Dave Conway-Jones
7917ca8dcf Fix missing httpAdmin permissions for Pushbullet, twitter what3words and sensehatsim
fixes #244
2016-11-06 20:27:21 +00:00
Dave Conway-Jones
f3b315ea7c Let Pushbullet in reconnect on errors
to fix #171
2016-01-31 23:27:37 +00:00
dceejay
64d3b11fd9 slightly nicer jscs style updates to several nodes
again not pushed to npm - still just whitespace.
2015-05-11 20:04:51 +01:00
dceejay
f497b57b7d Apply consistent style to node-red-nodes
(not updating npm for this yet - just whitespace)
2015-05-11 19:25:39 +01:00
Nick O'Leary
db0047379f Defer creation of Pushbullet eventemitter 2015-04-22 13:19:51 +01:00
Nick O'Leary
66581d71e1 Better error handling in PushBullet nodes 2015-04-20 10:50:36 +01:00
dceejay
d511ee69fb lots of little node edits to clean up jsHint "errors" 2015-03-26 18:55:03 +00:00
dsundberg
425858d94d Updated pushbullet node with all push types, added new "pushbullet in" that emits pushes. Added unit tests. 2015-02-07 12:36:30 +01:00
Dave C-J
6768c1b42b Update Pushbullet Node to allow use of Channels 2014-11-10 16:42:49 +00:00
Dave C-J
62956b0bb8 Update node-red-nodes social nodes to use strict and pass jshint scan 2014-06-28 23:34:59 +01:00
Dave C-J
2c80c90f84 Remove unnecessary console logging from Pushbullet node.
(now underlying npm has been updated... multiple nodes now work ok)
2014-04-24 18:37:11 +01:00
Dave C-J
5b28f06510 Pushbullet changes to make it more obvious what it is now doing...
(and fix a couple of things it wasn't)
2014-04-24 10:04:29 +01:00
Dave C-J
4be0e05c2a Add credentials capability to PushBullet node 2014-04-23 21:06:36 +01:00
Dave C-J
c63583ae81 Tidy up pushbullet and prowl nodes. more error handling. 2014-03-02 18:19:25 +00:00
Dave C-J
4a53c20792 Update pushbullet to use latest 0.4 npm and allow iden as well as id 2014-02-14 20:41:54 +00:00
Nicholas O'Leary
3f2433ee7f PushBullet should not load settings file directly 2013-11-13 22:24:02 +00:00
Nicholas O'Leary
6f7487f393 Use process.env.NODE_RED_HOME to locate modules 2013-10-30 21:34:54 +00:00
Nicholas O'Leary
6a0d248f5a Move nodes over from main repo 2013-10-30 20:38:41 +00:00