frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

More defensive handling of missing filename in file node.

Browse Source 
(in line with jshint)
This commit is contained in:
Dave C-J 2014-06-30 23:23:01 +01:00
parent c7f0f9639a
commit 045f658ef9
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
nodes/core/storage/50-file.js
View File

@ -20,23 +20,19 @@ module.exports = function(RED) {
function FileNode(n) { function FileNode(n) {
RED.nodes.createNode(this,n); RED.nodes.createNode(this,n);
this.filename = n.filename || "";
this.filename = n.filename;
this.appendNewline = n.appendNewline; this.appendNewline = n.appendNewline;
this.overwriteFile = n.overwriteFile; this.overwriteFile = n.overwriteFile;
var node = this; var node = this;
this.on("input",function(msg) { this.on("input",function(msg) {
var filename = msg.filename || this.filename; var filename = msg.filename || this.filename;
if (filename === "") { if (filename === "") {
node.warn('No filename specified'); node.warn('No filename specified');
} else if (typeof msg.payload != "undefined") { } else if (typeof msg.payload != "undefined") {
var data = msg.payload; var data = msg.payload;
if (typeof data == "object") { data = JSON.stringify(data); } if (typeof data == "object") { data = JSON.stringify(data); }
if (typeof data == "boolean") { data = data.toString(); } if (typeof data == "boolean") { data = data.toString(); }
if (this.appendNewline) { if (this.appendNewline) { data += "\n"; }
data += "\n";
}
if (msg.hasOwnProperty('delete')) { if (msg.hasOwnProperty('delete')) {
fs.unlink(filename, function (err) { fs.unlink(filename, function (err) {
if (err) { node.warn('Failed to delete file : '+err); } if (err) { node.warn('Failed to delete file : '+err); }
@ -65,7 +61,7 @@ module.exports = function(RED) {
function FileInNode(n) { function FileInNode(n) {
RED.nodes.createNode(this,n); RED.nodes.createNode(this,n);
this.filename = n.filename; this.filename = n.filename || "";
this.format = n.format; this.format = n.format;
var node = this; var node = this;
var options = {}; var options = {};
@ -74,7 +70,6 @@ module.exports = function(RED) {
} }
this.on("input",function(msg) { this.on("input",function(msg) {
var filename = msg.filename || this.filename; var filename = msg.filename || this.filename;
if (filename === "") { if (filename === "") {
node.warn('No filename specified'); node.warn('No filename specified');
} else { } else {