frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

Allow arrays of different lengths to be passed to set.

Browse Source
This commit is contained in:
HirokiUchikawa 2018-07-13 20:59:45 +09:00
parent 6b2f5fbb19
commit 050acd239c
2 changed files with 131 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
red/runtime/nodes/context/index.js
View File

@ -268,12 +268,14 @@ function createContext(id,seed) {
} }
context = getContextStorage(storage); context = getContextStorage(storage);
} }
if (!Array.isArray(key) || !Array.isArray(value) || key.length !== value.length) { if (!Array.isArray(key)) {
context.set(scope, key, value, callback); context.set(scope, key, value, callback);
} else { } else {
// If key and value are Array and each length is same, set each key-value pair. // If key is an array, set each key-value pair.
// If the value array is longer than the key array, then the extra values are ignored.
var index = 0; var index = 0;
var cb = function(err, v) { var values = [].concat(value); // Convert the value to an array
var cb = function(err) {
if (err) { if (err) {
if (callback) { if (callback) {
callback(err); callback(err);
@ -285,11 +287,16 @@ function createContext(id,seed) {
callback(null); callback(null);
} }
} else { } else {
context.set(scope, key[index], value[index], cb); if(index < values.length) {
context.set(scope, key[index], values[index], cb);
} else {
// If the value array is shorter than the key array, use null for missing values.
context.set(scope, key[index], null, cb);
}
} }
} }
}; };
context.set(scope, key[index], value[index], cb); context.set(scope, key[index], values[index], cb);
} }
}; };
obj.keys = function(storage, callback) { obj.keys = function(storage, callback) {

119
test/red/runtime/nodes/context/index_spec.js
View File

@ -639,6 +639,125 @@ describe('context', function() {
}); });
}); });
it('should deletes multiple properties', function(done) {
Context.init({contextStorage:memoryStorage});
Context.load().then(function(){
var context = Context.get("1","flow");
context.set(["foo1","foo2","foo3"], ["bar1","bar2","bar3"], "memory", function(err){
if (err) {
done(err);
} else {
context.get(["foo1","foo2","foo3"], "memory", function(err,foo1,foo2,foo3){
if (err) {
done(err);
} else {
foo1.should.be.equal("bar1");
foo2.should.be.equal("bar2");
foo3.should.be.equal("bar3");
context.set(["foo1","foo2","foo3"], new Array(3), "memory", function(err){
if (err) {
done(err);
} else {
context.get(["foo1","foo2","foo3"], "memory", function(err,foo1,foo2,foo3){
if (err) {
done(err);
} else {
should.not.exist(foo1);
should.not.exist(foo2);
should.not.exist(foo3);
done();
}
});
}
});
}
});
}
});
});
});
it('should use null for missing values if the value array is shorter than the key array', function(done) {
Context.init({contextStorage:memoryStorage});
Context.load().then(function(){
var context = Context.get("1","flow");
context.set(["foo1","foo2","foo3"], ["bar1","bar2"], "memory", function(err){
if (err) {
done(err);
} else {
context.keys(function(err, keys){
keys.should.have.length(3);
keys.should.eql(["foo1","foo2","foo3"]);
context.get(["foo1","foo2","foo3"], "memory", function(err,foo1,foo2,foo3){
if (err) {
done(err);
} else {
foo1.should.be.equal("bar1");
foo2.should.be.equal("bar2");
should(foo3).be.null();
done();
}
});
});
}
});
});
});
it('should use null for missing values if the value is not array', function(done) {
Context.init({contextStorage:memoryStorage});
Context.load().then(function(){
var context = Context.get("1","flow");
context.set(["foo1","foo2","foo3"], "bar1", "memory", function(err){
if (err) {
done(err);
} else {
context.keys(function(err, keys){
keys.should.have.length(3);
keys.should.eql(["foo1","foo2","foo3"]);
context.get(["foo1","foo2","foo3"], "memory", function(err,foo1,foo2,foo3){
if (err) {
done(err);
} else {
foo1.should.be.equal("bar1");
should(foo2).be.null();
should(foo3).be.null();
done();
}
});
});
}
});
});
});
it('should ignore the extra values if the value array is longer than the key array', function(done) {
Context.init({contextStorage:memoryStorage});
Context.load().then(function(){
var context = Context.get("1","flow");
context.set(["foo1","foo2","foo3"], ["bar1","bar2","bar3","ignored"], "memory", function(err){
if (err) {
done(err);
} else {
context.keys(function(err, keys){
keys.should.have.length(3);
keys.should.eql(["foo1","foo2","foo3"]);
context.get(["foo1","foo2","foo3"], "memory", function(err,foo1,foo2,foo3){
if (err) {
done(err);
} else {
foo1.should.be.equal("bar1");
foo2.should.be.equal("bar2");
foo3.should.be.equal("bar3");
done();
}
});
});
}
});
});
});
it('should return an error if an error occurs in storing multiple values', function(done) { it('should return an error if an error occurs in storing multiple values', function(done) {
Context.init({contextStorage:contextStorage}); Context.init({contextStorage:contextStorage});
stubSet.onFirstCall().callsArgWith(3, null); stubSet.onFirstCall().callsArgWith(3, null);