From 05f90394db7a24b8c1845859c6404ba1c18705a2 Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Tue, 19 Dec 2017 14:00:58 +0000 Subject: [PATCH] Flag misconfigured project credentialSecret --- red/runtime/nodes/credentials.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/red/runtime/nodes/credentials.js b/red/runtime/nodes/credentials.js index 37126ec5d..89bdf3857 100644 --- a/red/runtime/nodes/credentials.js +++ b/red/runtime/nodes/credentials.js @@ -205,8 +205,16 @@ var api = module.exports = { var clearInvalidFlag = false; if (credentials.hasOwnProperty("$")) { if (encryptionEnabled === false) { + // The credentials appear to be encrypted, but our config + // thinks they are not. var error = new Error("Failed to decrypt credentials"); error.code = "credentials_load_failed"; + if (activeProject) { + // This is a project with a bad key. Mark it as invalid + // TODO: this delves too deep into Project structure + activeProject.credentialSecretInvalid = true; + return when.reject(error); + } return when.reject(error); } // These are encrypted credentials @@ -219,7 +227,7 @@ var api = module.exports = { log.warn(log._("nodes.credentials.error",{message:err.toString()})) var error = new Error("Failed to decrypt credentials"); error.code = "credentials_load_failed"; - if (projectKey) { + if (activeProject) { // This is a project with a bad key. Mark it as invalid // TODO: this delves too deep into Project structure activeProject.credentialSecretInvalid = true;