frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added node warnings when message properties override set node properties

Browse Source
This commit is contained in:
Anna Thomas
2014-11-03 13:41:45 +00:00
parent 9f925140c9
commit 069a47f35a
6 changed files with 44 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
nodes/core/storage/50-file.js
View File

@@ -25,7 +25,15 @@ module.exports = function(RED) {
this.overwriteFile = n.overwriteFile;
var node = this;
this.on("input",function(msg) {
var filename = msg.filename || this.filename;
var filename;
if (msg.filename) {
if (n.filename) {
node.warn("Deprecated: msg properties should not override set node properties. See bit.ly/nr-override-msg-props");
}
filename = msg.filename;
} else {
filename = this.filename;
}
if (filename === "") {
node.warn('No filename specified');
} else if (msg.hasOwnProperty('delete')) {
@@ -72,7 +80,15 @@ module.exports = function(RED) {
options['encoding'] = this.format;
}
this.on("input",function(msg) {
var filename = msg.filename || this.filename;
var filename;
if (msg.filename) {
if (n.filename) {
node.warn("Deprecated: msg properties should not override set node properties. See bit.ly/nr-override-msg-props");
}
filename = msg.filename;
} else {
filename = this.filename;
}
if (filename === "") {
node.warn('No filename specified');
} else {
@@ -92,4 +108,4 @@ module.exports = function(RED) {
});
}
RED.nodes.registerType("file in",FileInNode);
}
};