frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

cloneMessage should handle undefined without throwing err

Browse Source 
Fixes #2399
This commit is contained in:
Nick O'Leary 2020-02-06 10:04:55 +00:00
parent 62fc554d25
commit 0f1ca1c7cf
No known key found for this signature in database
GPG Key ID: 4F2157149161A6C9
2 changed files with 27 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/node_modules/@node-red/util/lib/util.js vendored
View File

@ -81,6 +81,7 @@ function ensureBuffer(o) {
* @memberof @node-red/util_util * @memberof @node-red/util_util
*/ */
function cloneMessage(msg) { function cloneMessage(msg) {
if (typeof msg !== "undefined") {
// Temporary fix for #97 // Temporary fix for #97
// TODO: remove this http-node-specific fix somehow // TODO: remove this http-node-specific fix somehow
var req = msg.req; var req = msg.req;
@ -98,6 +99,8 @@ function cloneMessage(msg) {
} }
return m; return m;
} }
return msg;
}
/** /**
* Compares two objects, handling various JavaScript types. * Compares two objects, handling various JavaScript types.

4
test/unit/@node-red/util/lib/util_spec.js
View File

@ -143,6 +143,10 @@ describe("@node-red/util/util", function() {
cloned.req.should.equal(msg.req); cloned.req.should.equal(msg.req);
cloned.res.should.equal(msg.res); cloned.res.should.equal(msg.res);
}); });
it('handles undefined values without throwing an error', function() {
var result = util.cloneMessage(undefined);
should.not.exist(result);
})
}); });
describe('getObjectProperty', function() { describe('getObjectProperty', function() {
it('gets a property beginning with "msg."', function() { it('gets a property beginning with "msg."', function() {