frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

cloneMessage should handle undefined without throwing err

Browse Source 
Fixes #2399
This commit is contained in:
Nick O'Leary 2020-02-06 10:04:55 +00:00
parent 62fc554d25
commit 0f1ca1c7cf
No known key found for this signature in database
GPG Key ID: 4F2157149161A6C9
2 changed files with 27 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
packages/node_modules/@node-red/util/lib/util.js vendored
View File

@ -81,22 +81,25 @@ function ensureBuffer(o) {
* @memberof @node-red/util_util * @memberof @node-red/util_util
*/ */
function cloneMessage(msg) { function cloneMessage(msg) {
// Temporary fix for #97 if (typeof msg !== "undefined") {
// TODO: remove this http-node-specific fix somehow // Temporary fix for #97
var req = msg.req; // TODO: remove this http-node-specific fix somehow
var res = msg.res; var req = msg.req;
delete msg.req; var res = msg.res;
delete msg.res; delete msg.req;
var m = clone(msg); delete msg.res;
if (req) { var m = clone(msg);
m.req = req; if (req) {
msg.req = req; m.req = req;
msg.req = req;
}
if (res) {
m.res = res;
msg.res = res;
}
return m;
} }
if (res) { return msg;
m.res = res;
msg.res = res;
}
return m;
} }
/** /**

4
test/unit/@node-red/util/lib/util_spec.js
View File

@ -143,6 +143,10 @@ describe("@node-red/util/util", function() {
cloned.req.should.equal(msg.req); cloned.req.should.equal(msg.req);
cloned.res.should.equal(msg.res); cloned.res.should.equal(msg.res);
}); });
it('handles undefined values without throwing an error', function() {
var result = util.cloneMessage(undefined);
should.not.exist(result);
})
}); });
describe('getObjectProperty', function() { describe('getObjectProperty', function() {
it('gets a property beginning with "msg."', function() { it('gets a property beginning with "msg."', function() {