From 10da894124dc0d82ebbf9fdc49f94760ecf82ff0 Mon Sep 17 00:00:00 2001 From: Hiroyasu Nishiyama Date: Tue, 28 May 2019 08:55:00 +0900 Subject: [PATCH] fix function name & string compare function --- .../editor-client/src/js/ui/userSettings.js | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/userSettings.js b/packages/node_modules/@node-red/editor-client/src/js/ui/userSettings.js index c4c4bcdec..0bd241dfc 100644 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/userSettings.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/userSettings.js @@ -101,25 +101,19 @@ RED.userSettings = (function() { RED.tray.show(trayOptions); } - function locale2Name(lc) { + function localeToName(lc) { var name = RED._("languages."+lc); return {text: (name ? name : lc), val: lc}; } function compText(a, b) { - if (a.text > b.text) { - return 1; - } - if (a.text < b.text) { - return -1; - } - return 0; + return a.text.localeCompare(b.text); } var viewSettings = [ { options: [ - {setting:"editor-language",local: true, label:"menu.label.view.language",options:function(done){ done([{val:'',text:RED._('menu.label.view.browserDefault')}].concat(RED.settings.theme("languages").map(locale2Name).sort(compText))) }}, + {setting:"editor-language",local: true, label:"menu.label.view.language",options:function(done){ done([{val:'',text:RED._('menu.label.view.browserDefault')}].concat(RED.settings.theme("languages").map(localeToName).sort(compText))) }}, ] },{ title: "menu.label.view.grid",