From 189389f96a12975c7e2552dd29f9ade1e2ae3e21 Mon Sep 17 00:00:00 2001
From: Nick O'Leary <nick.oleary@gmail.com>
Date: Tue, 5 May 2020 17:35:08 +0100
Subject: [PATCH] [inject] Tidy up node label

---
 .../nodes/core/common/20-inject.html          | 65 +++++++++----------
 1 file changed, 30 insertions(+), 35 deletions(-)

diff --git a/packages/node_modules/@node-red/nodes/core/common/20-inject.html b/packages/node_modules/@node-red/nodes/core/common/20-inject.html
index 0501042c3..af784978a 100644
--- a/packages/node_modules/@node-red/nodes/core/common/20-inject.html
+++ b/packages/node_modules/@node-red/nodes/core/common/20-inject.html
@@ -224,38 +224,6 @@
             return lab;
         },
         label: function() {
-            if (Array.isArray(this.props)) {
-                // find the payload & topic
-                var payloadProperty;
-                var topicProperty;
-                var payload;
-                var payloadType;
-                var topic;
-                for (var i=0,l=this.props.length; i<l; i++) {
-                    if (this.props[i].p === 'payload') {
-                        payloadProperty = this.props[i];
-                    } else if (this.props[i].p === 'topic' && this.props[i].vt === 'str') {
-                        topicProperty = this.props[i];
-                    }
-                }
-
-                // If no payload/topic are found, use the first property instead
-                if (this.props[0]){
-                    payloadProperty = payloadProperty === undefined ? this.props[0] : payloadProperty;
-                    topicProperty = topicProperty === undefined ? {v: payloadProperty.p} : topicProperty; // if no topic, use the property name of the payload
-                }
-
-                payload = payloadProperty === undefined ? "" : payloadProperty.v;
-                payloadType = payloadProperty === undefined ? "str" : payloadProperty.vt;
-                topic = topicProperty === undefined ? "" : topicProperty.v;
-            } else {
-                /* Legacy */
-                payload = this.payload;
-                payloadType = this.payloadType;
-                topic = this.topic;
-            }
-
-
             var suffix = "";
             // if fire once then add small indication
             if (this.once) {
@@ -267,7 +235,34 @@
             }
             if (this.name) {
                 return this.name+suffix;
-            } else if (payloadType === "string" ||
+            }
+
+            var payloadProperty;
+            var topicProperty;
+            var payload;
+            var payloadType;
+            var topic;
+
+            if (Array.isArray(this.props)) {
+                // find the payload & topic if they are set
+                for (var i=0,l=this.props.length; i<l; i++) {
+                    if (this.props[i].p === 'payload') {
+                        payloadProperty = this.props[i];
+                    } else if (this.props[i].p === 'topic' && this.props[i].vt === 'str') {
+                        topicProperty = this.props[i];
+                    }
+                }
+                payload = payloadProperty === undefined ? "" : payloadProperty.v;
+                payloadType = payloadProperty === undefined ? "str" : payloadProperty.vt;
+                topic = topicProperty === undefined ? "" : topicProperty.v;
+            } else {
+                /* Legacy */
+                payload = this.payload || "";
+                payloadType = this.payloadType || "str";
+                topic = this.topic || "";
+            }
+
+            if (payloadType === "string" ||
                     payloadType === "str" ||
                     payloadType === "num" ||
                     payloadType === "bool" ||
@@ -281,9 +276,9 @@
                 }
             } else if (payloadType === 'date' || payloadType === 'bin' || payloadType === 'env') {
                 if ((topic !== "") && (topic.length <= 16)) {
-                    return topic + ":" + this._(`inject.label.${payloadType}`)+suffix;
+                    return topic + ":" + this._('inject.label.'+payloadType)+suffix;
                 } else {
-                    return this._(`inject.label.${payloadType}`)+suffix;
+                    return this._('inject.label.'+payloadType)+suffix;
                 }
             } else if (payloadType === 'flow' || payloadType === 'global') {
                 var key = RED.utils.parseContextKey(payload);