From 19a8fa09a8cf90d63af41abeb767418a7c7eac11 Mon Sep 17 00:00:00 2001 From: GogoVega <92022724+GogoVega@users.noreply.github.com> Date: Thu, 27 Jun 2024 09:16:03 +0200 Subject: [PATCH] Fix node validation if property is not required --- .../editor-client/src/js/ui/editor.js | 23 ++++++++++++++----- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/editor.js b/packages/node_modules/@node-red/editor-client/src/js/ui/editor.js index fa262d0c5..cf17a8fda 100644 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/editor.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/editor.js @@ -148,12 +148,23 @@ RED.editor = (function() { ((typeof definition[property].label) == "string")) { label = definition[property].label; } - if ("required" in definition[property] && definition[property].required) { - valid = value !== ""; - if (!valid && label) { - return RED._("validator.errors.missing-required-prop", { - prop: label - }); + if ("required" in definition[property]) { + if (definition[property].required) { + valid = value !== ""; + if (!valid && label) { + return RED._("validator.errors.missing-required-prop", { + prop: label + }); + } + } else { + if (value === "") { + return true; + } + } + + } else { + if (value === "") { + return true; } } if (valid && "validate" in definition[property]) {