Merge pull request #4632 from node-red/4625-sf-env-err-handling

Add validation and error handling on subflow instance properties
2025-03-01 10:36:34 +00:00 · 2024-03-28 11:10:28 +00:00
parent 20d067c1ea 19213434f9
commit 19dcc3a683
2 changed files with 27 additions and 4 deletions
--- a/packages/node_modules/@node-red/editor-client/src/js/nodes.js
+++ b/packages/node_modules/@node-red/editor-client/src/js/nodes.js
@@ -1029,7 +1029,22 @@ RED.nodes = (function() {
        RED.nodes.registerType("subflow:"+sf.id, {
            defaults:{
                name:{value:""},
-                env:{value:[]}
+                env:{value:[], validate: function(value) {
+                    const errors = []
+                    if (value) {
+                        value.forEach(env => {
+                            const r = RED.utils.validateTypedProperty(env.value, env.type)
+                            if (r !== true) {
+                                errors.push(env.name+': '+r)
+                            }
+                        })
+                    }
+                    if (errors.length === 0) {
+                        return true
+                    } else {
+                        return errors
+                    }
+                }}
            },
            icon: function() { return sf.icon||"subflow.svg" },
            category: sf.category || "subflows",