frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

Lint Switch code

Browse Source
This commit is contained in:
Nick O'Leary 2018-07-08 22:13:36 +01:00
parent 1b693eed37
commit 1a6babd199
No known key found for this signature in database
GPG Key ID: 4F2157149161A6C9
1 changed files with 52 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

113
nodes/core/logic/10-switch.js
View File

@ -59,19 +59,19 @@ module.exports = function(RED) {
'else': function(a) { return a === true; } 'else': function(a) { return a === true; }
}; };
var _max_kept_msgs_count = undefined; var _maxKeptCount;
function max_kept_msgs_count(node) { function getMaxKeptCount() {
if (_max_kept_msgs_count === undefined) { if (_maxKeptCount === undefined) {
var name = "nodeMessageBufferMaxLength"; var name = "nodeMessageBufferMaxLength";
if (RED.settings.hasOwnProperty(name)) { if (RED.settings.hasOwnProperty(name)) {
_max_kept_msgs_count = RED.settings[name]; _maxKeptCount = RED.settings[name];
} }
else { else {
_max_kept_msgs_count = 0; _maxKeptCount = 0;
} }
} }
return _max_kept_msgs_count; return _maxKeptCount;
} }
function SwitchNode(n) { function SwitchNode(n) {
@ -94,10 +94,10 @@ module.exports = function(RED) {
var node = this; var node = this;
var valid = true; var valid = true;
var repair = n.repair; var repair = n.repair;
var needs_count = repair; var needsCount = repair;
for (var i=0; i<this.rules.length; i+=1) { for (var i=0; i<this.rules.length; i+=1) {
var rule = this.rules[i]; var rule = this.rules[i];
needs_count = needs_count || ((rule.t === "tail") || (rule.t === "jsonata_exp")); needsCount = needsCount || ((rule.t === "tail") || (rule.t === "jsonata_exp"));
if (!rule.vt) { if (!rule.vt) {
if (!isNaN(Number(rule.v))) { if (!isNaN(Number(rule.v))) {
rule.vt = 'num'; rule.vt = 'num';
@ -142,26 +142,26 @@ module.exports = function(RED) {
return; return;
} }
var pending_count = 0; var pendingCount = 0;
var pending_id = 0; var pendingId = 0;
var pending_in = {}; var pendingIn = {};
var pending_out = {}; var pendingOut = {};
var received = {}; var received = {};
function add2group_in(id, msg, parts) { function addMessageToGroup(id, msg, parts) {
if (!(id in pending_in)) { if (!(id in pendingIn)) {
pending_in[id] = { pendingIn[id] = {
count: undefined, count: undefined,
msgs: [], msgs: [],
seq_no: pending_id++ seq_no: pendingId++
}; };
} }
var group = pending_in[id]; var group = pendingIn[id];
group.msgs.push(msg); group.msgs.push(msg);
pending_count++; pendingCount++;
var max_msgs = max_kept_msgs_count(node); var max_msgs = getMaxKeptCount();
if ((max_msgs > 0) && (pending_count > max_msgs)) { if ((max_msgs > 0) && (pendingCount > max_msgs)) {
clear_pending(); clearPending();
node.error(RED._("switch.errors.too-many"), msg); node.error(RED._("switch.errors.too-many"), msg);
} }
if (parts.hasOwnProperty("count")) { if (parts.hasOwnProperty("count")) {
@ -170,32 +170,29 @@ module.exports = function(RED) {
return group; return group;
} }
function del_group_in(id, group) {
pending_count -= group.msgs.length;
delete pending_in[id];
}
function add2pending_in(msg) { function addMessageToPending(msg) {
var parts = msg.parts; var parts = msg.parts;
if (parts.hasOwnProperty("id") && if (parts.hasOwnProperty("id") &&
parts.hasOwnProperty("index")) { parts.hasOwnProperty("index")) {
var group = add2group_in(parts.id, msg, parts); var group = addMessageToGroup(parts.id, msg, parts);
var msgs = group.msgs; var msgs = group.msgs;
var count = group.count; var count = group.count;
if (count === msgs.length) { if (count === msgs.length) {
for (var i = 0; i < msgs.length; i++) { for (var i = 0; i < msgs.length; i++) {
var msg = msgs[i]; var msg = msgs[i];
msg.parts.count = count; msg.parts.count = count;
process_msg(msg, false); processMessage(msg, false);
} }
del_group_in(parts.id, group); pendingCount -= group.msgs.length;
delete pendingIn[parts.id];
} }
return true; return true;
} }
return false; return false;
} }
function send_group(onwards, port_count) { function sendGroup(onwards, port_count) {
var counts = new Array(port_count).fill(0); var counts = new Array(port_count).fill(0);
for (var i = 0; i < onwards.length; i++) { for (var i = 0; i < onwards.length; i++) {
var onward = onwards[i]; var onward = onwards[i];
@ -230,47 +227,41 @@ module.exports = function(RED) {
} }
} }
function send2ports(onward, msg) { function sendMessages(onward, msg) {
var parts = msg.parts; var parts = msg.parts;
var gid = parts.id; var gid = parts.id;
received[gid] = ((gid in received) ? received[gid] : 0) +1; received[gid] = ((gid in received) ? received[gid] : 0) +1;
var send_ok = (received[gid] === parts.count); var send_ok = (received[gid] === parts.count);
if (!(gid in pending_out)) { if (!(gid in pendingOut)) {
pending_out[gid] = { pendingOut[gid] = {
onwards: [] onwards: []
}; };
} }
var group = pending_out[gid]; var group = pendingOut[gid];
var onwards = group.onwards; var onwards = group.onwards;
onwards.push(onward); onwards.push(onward);
pending_count++; pendingCount++;
if (send_ok) { if (send_ok) {
send_group(onwards, onward.length, msg); sendGroup(onwards, onward.length, msg);
pending_count -= onward.length; pendingCount -= onward.length;
delete pending_out[gid]; delete pendingOut[gid];
delete received[gid]; delete received[gid];
} }
var max_msgs = max_kept_msgs_count(node); var max_msgs = getMaxKeptCount();
if ((max_msgs > 0) && (pending_count > max_msgs)) { if ((max_msgs > 0) && (pendingCount > max_msgs)) {
clear_pending(); clearPending();
node.error(RED._("switch.errors.too-many"), msg); node.error(RED._("switch.errors.too-many"), msg);
} }
} }
function msg_has_parts(msg) { function processMessage(msg, check_parts) {
if (msg.hasOwnProperty("parts")) { var has_parts = msg.hasOwnProperty("parts") &&
var parts = msg.parts; msg.parts.hasOwnProperty("id") &&
return (parts.hasOwnProperty("id") && msg.parts.hasOwnProperty("index");
parts.hasOwnProperty("index"));
}
return false;
}
function process_msg(msg, check_parts) { if (needsCount && check_parts && has_parts &&
var has_parts = msg_has_parts(msg); addMessageToPending(msg)) {
if (needs_count && check_parts && has_parts &&
add2pending_in(msg)) {
return; return;
} }
var onward = []; var onward = [];
@ -344,27 +335,27 @@ module.exports = function(RED) {
node.send(onward); node.send(onward);
} }
else { else {
send2ports(onward, msg); sendMessages(onward, msg);
} }
} catch(err) { } catch(err) {
node.warn(err); node.warn(err);
} }
} }
function clear_pending() { function clearPending() {
pending_count = 0; pendingCount = 0;
pending_id = 0; pendingId = 0;
pending_in = {}; pendingIn = {};
pending_out = {}; pendingOut = {};
received = {}; received = {};
} }
this.on('input', function(msg) { this.on('input', function(msg) {
process_msg(msg, true); processMessage(msg, true);
}); });
this.on('close', function() { this.on('close', function() {
clear_pending(); clearPending();
}); });
} }