frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

Improve checks for missing _spec files

Browse Source
This commit is contained in:
Nick O'Leary 2018-01-16 13:15:47 +00:00
parent 3f5ba10354
commit 1f3f32d377
No known key found for this signature in database
GPG Key ID: 4F2157149161A6C9
1 changed files with 43 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

83
test/_spec.js
View File

@ -24,70 +24,61 @@
* TODO: Increase the scope of this check * TODO: Increase the scope of this check
*/ */
var fs = require("fs"); var fs = require("fs-extra");
var should = require("should"); var should = require("should");
var path = require('path'); var path = require('path');
// Directories to check with .js files and _spec.js files respectively // Directories to check with .js files and _spec.js files respectively
var rootdir = path.resolve(__dirname, "..");
var jsdir = path.resolve(__dirname, "../red"); var jsdir = path.resolve(__dirname, "../red");
var testdir = path.resolve(__dirname, "red"); var testdir = path.resolve(__dirname, "red");
var fs = require('fs'); var walkDirectory = function(dir) {
var walkDirectory = function(dir, topdir, done) { var p = fs.readdir(dir);
fs.readdir(dir, function(err, list) { var errors = [];
var error; return p.then(function(list) {
var errReturned = false; var promises = [];
if (err) { list.forEach(function(file) {
return done(err); var filePath = path.join(dir,file);
} promises.push(fs.stat(filePath).then(function(stat){
if (stat.isDirectory()) {
var i = 0; return walkDirectory(filePath).then(function(results) {
(function next() { if (results) {
var file = list[i++]; errors = errors.concat(results);
// return error if there are no more files to check and error has not been previously returned to avoid multiple calls to done()
if (!file) {
if (!errReturned) {
errReturned = true;
return done(error);
} }
});
} else if (/\.js$/.test(filePath)) {
var testFile = filePath.replace(jsdir, testdir).replace(".js", "_spec.js");
return fs.exists(testFile).then(function(exists) {
if (!exists) {
errors.push(testFile.substring(rootdir.length+1));
} else { } else {
file = path.resolve(dir, file); return fs.stat(testFile).then(function(stat) {
fs.stat(file, function(err, stat) { if (stat.size === 0) {
if (stat && stat.isDirectory()) { errors.push("[empty] "+testFile.substring(rootdir.length+1));
walkDirectory(file, false, function(err) {
if (!error) {
error = err;
}
next();
});
} else {
if (path.extname(file) === ".js") {
var testFile = file.replace(jsdir, testdir).replace(".js", "_spec.js");
fs.exists(testFile, function (exists) {
try {
exists.should.equal(true, testFile + " does not exist");
} catch (err) {
if (!topdir) {
return done(err);
} else {
error = err;
return;
} }
})
} }
}); });
} }
next(); }));
}
}); });
} return Promise.all(promises).then(function() {
})(); return errors;
})
}); });
}; }
describe('_spec.js', function() { describe('_spec.js', function() {
this.timeout(50000); // we might not finish within the Mocha default timeout limit, project will also grow this.timeout(50000); // we might not finish within the Mocha default timeout limit, project will also grow
it('is checking if all .js files have a corresponding _spec.js test file.', function(done) { it('is checking if all .js files have a corresponding _spec.js test file.', function(done) {
walkDirectory(jsdir, true, done); walkDirectory(jsdir).then(function(errors) {
if (errors.length > 0) {
var error = new Error("Missing/empty _spec files:\n\t"+errors.join("\n\t"));
done(error);
} else {
done();
}
});
}); });
}); });