From 6b3b68a4e5d7ad587b242231dd02281a02d9fc49 Mon Sep 17 00:00:00 2001 From: To-Thi Hoang Date: Fri, 30 Nov 2018 10:48:21 +0100 Subject: [PATCH] Diff panel DOM generation : Move generation of DOM for node properties to the click on the node row (instead of the diff panel opening). --- .../node_modules/@node-red/editor-client/src/js/ui/diff.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/diff.js b/packages/node_modules/@node-red/editor-client/src/js/ui/diff.js index c1255137c..c5a0b31fb 100644 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/diff.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/diff.js @@ -687,8 +687,7 @@ RED.diff = (function() { diff: remoteDiff } } - createNodePropertiesTable(def,node,localNode,remoteNode).appendTo(div); - + var selectState = ""; if (conflicted) { @@ -707,6 +706,10 @@ RED.diff = (function() { createNodeConflictRadioBoxes(node,div,localNodeDiv,remoteNodeDiv,false,!conflicted,selectState,CurrentDiff); row.click(function(evt) { $(this).parent().toggleClass('collapsed'); + + if($(this).siblings('.node-diff-node-entry-properties').length === 0) { + createNodePropertiesTable(def,node,localNode,remoteNode).appendTo(div); + } }); return div;