Improve error reporting when installing bad nodes

This commit is contained in:
Nick O'Leary
2021-09-30 15:28:09 +01:00
parent ec27e19e3f
commit 29e903e1c8
3 changed files with 32 additions and 11 deletions

View File

@@ -544,7 +544,8 @@
"nodeEnabled_plural": "Nodes enabled:",
"nodeDisabled": "Node disabled:",
"nodeDisabled_plural": "Nodes disabled:",
"nodeUpgraded": "Node module __module__ upgraded to version __version__"
"nodeUpgraded": "Node module __module__ upgraded to version __version__",
"unknownNodeRegistered": "Unrecognised node type registered: <ul><li>__type__</li></ul>"
},
"editor": {
"title": "Manage palette",

View File

@@ -142,9 +142,12 @@ RED.nodes = (function() {
RED.events.emit("registry:node-set-disabled",ns);
},
registerNodeType: function(nt,def) {
nodeDefinitions[nt] = def;
def.type = nt;
if (nt.substring(0,8) != "subflow:") {
if (!nodeSets[typeToId[nt]]) {
var fullType = (RED._loadingModule?("["+RED._loadingModule+"] "):"")+nt
RED.notify(RED._("palette.event.unknownNodeRegistered",{type:fullType}), "error");
return;
}
def.set = nodeSets[typeToId[nt]];
nodeSets[typeToId[nt]].added = true;
nodeSets[typeToId[nt]].enabled = true;
@@ -167,9 +170,13 @@ RED.nodes = (function() {
}
return result;
}
// TODO: too tightly coupled into palette UI
}
def.type = nt;
nodeDefinitions[nt] = def;
if (def.defaults) {
for (var d in def.defaults) {
if (def.defaults.hasOwnProperty(d)) {