frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

destroy editor to ensure fully removed on close (function, template, comment)

Browse Source 
to close #1279
This commit is contained in:
Dave Conway-Jones
2017-06-24 12:15:03 +01:00
parent e23354b2bb
commit 395210e4f0
4 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
nodes/core/core/80-function.html
View File

@@ -117,15 +117,17 @@
} }
} }
$("#node-input-func").val(this.editor.getValue()); $("#node-input-func").val(this.editor.getValue());
this.editor.destroy();
delete this.editor; delete this.editor;
}, },
oneditcancel: function() { oneditcancel: function() {
this.editor.destroy();
delete this.editor; delete this.editor;
}, },
oneditresize: function(size) { oneditresize: function(size) {
var rows = $("#dialog-form>div:not(.node-text-editor-row)"); var rows = $("#dialog-form>div:not(.node-text-editor-row)");
var height = $("#dialog-form").height(); var height = $("#dialog-form").height();
for (var i=0;i<rows.size();i++) { for (var i=0; i<rows.size(); i++) {
height -= $(rows[i]).outerHeight(true); height -= $(rows[i]).outerHeight(true);
} }
var editorRow = $("#dialog-form>div.node-text-editor-row"); var editorRow = $("#dialog-form>div.node-text-editor-row");

2
nodes/core/core/80-function.js
View File

@@ -26,7 +26,7 @@ module.exports = function(RED) {
msgs = [msgs]; msgs = [msgs];
} }
var msgCount = 0; var msgCount = 0;
for (var m=0;m<msgs.length;m++) { for (var m=0; m<msgs.length; m++) {
if (msgs[m]) { if (msgs[m]) {
if (!util.isArray(msgs[m])) { if (!util.isArray(msgs[m])) {
msgs[m] = [msgs[m]]; msgs[m] = [msgs[m]];

6
nodes/core/core/80-template.html
View File

@@ -133,16 +133,18 @@
}); });
}, },
oneditsave: function() { oneditsave: function() {
$("#node-input-template").val(this.editor.getValue()) $("#node-input-template").val(this.editor.getValue());
this.editor.destroy();
delete this.editor; delete this.editor;
}, },
oneditcancel: function() { oneditcancel: function() {
this.editor.destroy();
delete this.editor; delete this.editor;
}, },
oneditresize: function(size) { oneditresize: function(size) {
var rows = $("#dialog-form>div:not(.node-text-editor-row)"); var rows = $("#dialog-form>div:not(.node-text-editor-row)");
var height = $("#dialog-form").height(); var height = $("#dialog-form").height();
for (var i=0;i<rows.size();i++) { for (var i=0; i<rows.size(); i++) {
height -= $(rows[i]).outerHeight(true); height -= $(rows[i]).outerHeight(true);
} }
var editorRow = $("#dialog-form>div.node-text-editor-row"); var editorRow = $("#dialog-form>div.node-text-editor-row");

4
nodes/core/core/90-comment.html
View File

@@ -52,15 +52,17 @@
}, },
oneditsave: function() { oneditsave: function() {
$("#node-input-info").val(this.editor.getValue()); $("#node-input-info").val(this.editor.getValue());
this.editor.destroy();
delete this.editor; delete this.editor;
}, },
oneditcancel: function() { oneditcancel: function() {
this.editor.destroy();
delete this.editor; delete this.editor;
}, },
oneditresize: function(size) { oneditresize: function(size) {
var rows = $("#dialog-form>div:not(.node-text-editor-row)"); var rows = $("#dialog-form>div:not(.node-text-editor-row)");
var height = $("#dialog-form").height(); var height = $("#dialog-form").height();
for (var i=0;i<rows.size();i++) { for (var i=0; i<rows.size(); i++) {
height -= $(rows[i]).outerHeight(true); height -= $(rows[i]).outerHeight(true);
} }
var editorRow = $("#dialog-form>div.node-text-editor-row"); var editorRow = $("#dialog-form>div.node-text-editor-row");