frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not include payload in GET requests

Browse Source 
Fixes #1598

This regression was caused by #1531 - allowing the http request node
use any method.

The full fix is to identify which common verbs must not include a payload
and exclude them. GET needs fixing right now.
This commit is contained in:
Nick O'Leary 2018-01-31 23:39:26 +00:00
parent 3d8d6953ec
commit 3ec35ed119
No known key found for this signature in database
GPG Key ID: 4F2157149161A6C9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nodes/core/io/21-httprequest.js
View File

@ -135,7 +135,7 @@ module.exports = function(RED) {
} }
var payload = null; var payload = null;
if (typeof msg.payload !== "undefined") { if (method !== 'GET' && typeof msg.payload !== "undefined") {
if (typeof msg.payload === "string" || Buffer.isBuffer(msg.payload)) { if (typeof msg.payload === "string" || Buffer.isBuffer(msg.payload)) {
payload = msg.payload; payload = msg.payload;
} else if (typeof msg.payload == "number") { } else if (typeof msg.payload == "number") {