From a08c2c643794a208f89be4dcc26a1afd61ff32f2 Mon Sep 17 00:00:00 2001 From: Mauricio Bonani Date: Mon, 14 Oct 2019 15:13:59 -0400 Subject: [PATCH 01/66] Fix palette editor search visualization --- .../@node-red/editor-client/src/js/ui/palette-editor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/palette-editor.js b/packages/node_modules/@node-red/editor-client/src/js/ui/palette-editor.js index 074a54469..ee5221554 100644 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/palette-editor.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/palette-editor.js @@ -788,7 +788,7 @@ RED.palette.editor = (function() { initInstallTab(); }) - packageList = $('
    ',{style:"position: absolute;top: 78px;bottom: 0;left: 0;right: 0px;"}).appendTo(installTab).editableList({ + packageList = $('
      ',{style:"position: absolute;top: 79px;bottom: 0;left: 0;right: 0px;"}).appendTo(installTab).editableList({ addButton: false, scrollOnAdd: false, addItem: function(container,i,object) { From 56c41374bf7147b5093f187fcc4e5a192f8d91af Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Tue, 15 Oct 2019 16:50:16 +0900 Subject: [PATCH 02/66] Fix language handling in subflow node --- .../node_modules/@node-red/editor-client/src/js/ui/subflow.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/subflow.js b/packages/node_modules/@node-red/editor-client/src/js/ui/subflow.js index 5ea39be6a..c83a1dd8a 100644 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/subflow.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/subflow.js @@ -806,12 +806,12 @@ RED.subflow = (function() { locales.val(currentLocale); locales.on("change", function() { - currentLocale = $(this).val(); + var locale = $(this).val(); var items = $("#node-input-env-container").editableList("items"); items.each(function (i, item) { var entry = $(this).data('data'); var labelField = entry.ui.labelField; - labelField.val(lookupLabel(entry.ui.label, "", currentLocale)); + labelField.val(lookupLabel(entry.ui.label, "", locale)); if (labelField.timeout) { clearTimeout(labelField.timeout); delete labelField.timeout; From faf6fa945084a9bee3084d9d22dd6f867b8caa53 Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Wed, 16 Oct 2019 20:59:01 +0900 Subject: [PATCH 03/66] Fix copy and paste handling in subflow --- packages/node_modules/@node-red/editor-client/src/js/nodes.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/nodes.js b/packages/node_modules/@node-red/editor-client/src/js/nodes.js index d956684ce..5c0778fba 100644 --- a/packages/node_modules/@node-red/editor-client/src/js/nodes.js +++ b/packages/node_modules/@node-red/editor-client/src/js/nodes.js @@ -845,7 +845,7 @@ RED.nodes = (function() { var m = /^subflow:(.+)$/.exec(newNodes[i].type); if (m) { var subflowId = m[1]; - var parent = getSubflow(newNodes[i].z || activeWorkspace); + var parent = getSubflow(activeWorkspace); if (parent) { var err; if (subflowId === parent.id) { From e5c27d0236569192eb84b71d2e35e38c8f99663a Mon Sep 17 00:00:00 2001 From: TJKoury Date: Wed, 16 Oct 2019 20:00:11 -0400 Subject: [PATCH 04/66] Remove msg `msg` not defined in scope. --- packages/node_modules/@node-red/runtime/lib/nodes/Node.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node_modules/@node-red/runtime/lib/nodes/Node.js b/packages/node_modules/@node-red/runtime/lib/nodes/Node.js index c465f0b5b..d860fb5b0 100644 --- a/packages/node_modules/@node-red/runtime/lib/nodes/Node.js +++ b/packages/node_modules/@node-red/runtime/lib/nodes/Node.js @@ -224,7 +224,7 @@ Node.prototype._emitInput = function(arg) { } ); } catch(err) { - node.error(err,msg); + node.error(err); } } } From cb8deab1f99b5f7854450eb961d72587a556232a Mon Sep 17 00:00:00 2001 From: TJKoury Date: Thu, 17 Oct 2019 07:42:11 -0400 Subject: [PATCH 05/66] Update packages/node_modules/@node-red/runtime/lib/nodes/Node.js Co-Authored-By: Nick O'Leary --- packages/node_modules/@node-red/runtime/lib/nodes/Node.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node_modules/@node-red/runtime/lib/nodes/Node.js b/packages/node_modules/@node-red/runtime/lib/nodes/Node.js index d860fb5b0..d35ced395 100644 --- a/packages/node_modules/@node-red/runtime/lib/nodes/Node.js +++ b/packages/node_modules/@node-red/runtime/lib/nodes/Node.js @@ -224,7 +224,7 @@ Node.prototype._emitInput = function(arg) { } ); } catch(err) { - node.error(err); + node.error(err,arg); } } } From e10dd54e2b83030b79fdd40799568133787d25b4 Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Thu, 17 Oct 2019 21:05:06 +0900 Subject: [PATCH 06/66] Revert "Merge pull request #2328 from kazuhitoyokoi/master-fixsubflowlang" This reverts commit 873bdc673300f2bacfb1b3968f1328e241fa79c8, reversing changes made to 8a40b075b57bb792a5a3324416b6601c7e893b2d. --- .../node_modules/@node-red/editor-client/src/js/ui/subflow.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/subflow.js b/packages/node_modules/@node-red/editor-client/src/js/ui/subflow.js index c83a1dd8a..5ea39be6a 100644 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/subflow.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/subflow.js @@ -806,12 +806,12 @@ RED.subflow = (function() { locales.val(currentLocale); locales.on("change", function() { - var locale = $(this).val(); + currentLocale = $(this).val(); var items = $("#node-input-env-container").editableList("items"); items.each(function (i, item) { var entry = $(this).data('data'); var labelField = entry.ui.labelField; - labelField.val(lookupLabel(entry.ui.label, "", locale)); + labelField.val(lookupLabel(entry.ui.label, "", currentLocale)); if (labelField.timeout) { clearTimeout(labelField.timeout); delete labelField.timeout; From 78b735276b6fa3f37a35ecadab17fe19ec0704d3 Mon Sep 17 00:00:00 2001 From: Dave Conway-Jones Date: Thu, 17 Oct 2019 13:24:51 +0100 Subject: [PATCH 07/66] fix httprequest timeout units info to close #2333 --- .../@node-red/nodes/locales/en-US/network/21-httprequest.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node_modules/@node-red/nodes/locales/en-US/network/21-httprequest.html b/packages/node_modules/@node-red/nodes/locales/en-US/network/21-httprequest.html index fcc852c65..3daf92f49 100644 --- a/packages/node_modules/@node-red/nodes/locales/en-US/network/21-httprequest.html +++ b/packages/node_modules/@node-red/nodes/locales/en-US/network/21-httprequest.html @@ -36,7 +36,7 @@
      followRedirects
      If set to false prevent following Redirect (HTTP 301).true by default
      requestTimeout
      -
      If set to a positive number, will override the globally set httpRequestTimeout parameter.
      +
      If set to a positive number of milliseconds, will override the globally set httpRequestTimeout parameter.

      Outputs

      From dae9ac8173946bd0e776314e0f9cb5e2f9443556 Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Thu, 17 Oct 2019 21:24:55 +0900 Subject: [PATCH 08/66] Fix language handling in subflow node --- .../@node-red/editor-client/src/js/ui/subflow.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/subflow.js b/packages/node_modules/@node-red/editor-client/src/js/ui/subflow.js index 5ea39be6a..2646704ae 100644 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/subflow.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/subflow.js @@ -802,8 +802,8 @@ RED.subflow = (function() { } $("