frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix type checking in unit tests

Browse Source
This commit is contained in:
Nick O'Leary
2016-10-10 13:27:43 +01:00
parent eb1a597456
commit 42f7dc1947
28 changed files with 281 additions and 252 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
test/red/api/auth/permissions_spec.js
View File

@@ -20,37 +20,37 @@ var permissions = require("../../../../red/api/auth/permissions");
describe("Auth permissions", function() {
describe("hasPermission", function() {
it('a user with no permissions',function() {
permissions.hasPermission([],"*").should.be.false;
permissions.hasPermission([],"*").should.be.false();
});
it('a user with global permissions',function() {
permissions.hasPermission("*","read").should.be.true;
permissions.hasPermission(["*"],"write").should.be.true;
permissions.hasPermission("*","read").should.be.true();
permissions.hasPermission(["*"],"write").should.be.true();
});
it('a user with read permissions',function() {
permissions.hasPermission(["read"],"read").should.be.true;
permissions.hasPermission(["read"],"node.read").should.be.true;
permissions.hasPermission(["read"],"write").should.be.false;
permissions.hasPermission(["read"],"node.write").should.be.false;
permissions.hasPermission(["*.read"],"read").should.be.true;
permissions.hasPermission(["*.read"],"node.read").should.be.true;
permissions.hasPermission(["*.read"],"write").should.be.false;
permissions.hasPermission(["*.read"],"node.write").should.be.false;
permissions.hasPermission(["read"],"read").should.be.true();
permissions.hasPermission(["read"],"node.read").should.be.true();
permissions.hasPermission(["read"],"write").should.be.false();
permissions.hasPermission(["read"],"node.write").should.be.false();
permissions.hasPermission(["*.read"],"read").should.be.true();
permissions.hasPermission(["*.read"],"node.read").should.be.true();
permissions.hasPermission(["*.read"],"write").should.be.false();
permissions.hasPermission(["*.read"],"node.write").should.be.false();
});
it('a user with foo permissions',function() {
permissions.hasPermission("foo","foo").should.be.true;
permissions.hasPermission("foo","foo").should.be.true();
});
it('an array of permissions', function() {
permissions.hasPermission(["*"],["foo.read","foo.write"]).should.be.true;
permissions.hasPermission("read",["foo.read","foo.write"]).should.be.false;
permissions.hasPermission("read",["foo.read","bar.read"]).should.be.true;
permissions.hasPermission(["flows.read"],["flows.read"]).should.be.true;
permissions.hasPermission(["flows.read"],["flows.write"]).should.be.false;
permissions.hasPermission(["flows.read","nodes.write"],["flows.write"]).should.be.false;
permissions.hasPermission(["flows.read","nodes.write"],["nodes.write"]).should.be.true;
permissions.hasPermission(["*"],["foo.read","foo.write"]).should.be.true();
permissions.hasPermission("read",["foo.read","foo.write"]).should.be.false();
permissions.hasPermission("read",["foo.read","bar.read"]).should.be.true();
permissions.hasPermission(["flows.read"],["flows.read"]).should.be.true();
permissions.hasPermission(["flows.read"],["flows.write"]).should.be.false();
permissions.hasPermission(["flows.read","nodes.write"],["flows.write"]).should.be.false();
permissions.hasPermission(["flows.read","nodes.write"],["nodes.write"]).should.be.true();
});
it('permits an empty permission', function() {
permissions.hasPermission("*","").should.be.true;
permissions.hasPermission("read",[""]).should.be.true;
permissions.hasPermission("*","").should.be.true();
permissions.hasPermission("read",[""]).should.be.true();
});
});
});

12
test/red/api/auth/strategies_spec.js
View File

@@ -44,7 +44,7 @@ describe("Auth strategies", function() {
strategies.passwordTokenExchange({},"user","password","scope",function(err,token) {
try {
should.not.exist(err);
token.should.be.false;
token.should.be.false();
done();
} catch(e) {
done(e);
@@ -60,7 +60,7 @@ describe("Auth strategies", function() {
strategies.passwordTokenExchange({},"user","password","*",function(err,token) {
try {
should.not.exist(err);
token.should.be.false;
token.should.be.false();
done();
} catch(e) {
done(e);
@@ -138,7 +138,7 @@ describe("Auth strategies", function() {
strategies.bearerStrategy("1234",function(err,user) {
try {
should.not.exist(err);
user.should.be.false;
user.should.be.false();
done();
} catch(e) {
done(e);
@@ -221,7 +221,7 @@ describe("Auth strategies", function() {
strategies.clientPasswordStrategy(testClient.id,"invalid_secret",function(err,client) {
try {
should.not.exist(err);
client.should.be.false;
client.should.be.false();
done();
} catch(e) {
done(e);
@@ -237,7 +237,7 @@ describe("Auth strategies", function() {
strategies.clientPasswordStrategy("invalid_id","invalid_secret",function(err,client) {
try {
should.not.exist(err);
client.should.be.false;
client.should.be.false();
done();
} catch(e) {
done(e);
@@ -259,7 +259,7 @@ describe("Auth strategies", function() {
strategies.passwordTokenExchange({},"user","badpassword","scope",function(err,token) {
try {
err.toString().should.equal("Error: Too many login attempts. Wait 10 minutes and try again");
token.should.be.false;
token.should.be.false();
done();
} catch(e) {
done(e);

2
test/red/api/auth/tokens_spec.js
View File

@@ -79,7 +79,7 @@ describe("Tokens", function() {
Tokens.get("1234").then(function(token) {
try {
should.not.exist(token);
saveSessions.calledOnce.should.be.true;
saveSessions.calledOnce.should.be.true();
done();
} catch(err) {
done(err);

4
test/red/api/flow_spec.js
View File

@@ -162,7 +162,7 @@ describe("flow api", function() {
return done(err);
}
res.body.should.has.a.property('id','123');
nodes.updateFlow.calledOnce.should.be.true;
nodes.updateFlow.calledOnce.should.be.true();
nodes.updateFlow.lastCall.args[0].should.eql('123');
nodes.updateFlow.lastCall.args[1].should.eql({id:'123'});
nodes.updateFlow.restore();
@@ -247,7 +247,7 @@ describe("flow api", function() {
if (err) {
return done(err);
}
nodes.removeFlow.calledOnce.should.be.true;
nodes.removeFlow.calledOnce.should.be.true();
nodes.removeFlow.lastCall.args[0].should.eql('123');
nodes.removeFlow.restore();
done();

6
test/red/api/flows_spec.js
View File

@@ -119,7 +119,7 @@ describe("flows api", function() {
if (err) {
return done(err);
}
setFlows.calledOnce.should.be.true;
setFlows.calledOnce.should.be.true();
setFlows.lastCall.args[1].should.eql('full');
done();
});
@@ -141,7 +141,7 @@ describe("flows api", function() {
if (err) {
return done(err);
}
setFlows.calledOnce.should.be.true;
setFlows.calledOnce.should.be.true();
setFlows.lastCall.args[1].should.eql('nodes');
done();
});
@@ -254,7 +254,7 @@ describe("flows api", function() {
if (err) {
return done(err);
}
loadFlows.called.should.be.true;
loadFlows.called.should.be.true();
done();
});
});

2
test/red/api/index_spec.js
View File

@@ -119,7 +119,7 @@ describe("api index", function() {
return done(err);
}
res.text.should.eql("Not started");
errorLog.calledOnce.should.be.true;
errorLog.calledOnce.should.be.true();
done();
});
});

10
test/red/api/nodes_spec.js
View File

@@ -76,7 +76,7 @@ describe("nodes api", function() {
if (err) {
throw err;
}
res.body.should.be.an.Array;
res.body.should.be.an.Array();
res.body.should.have.lengthOf(3);
done();
});
@@ -583,8 +583,8 @@ describe("nodes api", function() {
if (err) {
throw err;
}
enableNodeCalled.should.be.false;
disableNodeCalled.should.be.false;
enableNodeCalled.should.be.false();
disableNodeCalled.should.be.false();
res.body.should.have.property("id","123");
res.body.should.have.property("enabled",state);
@@ -744,8 +744,8 @@ describe("nodes api", function() {
if (err) {
throw err;
}
enableNodeCalled.should.be.false;
disableNodeCalled.should.be.false;
enableNodeCalled.should.be.false();
disableNodeCalled.should.be.false();
res.body.should.have.property("name","node-red");
res.body.should.have.property("nodes");
res.body.nodes[0].should.have.property("enabled",state);

6
test/red/api/ui_spec.js
View File

@@ -95,7 +95,7 @@ describe("ui api", function() {
if (err){
return done(err);
}
Buffer.isBuffer(res.body).should.be.true;
Buffer.isBuffer(res.body).should.be.true();
compareBuffers(res.body,defaultIcon);
done();
});
@@ -112,7 +112,7 @@ describe("ui api", function() {
if (err){
return done(err);
}
Buffer.isBuffer(res.body).should.be.true;
Buffer.isBuffer(res.body).should.be.true();
compareBuffers(res.body,injectIcon);
done();
});
@@ -130,7 +130,7 @@ describe("ui api", function() {
if (err){
return done(err);
}
Buffer.isBuffer(res.body).should.be.true;
Buffer.isBuffer(res.body).should.be.true();
compareBuffers(res.body,testIcon);
done();
});