From 44b4c7da24e1a9aeb89d0dfba1ae08e8502d7889 Mon Sep 17 00:00:00 2001
From: GogoVega <92022724+GogoVega@users.noreply.github.com>
Date: Sun, 27 Oct 2024 13:26:47 +0100
Subject: [PATCH] Improve `getModuleListForNodes` + fix typo

---
 .../@node-red/editor-client/src/js/nodes.js    | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/packages/node_modules/@node-red/editor-client/src/js/nodes.js b/packages/node_modules/@node-red/editor-client/src/js/nodes.js
index 8f69f24b2..d676e0edb 100644
--- a/packages/node_modules/@node-red/editor-client/src/js/nodes.js
+++ b/packages/node_modules/@node-red/editor-client/src/js/nodes.js
@@ -3009,19 +3009,25 @@ RED.nodes = (function() {
      */
     function getModuleListForNodes(nodes) {
         const modules = {}
-        nodes.forEach(n => {
-            const nodeSet = RED.nodes.registry.getNodeSetForType(n.type)
-            if (nodeSet) {
-                modules[nodeSet.module] = nodeSet.version
+        const typeSet = new Set()
+        nodes.forEach((n) => {
+            if (!typeSet.has(n.type)) {
+                typeSet.add(n.type)
+                const nodeSet = RED.nodes.registry.getNodeSetForType(n.type)
+                if (nodeSet) {
+                    modules[nodeSet.module] = nodeSet.version
+                    nodeSet.types.forEach((t) => typeSet.add(t))
+                }
             }
         })
         return modules
     }
+
     function updateGlobalConfigModuleList(nodes) {
         const modules = getModuleListForNodes(nodes)
         delete modules['node-red']
         const hasModules = (Object.keys(modules).length > 0)
-        let globalConfigNode = nodes.find(n => n.type === 'global-config')
+        let globalConfigNode = nodes.find((n) => n.type === 'global-config')
         if (!globalConfigNode && hasModules) {
             globalConfigNode = {
                 id: RED.nodes.id(),
@@ -3030,7 +3036,7 @@ RED.nodes = (function() {
                 modules
             }
             nodes.push(globalConfigNode)
-        } else if (globalConfigNode) {
+        } else if (hasModules) {
             globalConfigNode.modules = modules
         }
     }