From 45afd060479ddf92690d36c082476456836a20c1 Mon Sep 17 00:00:00 2001
From: Nick O'Leary <nick.oleary@gmail.com>
Date: Wed, 17 Feb 2021 12:03:13 +0000
Subject: [PATCH] Prevent rogue mouseup on tab from triggering tab change

---
 .../@node-red/editor-client/src/js/ui/common/tabs.js      | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/common/tabs.js b/packages/node_modules/@node-red/editor-client/src/js/ui/common/tabs.js
index 1d6c75c32..baaac7a8b 100644
--- a/packages/node_modules/@node-red/editor-client/src/js/ui/common/tabs.js
+++ b/packages/node_modules/@node-red/editor-client/src/js/ui/common/tabs.js
@@ -29,6 +29,7 @@ RED.tabs = (function() {
         var currentTabWidth;
         var currentActiveTabWidth = 0;
         var collapsibleMenu;
+        var mousedownTab;
         var preferredOrder = options.order;
         var ul = options.element || $("#"+options.id);
         var wrapper = ul.wrap( "<div>" ).parent();
@@ -207,6 +208,11 @@ RED.tabs = (function() {
             if (dragActive) {
                 return
             }
+            if (evt.currentTarget !== mousedownTab) {
+                mousedownTab = null;
+                return;
+            }
+            mousedownTab = null;
             if (dblClickTime && Date.now()-dblClickTime < 400) {
                 dblClickTime = 0;
                 dblClickArmed = true;
@@ -445,6 +451,7 @@ RED.tabs = (function() {
         }
 
         ul.find("li.red-ui-tab a")
+            .on("mousedown", function(evt) { mousedownTab = evt.currentTarget })
             .on("mouseup",onTabClick)
             .on("click", function(evt) {evt.preventDefault(); })
             .on("dblclick", function(evt) {evt.stopPropagation(); evt.preventDefault(); })
@@ -636,6 +643,7 @@ RED.tabs = (function() {
                     }
 
                 }
+                link.on("mousedown", function(evt) { mousedownTab = evt.currentTarget })
                 link.on("mouseup",onTabClick);
                 link.on("click", function(evt) { evt.preventDefault(); })
                 link.on("dblclick", function(evt) { evt.stopPropagation(); evt.preventDefault(); })