From 5251e848b9d5914fe7e7f92a6968cf08968ad429 Mon Sep 17 00:00:00 2001
From: Nick O'Leary <nick.oleary@gmail.com>
Date: Mon, 24 Mar 2025 16:34:01 +0000
Subject: [PATCH] Properly handle scale factor in getLinksAtPoint for firefox

---
 .../@node-red/editor-client/src/js/ui/palette.js          | 2 +-
 .../@node-red/editor-client/src/js/ui/view.js             | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js b/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js
index be17776fa..5c9c9e5d2 100644
--- a/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js
+++ b/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js
@@ -401,7 +401,7 @@ RED.palette = (function() {
                                     } else {
                                         // Firefox doesn't do getIntersectionList and that
                                         // makes us sad
-                                        nodes = RED.view.getLinksAtPoint(mouseX,mouseY);
+                                        nodes = RED.view.getLinksAtPoint(mouseX / RED.view.scale(), mouseY / RED.view.scale());
                                     }
                                     var mx = mouseX / RED.view.scale();
                                     var my = mouseY / RED.view.scale();
diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/view.js b/packages/node_modules/@node-red/editor-client/src/js/ui/view.js
index 198af0850..e447d203f 100644
--- a/packages/node_modules/@node-red/editor-client/src/js/ui/view.js
+++ b/packages/node_modules/@node-red/editor-client/src/js/ui/view.js
@@ -1908,7 +1908,7 @@ RED.view = (function() {
                             } else {
                                 // Firefox doesn"t do getIntersectionList and that
                                 // makes us sad
-                                nodes = RED.view.getLinksAtPoint(mouseX*scaleFactor,mouseY*scaleFactor);
+                                nodes = RED.view.getLinksAtPoint(mouseX, mouseY);
                             }
                             for (var i=0;i<nodes.length;i++) {
                                 if (d3.select(nodes[i]).classed("red-ui-flow-link-background")) {
@@ -6333,6 +6333,12 @@ RED.view = (function() {
             var links = outer.selectAll(".red-ui-flow-link-background")[0];
             for (var i=0;i<links.length;i++) {
                 var bb = links[i].getBBox();
+                if (bb.height === 0) {
+                    // For horizontal links, add some real height to make them easier
+                    // to hit.
+                    bb.y -= Math.max(5, 5 / scaleFactor);
+                    bb.height = Math.max(10, 10 / scaleFactor);
+                }
                 if (x >= bb.x && y >= bb.y && x <= bb.x+bb.width && y <= bb.y+bb.height) {
                     result.push(links[i])
                 }