From 52e4e0e569f52c4f464adef150986c6c445073a9 Mon Sep 17 00:00:00 2001 From: Dave Conway-Jones Date: Tue, 11 Jan 2022 13:56:44 +0000 Subject: [PATCH] Fix for narrrowbandEq mode start condition failure And add test As discussed https://discourse.nodered.org/t/the-filter-node-or-the-old-rbe-node/56371 --- packages/node_modules/@node-red/nodes/core/function/rbe.js | 2 +- test/nodes/core/function/rbe_spec.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/node_modules/@node-red/nodes/core/function/rbe.js b/packages/node_modules/@node-red/nodes/core/function/rbe.js index 4548a8c6a..eb526a441 100644 --- a/packages/node_modules/@node-red/nodes/core/function/rbe.js +++ b/packages/node_modules/@node-red/nodes/core/function/rbe.js @@ -58,7 +58,7 @@ module.exports = function(RED) { else { var n = parseFloat(value); if (!isNaN(n)) { - if ((typeof node.previous[t] === 'undefined') && (this.func === "narrowband")) { + if ((typeof node.previous[t] === 'undefined') && (this.func === "narrowband" || this.func === "narrowbandEq")) { if (node.start === '') { node.previous[t] = n; } else { node.previous[t] = node.start; } } diff --git a/test/nodes/core/function/rbe_spec.js b/test/nodes/core/function/rbe_spec.js index 2ef005a27..56a93bdbf 100644 --- a/test/nodes/core/function/rbe_spec.js +++ b/test/nodes/core/function/rbe_spec.js @@ -425,7 +425,7 @@ describe('rbe node', function() { }); it('should not send output if x away or greater from original value (narrowbandEq)', function(done) { - var flow = [{"id":"n1", "type":"rbe", func:"narrowbandEq", gap:"10", inout:"out", wires:[["n2"]] }, + var flow = [{"id":"n1", "type":"rbe", func:"narrowbandEq", gap:"10", inout:"out", start:"1", wires:[["n2"]] }, {id:"n2", type:"helper"} ]; helper.load(testNode, flow, function() { var n1 = helper.getNode("n1"); @@ -445,6 +445,7 @@ describe('rbe node', function() { done(); } }); + n1.emit("input", {payload:100}); n1.emit("input", {payload:0}); n1.emit("input", {payload:10}); n1.emit("input", {payload:5});