From 53d8b97fff259b367dbe2a48bad577f7a65f1101 Mon Sep 17 00:00:00 2001 From: Dave Conway-Jones Date: Tue, 25 Jun 2024 12:57:09 +0100 Subject: [PATCH] join node - honour 3.x behaviour for old instances. but don't use msg.parts for new instances in manual join mode unless set. --- .../@node-red/nodes/core/sequence/17-split.html | 6 ++++++ .../node_modules/@node-red/nodes/core/sequence/17-split.js | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/node_modules/@node-red/nodes/core/sequence/17-split.html b/packages/node_modules/@node-red/nodes/core/sequence/17-split.html index db5853538..d19be77f5 100644 --- a/packages/node_modules/@node-red/nodes/core/sequence/17-split.html +++ b/packages/node_modules/@node-red/nodes/core/sequence/17-split.html @@ -266,6 +266,12 @@ }, oneditprepare: function() { var node = this; + $("#node-input-useparts").on("change", function(e) { + if (node.useparts === undefined) { + node.useparts = true; + $("#node-input-useparts").attr('checked', true); + } + }); $("#node-input-mode").on("change", function(e) { var val = $(this).val(); diff --git a/packages/node_modules/@node-red/nodes/core/sequence/17-split.js b/packages/node_modules/@node-red/nodes/core/sequence/17-split.js index aafdb6436..46ecb2636 100644 --- a/packages/node_modules/@node-red/nodes/core/sequence/17-split.js +++ b/packages/node_modules/@node-red/nodes/core/sequence/17-split.js @@ -444,7 +444,8 @@ module.exports = function(RED) { this.count = Number(n.count || 0); this.joiner = n.joiner||""; this.joinerType = n.joinerType||"str"; - this.useparts = n.useparts || false; + if (n.useparts === undefined) { this.useparts = true; } + else { this.useparts = n.useparts || false; } this.reduce = (this.mode === "reduce"); if (this.reduce) {