diff --git a/packages/node_modules/@node-red/nodes/core/network/31-tcpin.js b/packages/node_modules/@node-red/nodes/core/network/31-tcpin.js index 531b3ac2d..d2de33522 100644 --- a/packages/node_modules/@node-red/nodes/core/network/31-tcpin.js +++ b/packages/node_modules/@node-red/nodes/core/network/31-tcpin.js @@ -435,7 +435,7 @@ module.exports = function(RED) { }); } else { - var connectedSockets = []; + const connectedSockets = new Set(); node.status({text:RED._("tcpin.status.connections",{count:0})}); let srv = net; let connOpts; @@ -456,16 +456,16 @@ module.exports = function(RED) { }); socket.on('close',function() { node.log(RED._("tcpin.status.connection-closed",{host:socket.remoteAddress, port:socket.remotePort})); - connectedSockets.splice(connectedSockets.indexOf(socket),1); - node.status({text:RED._("tcpin.status.connections",{count:connectedSockets.length})}); + connectedSockets.delete(socket); + node.status({text:RED._("tcpin.status.connections",{count:connectedSockets.size})}); }); socket.on('error',function() { node.log(RED._("tcpin.errors.socket-error",{host:socket.remoteAddress, port:socket.remotePort})); - connectedSockets.splice(connectedSockets.indexOf(socket),1); - node.status({text:RED._("tcpin.status.connections",{count:connectedSockets.length})}); + connectedSockets.delete(socket); + node.status({text:RED._("tcpin.status.connections",{count:connectedSockets.size})}); }); - connectedSockets.push(socket); - node.status({text:RED._("tcpin.status.connections",{count:connectedSockets.length})}); + connectedSockets.add(socket); + node.status({text:RED._("tcpin.status.connections",{count:connectedSockets.size})}); }); node.on("input", function(msg, nodeSend, nodeDone) { @@ -478,10 +478,10 @@ module.exports = function(RED) { } else { buffer = Buffer.from(""+msg.payload); } - for (var i = 0; i < connectedSockets.length; i += 1) { - if (node.doend === true) { connectedSockets[i].end(buffer); } - else { connectedSockets[i].write(buffer); } - } + connectedSockets.forEach(soc => { + if (node.doend === true) { soc.end(buffer); } + else { soc.write(buffer); } + }) } nodeDone(); }); @@ -498,12 +498,10 @@ module.exports = function(RED) { } else { node.log(RED._("tcpin.status.listening-port",{port:node.port})); node.on('close', function() { - for (var c in connectedSockets) { - if (connectedSockets.hasOwnProperty(c)) { - connectedSockets[c].end(); - connectedSockets[c].unref(); - } - } + connectedSockets.forEach(soc => { + soc.end(); + soc.unref(); + }) server.close(); node.log(RED._("tcpin.status.stopped-listening",{port:node.port})); });