From 69f83cb905bfaa4e9c56bad40d7f40869e088e92 Mon Sep 17 00:00:00 2001
From: Dave Conway-Jones <conway@uk.ibm.com>
Date: Thu, 26 May 2016 10:38:24 +0100
Subject: [PATCH] fully log node warnings on start
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

(i.e. don’t need -v for simple errors on start)
---
 red/runtime/index.js                   | 23 +++++++++--------------
 red/runtime/locales/en-US/runtime.json |  2 +-
 2 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/red/runtime/index.js b/red/runtime/index.js
index 5bf9a2f0e..5dbe34130 100644
--- a/red/runtime/index.js
+++ b/red/runtime/index.js
@@ -34,17 +34,17 @@ var stubbedExpressApp = {
     get: function() {},
     post: function() {},
     put: function() {},
-    delete: function(){}
+    delete: function() {}
 }
 var adminApi = {
     library: {
-        register: function(){}
+        register: function() {}
     },
     auth: {
-        needsPermission: function(){}
+        needsPermission: function() {}
     },
     comms: {
-        publish: function(){}
+        publish: function() {}
     },
     adminApp: stubbedExpressApp,
     nodeApp: stubbedExpressApp,
@@ -105,16 +105,11 @@ function start() {
                 var nodeErrors = redNodes.getNodeList(function(n) { return n.err!=null;});
                 var nodeMissing = redNodes.getNodeList(function(n) { return n.module && n.enabled && !n.loaded && !n.err;});
                 if (nodeErrors.length > 0) {
-                    log.warn("------------------------------------------");
-                    if (settings.verbose) {
-                        for (i=0;i<nodeErrors.length;i+=1) {
-                            log.warn("["+nodeErrors[i].name+"] "+nodeErrors[i].err);
-                        }
-                    } else {
-                        log.warn(log._("server.errors",{count:nodeErrors.length}));
-                        log.warn(log._("server.errors-help"));
+                    log.warn("------------------------------------------------------");
+                    for (i=0;i<nodeErrors.length;i+=1) {
+                        log.warn("["+nodeErrors[i].name+"] "+nodeErrors[i].err);
                     }
-                    log.warn("------------------------------------------");
+                    log.warn("------------------------------------------------------");
                 }
                 if (nodeMissing.length > 0) {
                     log.warn(log._("server.missing-modules"));
@@ -148,7 +143,7 @@ function start() {
             }).otherwise(function(err) {
                 console.log(err);
             });
-    });
+        });
 }
 
 function reportMetrics() {
diff --git a/red/runtime/locales/en-US/runtime.json b/red/runtime/locales/en-US/runtime.json
index 767778292..07dabc7b1 100644
--- a/red/runtime/locales/en-US/runtime.json
+++ b/red/runtime/locales/en-US/runtime.json
@@ -120,7 +120,7 @@
         },
         "localfilesystem": {
             "user-dir": "User directory : __path__",
-            "flows-file": "Flows file : __path__",
+            "flows-file": "Flows file     : __path__",
             "create": "Creating new flow file",
             "empty": "Existing flow file is empty",
             "invalid": "Existing flow file is not valid json",