boost api index, nodes index and nodes Node test coverage

test/red/api/index_spec.js

@@ -19,24 +19,22 @@ var request = require("supertest");
 var express = require("express");
 var fs = require("fs");
 var path = require("path");
-
 var settings = require("../../../red/settings");
 var api = require("../../../red/api");
 
-
 describe("api index", function() {
     var app;
-    
+
     describe("disables editor", function() {
         before(function() {
-            settings.init({disableEditor:true});
+            settings.init({disableEditor:true,adminAuth:{type: "credentials",users:[],default:{permissions:"read"}}});
             app = express();
             api.init(app);
         });
         after(function() {
             settings.reset();
         });
-        
+
         it('does not serve the editor', function(done) {
             request(app)
                 .get("/")
@@ -53,7 +51,7 @@ describe("api index", function() {
                 .expect(200,done)
         });
     });
-    
+
     describe("enables editor", function() {
         before(function() {
             settings.init({disableEditor:false});
@@ -63,7 +61,7 @@ describe("api index", function() {
         after(function() {
             settings.reset();
         });
-        
+
         it('serves the editor', function(done) {
             request(app)
                 .get("/")
@@ -88,5 +86,10 @@ describe("api index", function() {
                 .get("/settings")
                 .expect(200,done)
         });
+        it('handles page not there', function(done) {
+            request(app)
+                .get("/foo")
+                .expect(404,done)
+        });
     });
-});
+});

test/red/log_spec.js

@@ -23,7 +23,7 @@ describe("red/log", function() {
     });
 
     var log = require("../../red/log");
-    var sett = {logging: { console: { level: 'metric', metrics: true } } }
+    var sett = {logging: { console: { level: 'metric', metrics: true } } };
     log.init(sett);
 
     beforeEach(function () {

test/red/nodes/Node_spec.js

@@ -417,14 +417,13 @@ describe('Node', function() {
             });
             
             var message = {a:1};
-            
-            n.error("an error message",message);
-            should.deepEqual({level:Log.ERROR, id:n.id,
-                             type:n.type, msg:"an error message"}, loginfo);
-            
+
+            n.error(null,message);
+            should.deepEqual({level:Log.ERROR, id:n.id, type:n.type, msg:""}, loginfo);
+
             flows.handleError.called.should.be.true;
             flows.handleError.args[0][0].should.eql(n);
-            flows.handleError.args[0][1].should.eql("an error message");
+            flows.handleError.args[0][1].should.eql("");
             flows.handleError.args[0][2].should.eql(message);
             
             Log.log.restore();
@@ -448,8 +447,22 @@ describe('Node', function() {
             done();
         });
     });
-    
-    
+
+    describe('#metric', function() {
+        it('returns metric value if eventname undefined', function(done) {
+            var n = new RedNode({id:'123',type:'abc'});
+            var loginfo = {};
+            sinon.stub(Log, 'log', function(msg) {
+                loginfo = msg;
+            });
+            var msg = {payload:"foo", _msgid:"987654321"};
+            var m = n.metric(undefined,msg,"15mb");
+            m.should.equal(true);
+            Log.log.restore();
+            done();
+        });
+    });
+
     describe('#status', function() {
         after(function() {
             comms.publish.restore();

test/red/nodes/index_spec.js

@@ -58,7 +58,6 @@ describe("red/nodes/index", function() {
     }
 
    it('nodes are initialised with credentials',function(done) {
-
         index.init(settings, storage);
         index.registerType('test', TestNode);
         index.loadFlows().then(function() {
@@ -69,7 +68,6 @@ describe("red/nodes/index", function() {
         }).otherwise(function(err) {
             done(err);
         });
-
     });
 
    it('flows should be initialised',function(done) {
@@ -128,7 +126,7 @@ describe("red/nodes/index", function() {
                    foo: {type:"test"}
                }
            });
-           var testnode = new TestNode({id:'tab1',type:'test',name:'barney'});
+           var testnode = new TestNode({id:'tab1',type:'test',name:'barney', '_alias':'tab1'});
            credentials.getDefinition("test").should.have.property('foo');
            done();
        });