From 6c2de40dba21d0f08b6745b455502bd273275b8b Mon Sep 17 00:00:00 2001
From: Nick O'Leary <nick.oleary@gmail.com>
Date: Mon, 5 Jun 2017 11:33:24 +0100
Subject: [PATCH] Add cookie handling to HTTP Request node

---
 nodes/core/io/21-httprequest.html |  9 ++++++++
 nodes/core/io/21-httprequest.js   | 37 +++++++++++++++++++++++++++++++
 package.json                      |  1 +
 3 files changed, 47 insertions(+)

diff --git a/nodes/core/io/21-httprequest.html b/nodes/core/io/21-httprequest.html
index bd157a9ff..7beffe261 100644
--- a/nodes/core/io/21-httprequest.html
+++ b/nodes/core/io/21-httprequest.html
@@ -81,6 +81,8 @@
             Must be one of <code>GET</code>, <code>PUT</code>, <code>POST</code>, <code>PATCH</code> or <code>DELETE</code>.</dd>
         <dt class="optional">headers <span class="property-type">object</span></dt>
         <dd>Sets the HTTP headers of the request.</dd>
+        <dt class="optional">cookies <span class="property-type">object</span></dt>
+        <dd>If set, can be used to send cookies with the request.</dd>
         <dt class="optional">payload</dt>
         <dd>Sent as the body of the request.</dd>
     </dl>
@@ -97,6 +99,8 @@
         <dt>responseUrl <span class="property-type">string</span></dt>
         <dd>In case any redirects occurred while processing the request, this property is the final redirected url.
             Otherwise, the url of the original request.</dd>
+        <dt>responseCookies <span class="property-type">object</span></dt>
+        <dd>If the response includes cookies, this propery is an object of name/value pairs for each cookie.</dd>
     </dl>
     <h3>Details</h3>
     <p>When configured within the node, the URL property can contain <a href="http://mustache.github.io/mustache.5.html" target="_blank">mustache-style</a> tags. These allow the
@@ -104,6 +108,11 @@
     <code>example.com/{{{topic}}}</code>, it will have the value of <code>msg.topic</code> automatically inserted.
     Using {{{...}}} prevents mustache from escaping characters like / & etc.</p>
     <p><b>Note</b>: If running behind a proxy, the standard <code>http_proxy=...</code> environment variable should be set and Node-RED restarted.</p>
+    <h4>Cookie handling</h4>
+    <p>The <code>cookies</code> property passed to the node must be an object of name/value pairs.
+    The value can be either a string to set the value of the cookie or it can be an
+    object with a single <code>value</code> property.<p>
+    <p>Any cookies returned by the request are passed back under the <code>responseCookies</code> property.</p>
 </script>
 
 <script type="text/javascript">
diff --git a/nodes/core/io/21-httprequest.js b/nodes/core/io/21-httprequest.js
index 582196c08..f38b8eecc 100644
--- a/nodes/core/io/21-httprequest.js
+++ b/nodes/core/io/21-httprequest.js
@@ -21,6 +21,7 @@ module.exports = function(RED) {
     var urllib = require("url");
     var mustache = require("mustache");
     var querystring = require("querystring");
+    var cookie = require("cookie");
 
     function HTTPRequest(n) {
         RED.nodes.createNode(this,n);
@@ -96,6 +97,28 @@ module.exports = function(RED) {
                     }
                 }
             }
+            if (msg.cookies) {
+                var cookies = [];
+                if (opts.headers.hasOwnProperty('cookie')) {
+                    cookies.push(opts.headers.cookie);
+                }
+
+                for (var name in msg.cookies) {
+                    if (msg.cookies.hasOwnProperty(name)) {
+                        if (msg.cookies[name] === null || msg.cookies[name].value === null) {
+                            // This case clears a cookie for HTTP In/Response nodes.
+                            // Ignore for this node.
+                        } else if (typeof msg.cookies[name] === 'object') {
+                            cookies.push(cookie.serialize(name,msg.cookies[name].value));
+                        } else {
+                            cookies.push(cookie.serialize(name,msg.cookies[name]));
+                        }
+                    }
+                }
+                if (cookies.length > 0) {
+                    opts.headers.cookie = cookies.join("; ");
+                }
+            }
             if (this.credentials && this.credentials.user) {
                 opts.auth = this.credentials.user+":"+(this.credentials.password||"");
             }
@@ -171,6 +194,20 @@ module.exports = function(RED) {
                 msg.responseUrl = res.responseUrl;
                 msg.payload = [];
 
+                if (msg.headers.hasOwnProperty('set-cookie')) {
+                    msg.responseCookies = {};
+                    msg.headers['set-cookie'].forEach(function(c) {
+                        var parsedCookie = cookie.parse(c);
+                        var eq_idx = c.indexOf('=');
+                        var key = c.substr(0, eq_idx).trim()
+                        parsedCookie.value = parsedCookie[key];
+                        delete parsedCookie[key];
+                        msg.responseCookies[key] = parsedCookie;
+
+                    })
+
+                }
+
                 // msg.url = url;   // revert when warning above finally removed
                 res.on('data',function(chunk) {
                     if (!Buffer.isBuffer(chunk)) {
diff --git a/package.json b/package.json
index 348500054..9e8190709 100644
--- a/package.json
+++ b/package.json
@@ -31,6 +31,7 @@
         "body-parser": "1.15.2",
         "cheerio":"0.22.0",
         "clone": "2.1.0",
+        "cookie": "0.3.1",
         "cookie-parser": "1.4.3",
         "cors":"2.8.1",
         "cron":"1.2.1",