From a1a6f4015881c197b3facaac4308603e06f072ce Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Fri, 16 Jul 2021 10:16:09 +0100 Subject: [PATCH 1/6] Update issue templates to use GH forms --- .github/ISSUE_TEMPLATE/--bug_report.md | 39 ------------------ .github/ISSUE_TEMPLATE/-anything-else.md | 17 -------- .github/ISSUE_TEMPLATE/bug_report.yml | 52 ++++++++++++++++++++++++ .github/ISSUE_TEMPLATE/config.yml | 14 +++++++ 4 files changed, 66 insertions(+), 56 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/--bug_report.md delete mode 100644 .github/ISSUE_TEMPLATE/-anything-else.md create mode 100644 .github/ISSUE_TEMPLATE/bug_report.yml create mode 100644 .github/ISSUE_TEMPLATE/config.yml diff --git a/.github/ISSUE_TEMPLATE/--bug_report.md b/.github/ISSUE_TEMPLATE/--bug_report.md deleted file mode 100644 index 7cdc9caad..000000000 --- a/.github/ISSUE_TEMPLATE/--bug_report.md +++ /dev/null @@ -1,39 +0,0 @@ ---- -name: Bug report -about: Reproducible software issues in the core of Node-RED -title: '' -labels: '' -assignees: '' - ---- - - - -### What are the steps to reproduce? - -### What happens? - -### What do you expect to happen? - -### Please tell us about your environment: - -- [ ] Node-RED version: -- [ ] Node.js version: -- [ ] npm version: -- [ ] Platform/OS: -- [ ] Browser: diff --git a/.github/ISSUE_TEMPLATE/-anything-else.md b/.github/ISSUE_TEMPLATE/-anything-else.md deleted file mode 100644 index 836c78967..000000000 --- a/.github/ISSUE_TEMPLATE/-anything-else.md +++ /dev/null @@ -1,17 +0,0 @@ ---- -name: Anything Else -about: Something that is not a bug report -title: '' -labels: '' -assignees: '' - ---- - -Please DO NOT raise an issue. - -We DO NOT use the issue tracker for general support or feature requests. Only bug reports should be raised here using the 'Bug report' template. - -For general support, please use the [Node-RED Forum](https://discourse.nodered.org) or [slack team](https://nodered.org/slack). You could also consider asking a question on [Stack Overflow](https://stackoverflow.com/questions/tagged/node-red) and tag it `node-red`. -That way the whole Node-RED user community can help, rather than rely on the core development team. - -For feature requests, please use the Node-RED Forum](https://discourse.nodered.org). Many ideas have already been discussed there and you should search that for your request before starting a new discussion. diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml new file mode 100644 index 000000000..53f7a2502 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -0,0 +1,52 @@ +name: 🐞 Report a bug +description: File a bug/issue on the core of Node-RED +title: "" +labels: [needs-triage] +body: +- type: checkboxes + attributes: + label: Is this an issue with the core of Node-RED? + description: This issue list is for the core runtime and editor of Node-RED. If your issue is about a 3rd-party node, please use the [forum](https://discourse.nodered.org) + options: + - label: Yes + required: true +- type: textarea + attributes: + label: Current Behavior + description: A clear & concise description of what you're experiencing. + validations: + required: false +- type: textarea + attributes: + label: Expected Behavior + description: A clear & concise description of what you expected to happen. + validations: + required: false +- type: textarea + attributes: + label: Steps To Reproduce + description: Steps to reproduce the behavior. + validations: + required: false +- type: textarea + attributes: + label: Example flow + description: If you have a minimal example flow that demonstrates the issue, share it here. + value: | + ``` + paste your flow here + ``` + validations: + required: false +- type: textarea + attributes: + label: Environment + description: Please tell us about your environment. Include any relevant information on how you are running Node-RED. + value: | + - Node-RED version: + - Node.js version: + - npm version: + - Platform/OS: + - Browser: + validations: + required: false diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 000000000..6ca453154 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1,14 @@ +blank_issues_enabled: true +contact_links: + - name: ❓ Questions + url: https://discourse.nodered.org + about: Ask you question on the Node-RED forum + - name: ⭐️ Feature Request + url: https://discourse.nodered.org/c/development/feature-requests + about: Discuss you request with the community + - name: 🗂 Documentation + url: https://nodered.org/docs + about: Go straight to the documentation + - name: 💬 Slack + url: https://nodered.org/slack + about: Chat about the project on our slack team From 77fd8c120cc4f53587e2c719486bd778731ca34d Mon Sep 17 00:00:00 2001 From: Nick O'Leary <nick.oleary@gmail.com> Date: Fri, 16 Jul 2021 10:20:23 +0100 Subject: [PATCH 2/6] Update bug_report.yml --- .github/ISSUE_TEMPLATE/bug_report.yml | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 53f7a2502..1939d1681 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -3,13 +3,23 @@ description: File a bug/issue on the core of Node-RED title: "<title>" labels: [needs-triage] body: -- type: checkboxes +- type: markdown attributes: - label: Is this an issue with the core of Node-RED? - description: This issue list is for the core runtime and editor of Node-RED. If your issue is about a 3rd-party node, please use the [forum](https://discourse.nodered.org) - options: - - label: Yes - required: true + value: | + This issue tracker is for problems with the Node-RED runtime, the editor or the core nodes. + + If your issue is: + - a general 'how-to' type question, + - a feature request or suggestion for a change, + - or problems with 3rd party (`node-red-contrib-`) nodes + + please use the [Node-RED Forum](https://discourse.nodered.org) or [slack team](https://nodered.org/slack). + + You could also consider asking a question on [Stack Overflow](https://stackoverflow.com/questions/tagged/node-red) and tag it `node-red`. + + That way the whole Node-RED user community can help, rather than rely on the core development team. + + To help us understand the issue, please fill-in as much of the following information as you can: - type: textarea attributes: label: Current Behavior From 47f7b43bccd1819897f5575e331472bcb2224ca5 Mon Sep 17 00:00:00 2001 From: Nick O'Leary <nick.oleary@gmail.com> Date: Fri, 16 Jul 2021 10:21:51 +0100 Subject: [PATCH 3/6] Update bug_report.yml --- .github/ISSUE_TEMPLATE/bug_report.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 1939d1681..9f805581a 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,6 +1,5 @@ name: 🐞 Report a bug description: File a bug/issue on the core of Node-RED -title: "<title>" labels: [needs-triage] body: - type: markdown From d14ce7e4762d4a3b4887ca321d36dd4644736cc3 Mon Sep 17 00:00:00 2001 From: Nick O'Leary <nick.oleary@gmail.com> Date: Fri, 16 Jul 2021 12:30:21 +0100 Subject: [PATCH 4/6] Fix typo in issue template --- .github/ISSUE_TEMPLATE.md | 35 ------------------------------- .github/ISSUE_TEMPLATE/config.yml | 2 +- 2 files changed, 1 insertion(+), 36 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md deleted file mode 100644 index bdb978517..000000000 --- a/.github/ISSUE_TEMPLATE.md +++ /dev/null @@ -1,35 +0,0 @@ -<!-- -## Before you hit that Submit button.... - -This issue tracker is for problems with the Node-RED runtime, the editor or the core nodes. - -If your issue is: - - a general 'how-to' type question, - - a feature request or suggestion for a change, - - or problems with 3rd party (`node-red-contrib-`) nodes - -please use the [Node-RED Forum](https://discourse.nodered.org) or [slack team](https://nodered.org/slack). - -You could also consider asking a question on [Stack Overflow](https://stackoverflow.com/questions/tagged/node-red) and tag it `node-red`. - -That way the whole Node-RED user community can help, rather than rely on the core development team. - -## So you have a real issue to raise... - -To help us understand the issue, please fill-in as much of the following information as you can: ---> - -### What are the steps to reproduce? - -### What happens? - -### What do you expect to happen? - -### Please tell us about your environment: - -- [ ] Node-RED version: -- [ ] Node.js version: -- [ ] npm version: -- [ ] Platform/OS: -- [ ] Browser: -- [ ] running in Docker: diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 6ca453154..04e2179b6 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -2,7 +2,7 @@ blank_issues_enabled: true contact_links: - name: ❓ Questions url: https://discourse.nodered.org - about: Ask you question on the Node-RED forum + about: Ask your question on the Node-RED forum - name: ⭐️ Feature Request url: https://discourse.nodered.org/c/development/feature-requests about: Discuss you request with the community From bcb3371accec53de3872c4e05839eef966bf30cf Mon Sep 17 00:00:00 2001 From: Nick O'Leary <nick.oleary@gmail.com> Date: Fri, 16 Jul 2021 12:34:54 +0100 Subject: [PATCH 5/6] Fix another typo in issue template --- .github/ISSUE_TEMPLATE/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 04e2179b6..35dfde04b 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -5,7 +5,7 @@ contact_links: about: Ask your question on the Node-RED forum - name: ⭐️ Feature Request url: https://discourse.nodered.org/c/development/feature-requests - about: Discuss you request with the community + about: Discuss your request with the community - name: 🗂 Documentation url: https://nodered.org/docs about: Go straight to the documentation From 77ee726f668d658fca57e177bfb7f8904b3598cc Mon Sep 17 00:00:00 2001 From: Nick O'Leary <nick.oleary@gmail.com> Date: Tue, 20 Jul 2021 11:02:24 +0100 Subject: [PATCH 6/6] Fix focus outline overlap in button-groups Fixes #3070 --- .../node_modules/@node-red/editor-client/src/sass/mixins.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/node_modules/@node-red/editor-client/src/sass/mixins.scss b/packages/node_modules/@node-red/editor-client/src/sass/mixins.scss index dda9ef384..9214ea37b 100644 --- a/packages/node_modules/@node-red/editor-client/src/sass/mixins.scss +++ b/packages/node_modules/@node-red/editor-client/src/sass/mixins.scss @@ -99,6 +99,9 @@ border-bottom-left-radius: 0; border-bottom-right-radius: 0; } + .button-group &:focus { + position: relative; + } .button-row &:not(:first-child) { margin-left: 15px; @@ -106,6 +109,7 @@ &:focus { outline: 1px solid $workspace-button-color-focus-outline; + outline-offset: 1px; } &.primary {