frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

Add validation of library plugin id and better error reporting

Browse Source
This commit is contained in:
Nick O'Leary 2021-02-19 14:39:42 +00:00
parent c2347076f4
commit 6f9e06e78d
No known key found for this signature in database
GPG Key ID: 4F2157149161A6C9
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/node_modules/@node-red/runtime/lib/library/index.js vendored
View File

@ -38,6 +38,11 @@ function init(runtime) {
runtimeLibraries.forEach(library => { runtimeLibraries.forEach(library => {
if (library.type === id) { if (library.type === id) {
library.local = false; library.local = false;
if (!/^[a-z0-9-_]+$/.test(library.id)) {
log.warn(log._("library.failedToInit",{error:log._("library.invalidProperty",{prop:"id",value:library.id})}));
return;
}
try { try {
libraries[library.id] = new plugin.class(library) libraries[library.id] = new plugin.class(library)
libraryConfigs[library.id] = library; libraryConfigs[library.id] = library;

3
packages/node_modules/@node-red/runtime/locales/en-US/runtime.json vendored
View File

@ -93,7 +93,8 @@
"unknownLibrary": "Unknown library: __library__", "unknownLibrary": "Unknown library: __library__",
"unknownType": "Unknown library type: __type__", "unknownType": "Unknown library type: __type__",
"readOnly": "Library __library__ is read-only", "readOnly": "Library __library__ is read-only",
"failedToInit": "Failed to initialise __library__: __error__" "failedToInit": "Failed to initialise library __library__: __error__",
"invalidProperty": "Invalid property __prop__: '__value__'"
}, },
"nodes": { "nodes": {
"credentials": { "credentials": {