From 70cf7b0c5a49ebb07b5c8dc26c3c4b8b7ce9dc31 Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Fri, 14 Jun 2019 11:18:07 +0100 Subject: [PATCH] Do not save subflow env vars with blank names --- .../editor-client/src/js/ui/editor.js | 24 ++++++++++--------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/editor.js b/packages/node_modules/@node-red/editor-client/src/js/ui/editor.js index a50545dcb..b64bb8e5c 100644 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/editor.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/editor.js @@ -667,17 +667,19 @@ RED.editor = (function() { list.each(function(i) { var entry = $(this); var item = entry.data('data'); - var name = item.parent?item.name:entry.find(".node-input-env-name").val(); - var valueInput = entry.find(".node-input-env-value"); - var value = valueInput.typedInput("value"); - var type = valueInput.typedInput("type"); - if (!item.parent || (item.parent.value !== value || item.parent.type !== type)) { - var item = { - name: name, - type: type, - value: value - }; - env.push(item); + var name = (item.parent?item.name:entry.find(".node-input-env-name").val()).trim(); + if (name !== "") { + var valueInput = entry.find(".node-input-env-value"); + var value = valueInput.typedInput("value"); + var type = valueInput.typedInput("type"); + if (!item.parent || (item.parent.value !== value || item.parent.type !== type)) { + var item = { + name: name, + type: type, + value: value + }; + env.push(item); + } } }); return env;