frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tidy up all console.log util.log from core nodes.

Browse Source 
Try to make log,warn,error more consistent behaviour.

Especially make sure any existing catches produce errors
This commit is contained in:
dceejay
2015-02-25 19:10:44 +00:00
parent b6245bdef7
commit 71ff828947
13 changed files with 54 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
nodes/core/io/25-serial.js
View File

@@ -174,7 +174,7 @@ module.exports = function(RED) {
i = 0;
}
}
else { console.log("Should never get here"); }
else { node.log("should never get here"); }
}
});
this.port.on('ready', function() {
@@ -235,7 +235,7 @@ module.exports = function(RED) {
// },true, function(err, results) { if (err) obj.serial.emit('error',err); });
//}
obj.serial.on('error', function(err) {
util.log("[serial] serial port "+port+" error "+err);
RED.log.error("serial port "+port+" error "+err);
obj._emitter.emit('closed');
obj.tout = setTimeout(function() {
setupSerial();
@@ -243,7 +243,7 @@ module.exports = function(RED) {
});
obj.serial.on('close', function() {
if (!obj._closing) {
util.log("[serial] serial port "+port+" closed unexpectedly");
RED.log.error("serial port "+port+" closed unexpectedly");
obj._emitter.emit('closed');
obj.tout = setTimeout(function() {
setupSerial();
@@ -251,7 +251,7 @@ module.exports = function(RED) {
}
});
obj.serial.on('open',function() {
util.log("[serial] serial port "+port+" opened at "+baud+" baud "+databits+""+parity.charAt(0).toUpperCase()+stopbits);
RED.log.info("serial port "+port+" opened at "+baud+" baud "+databits+""+parity.charAt(0).toUpperCase()+stopbits);
if (obj.tout) { clearTimeout(obj.tout); }
//obj.serial.flush();
obj._emitter.emit('ready');
@@ -269,7 +269,7 @@ module.exports = function(RED) {
//}
});
obj.serial.on("disconnect",function() {
util.log("[serial] serial port "+port+" gone away");
RED.log.error("serial port "+port+" gone away");
});
}
setupSerial();
@@ -286,7 +286,7 @@ module.exports = function(RED) {
connections[port]._closing = true;
try {
connections[port].close(function() {
util.log("[serial] serial port closed");
RED.log.info("serial port closed");
done();
});
}

4
nodes/core/io/32-udp.js
View File

@@ -81,7 +81,9 @@ module.exports = function(RED) {
}
});
server.bind(node.port,node.iface);
// Hack for when you have both in and out udp nodes sharing a port
// if udp in starts last it shares better - so give it a chance to be last
setTimeout( function() { server.bind(node.port,node.iface); }, 250);;
}
RED.nodes.registerType("udp in",UDPin);