frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Code Issues Releases Wiki Activity

Handle Buffer objects properly in Serial out node

Browse Source 
Fixes #115
The serial out node does a JSON.stringify if the payload is an object. This was incorrectly being applied to Buffer objects, causing the output seen in issue #115.

The Buffer is now passed through as-is (with the newline appended if so configured).
This commit is contained in:
Nick O'Leary 2013-12-13 10:27:52 +00:00
parent 344660dfee
commit 751ac7b9ee
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
nodes/core/io/25-serial.js
View File

@ -41,11 +41,21 @@ function SerialOutNode(n) {
var node = this; var node = this;
node.port = serialPool.get(this.serialConfig.serialport,this.serialConfig.serialbaud,this.serialConfig.newline); node.port = serialPool.get(this.serialConfig.serialport,this.serialConfig.serialbaud,this.serialConfig.newline);
node.addCh = ""; node.addCh = "";
if (node.serialConfig.addchar == "true") { node.addCh = this.serialConfig.newline.replace("\\n","\n").replace("\\r","\r"); } if (node.serialConfig.addchar == "true") {
node.addCh = this.serialConfig.newline.replace("\\n","\n").replace("\\r","\r");
}
node.on("input",function(msg) { node.on("input",function(msg) {
var payload = msg.payload; var payload = msg.payload;
if (typeof payload === "object") { payload = JSON.stringify(payload); } if (!Buffer.isBuffer(payload)) {
if (typeof payload !== "buffer") { payload = new String(payload) + node.addCh; } if (typeof payload === "object") {
payload = JSON.stringify(payload);
} else {
payload = new String(payload);
}
payload += node.addCh;
} else if (node.addCh !== "") {
payload = Buffer.concat([payload,new Buffer(node.addCh)]);
}
node.port.write(payload,function(err,res) { node.port.write(payload,function(err,res) {
if (err) { if (err) {
node.error(err); node.error(err);
@ -86,7 +96,6 @@ function SerialInNode(n) {
serialPool.close(this.serialConfig.serialport); serialPool.close(this.serialConfig.serialport);
} catch(err) { } catch(err) {
} }
this.warn("Deploying with serial-port nodes is known to occasionally cause Node-RED to hang. This is due to an open issue with the underlying module.");
} }
}); });
} }